mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-26 02:39:48 +00:00
![Kees Cook](/assets/img/avatar_default.png)
The devm_kzalloc() function has a 2-factor argument form, devm_kcalloc(). This patch replaces cases of: devm_kzalloc(handle, a * b, gfp) with: devm_kcalloc(handle, a * b, gfp) as well as handling cases of: devm_kzalloc(handle, a * b * c, gfp) with: devm_kzalloc(handle, array3_size(a, b, c), gfp) as it's slightly less ugly than: devm_kcalloc(handle, array_size(a, b), c, gfp) This does, however, attempt to ignore constant size factors like: devm_kzalloc(handle, 4 * 1024, gfp) though any constants defined via macros get caught up in the conversion. Any factors with a sizeof() of "unsigned char", "char", and "u8" were dropped, since they're redundant. Some manual whitespace fixes were needed in this patch, as Coccinelle really liked to write "=devm_kcalloc..." instead of "= devm_kcalloc...". The Coccinelle script used for this was: // Fix redundant parens around sizeof(). @@ expression HANDLE; type TYPE; expression THING, E; @@ ( devm_kzalloc(HANDLE, - (sizeof(TYPE)) * E + sizeof(TYPE) * E , ...) | devm_kzalloc(HANDLE, - (sizeof(THING)) * E + sizeof(THING) * E , ...) ) // Drop single-byte sizes and redundant parens. @@ expression HANDLE; expression COUNT; typedef u8; typedef __u8; @@ ( devm_kzalloc(HANDLE, - sizeof(u8) * (COUNT) + COUNT , ...) | devm_kzalloc(HANDLE, - sizeof(__u8) * (COUNT) + COUNT , ...) | devm_kzalloc(HANDLE, - sizeof(char) * (COUNT) + COUNT , ...) | devm_kzalloc(HANDLE, - sizeof(unsigned char) * (COUNT) + COUNT , ...) | devm_kzalloc(HANDLE, - sizeof(u8) * COUNT + COUNT , ...) | devm_kzalloc(HANDLE, - sizeof(__u8) * COUNT + COUNT , ...) | devm_kzalloc(HANDLE, - sizeof(char) * COUNT + COUNT , ...) | devm_kzalloc(HANDLE, - sizeof(unsigned char) * COUNT + COUNT , ...) ) // 2-factor product with sizeof(type/expression) and identifier or constant. @@ expression HANDLE; type TYPE; expression THING; identifier COUNT_ID; constant COUNT_CONST; @@ ( - devm_kzalloc + devm_kcalloc (HANDLE, - sizeof(TYPE) * (COUNT_ID) + COUNT_ID, sizeof(TYPE) , ...) | - devm_kzalloc + devm_kcalloc (HANDLE, - sizeof(TYPE) * COUNT_ID + COUNT_ID, sizeof(TYPE) , ...) | - devm_kzalloc + devm_kcalloc (HANDLE, - sizeof(TYPE) * (COUNT_CONST) + COUNT_CONST, sizeof(TYPE) , ...) | - devm_kzalloc + devm_kcalloc (HANDLE, - sizeof(TYPE) * COUNT_CONST + COUNT_CONST, sizeof(TYPE) , ...) | - devm_kzalloc + devm_kcalloc (HANDLE, - sizeof(THING) * (COUNT_ID) + COUNT_ID, sizeof(THING) , ...) | - devm_kzalloc + devm_kcalloc (HANDLE, - sizeof(THING) * COUNT_ID + COUNT_ID, sizeof(THING) , ...) | - devm_kzalloc + devm_kcalloc (HANDLE, - sizeof(THING) * (COUNT_CONST) + COUNT_CONST, sizeof(THING) , ...) | - devm_kzalloc + devm_kcalloc (HANDLE, - sizeof(THING) * COUNT_CONST + COUNT_CONST, sizeof(THING) , ...) ) // 2-factor product, only identifiers. @@ expression HANDLE; identifier SIZE, COUNT; @@ - devm_kzalloc + devm_kcalloc (HANDLE, - SIZE * COUNT + COUNT, SIZE , ...) // 3-factor product with 1 sizeof(type) or sizeof(expression), with // redundant parens removed. @@ expression HANDLE; expression THING; identifier STRIDE, COUNT; type TYPE; @@ ( devm_kzalloc(HANDLE, - sizeof(TYPE) * (COUNT) * (STRIDE) + array3_size(COUNT, STRIDE, sizeof(TYPE)) , ...) | devm_kzalloc(HANDLE, - sizeof(TYPE) * (COUNT) * STRIDE + array3_size(COUNT, STRIDE, sizeof(TYPE)) , ...) | devm_kzalloc(HANDLE, - sizeof(TYPE) * COUNT * (STRIDE) + array3_size(COUNT, STRIDE, sizeof(TYPE)) , ...) | devm_kzalloc(HANDLE, - sizeof(TYPE) * COUNT * STRIDE + array3_size(COUNT, STRIDE, sizeof(TYPE)) , ...) | devm_kzalloc(HANDLE, - sizeof(THING) * (COUNT) * (STRIDE) + array3_size(COUNT, STRIDE, sizeof(THING)) , ...) | devm_kzalloc(HANDLE, - sizeof(THING) * (COUNT) * STRIDE + array3_size(COUNT, STRIDE, sizeof(THING)) , ...) | devm_kzalloc(HANDLE, - sizeof(THING) * COUNT * (STRIDE) + array3_size(COUNT, STRIDE, sizeof(THING)) , ...) | devm_kzalloc(HANDLE, - sizeof(THING) * COUNT * STRIDE + array3_size(COUNT, STRIDE, sizeof(THING)) , ...) ) // 3-factor product with 2 sizeof(variable), with redundant parens removed. @@ expression HANDLE; expression THING1, THING2; identifier COUNT; type TYPE1, TYPE2; @@ ( devm_kzalloc(HANDLE, - sizeof(TYPE1) * sizeof(TYPE2) * COUNT + array3_size(COUNT, sizeof(TYPE1), sizeof(TYPE2)) , ...) | devm_kzalloc(HANDLE, - sizeof(TYPE1) * sizeof(THING2) * (COUNT) + array3_size(COUNT, sizeof(TYPE1), sizeof(TYPE2)) , ...) | devm_kzalloc(HANDLE, - sizeof(THING1) * sizeof(THING2) * COUNT + array3_size(COUNT, sizeof(THING1), sizeof(THING2)) , ...) | devm_kzalloc(HANDLE, - sizeof(THING1) * sizeof(THING2) * (COUNT) + array3_size(COUNT, sizeof(THING1), sizeof(THING2)) , ...) | devm_kzalloc(HANDLE, - sizeof(TYPE1) * sizeof(THING2) * COUNT + array3_size(COUNT, sizeof(TYPE1), sizeof(THING2)) , ...) | devm_kzalloc(HANDLE, - sizeof(TYPE1) * sizeof(THING2) * (COUNT) + array3_size(COUNT, sizeof(TYPE1), sizeof(THING2)) , ...) ) // 3-factor product, only identifiers, with redundant parens removed. @@ expression HANDLE; identifier STRIDE, SIZE, COUNT; @@ ( devm_kzalloc(HANDLE, - (COUNT) * STRIDE * SIZE + array3_size(COUNT, STRIDE, SIZE) , ...) | devm_kzalloc(HANDLE, - COUNT * (STRIDE) * SIZE + array3_size(COUNT, STRIDE, SIZE) , ...) | devm_kzalloc(HANDLE, - COUNT * STRIDE * (SIZE) + array3_size(COUNT, STRIDE, SIZE) , ...) | devm_kzalloc(HANDLE, - (COUNT) * (STRIDE) * SIZE + array3_size(COUNT, STRIDE, SIZE) , ...) | devm_kzalloc(HANDLE, - COUNT * (STRIDE) * (SIZE) + array3_size(COUNT, STRIDE, SIZE) , ...) | devm_kzalloc(HANDLE, - (COUNT) * STRIDE * (SIZE) + array3_size(COUNT, STRIDE, SIZE) , ...) | devm_kzalloc(HANDLE, - (COUNT) * (STRIDE) * (SIZE) + array3_size(COUNT, STRIDE, SIZE) , ...) | devm_kzalloc(HANDLE, - COUNT * STRIDE * SIZE + array3_size(COUNT, STRIDE, SIZE) , ...) ) // Any remaining multi-factor products, first at least 3-factor products, // when they're not all constants... @@ expression HANDLE; expression E1, E2, E3; constant C1, C2, C3; @@ ( devm_kzalloc(HANDLE, C1 * C2 * C3, ...) | devm_kzalloc(HANDLE, - (E1) * E2 * E3 + array3_size(E1, E2, E3) , ...) | devm_kzalloc(HANDLE, - (E1) * (E2) * E3 + array3_size(E1, E2, E3) , ...) | devm_kzalloc(HANDLE, - (E1) * (E2) * (E3) + array3_size(E1, E2, E3) , ...) | devm_kzalloc(HANDLE, - E1 * E2 * E3 + array3_size(E1, E2, E3) , ...) ) // And then all remaining 2 factors products when they're not all constants, // keeping sizeof() as the second factor argument. @@ expression HANDLE; expression THING, E1, E2; type TYPE; constant C1, C2, C3; @@ ( devm_kzalloc(HANDLE, sizeof(THING) * C2, ...) | devm_kzalloc(HANDLE, sizeof(TYPE) * C2, ...) | devm_kzalloc(HANDLE, C1 * C2 * C3, ...) | devm_kzalloc(HANDLE, C1 * C2, ...) | - devm_kzalloc + devm_kcalloc (HANDLE, - sizeof(TYPE) * (E2) + E2, sizeof(TYPE) , ...) | - devm_kzalloc + devm_kcalloc (HANDLE, - sizeof(TYPE) * E2 + E2, sizeof(TYPE) , ...) | - devm_kzalloc + devm_kcalloc (HANDLE, - sizeof(THING) * (E2) + E2, sizeof(THING) , ...) | - devm_kzalloc + devm_kcalloc (HANDLE, - sizeof(THING) * E2 + E2, sizeof(THING) , ...) | - devm_kzalloc + devm_kcalloc (HANDLE, - (E1) * E2 + E1, E2 , ...) | - devm_kzalloc + devm_kcalloc (HANDLE, - (E1) * (E2) + E1, E2 , ...) | - devm_kzalloc + devm_kcalloc (HANDLE, - E1 * E2 + E1, E2 , ...) ) Signed-off-by: Kees Cook <keescook@chromium.org>
196 lines
4.6 KiB
C
196 lines
4.6 KiB
C
/*
|
|
* LED Driver for Dialog DA9052 PMICs.
|
|
*
|
|
* Copyright(c) 2012 Dialog Semiconductor Ltd.
|
|
*
|
|
* Author: David Dajun Chen <dchen@diasemi.com>
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify it
|
|
* under the terms of the GNU General Public License as published by the
|
|
* Free Software Foundation; either version 2 of the License, or (at your
|
|
* option) any later version.
|
|
*
|
|
*/
|
|
|
|
#include <linux/module.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/platform_device.h>
|
|
#include <linux/leds.h>
|
|
#include <linux/slab.h>
|
|
|
|
#include <linux/mfd/da9052/reg.h>
|
|
#include <linux/mfd/da9052/da9052.h>
|
|
#include <linux/mfd/da9052/pdata.h>
|
|
|
|
#define DA9052_OPENDRAIN_OUTPUT 2
|
|
#define DA9052_SET_HIGH_LVL_OUTPUT (1 << 3)
|
|
#define DA9052_MASK_UPPER_NIBBLE 0xF0
|
|
#define DA9052_MASK_LOWER_NIBBLE 0x0F
|
|
#define DA9052_NIBBLE_SHIFT 4
|
|
#define DA9052_MAX_BRIGHTNESS 0x5f
|
|
|
|
struct da9052_led {
|
|
struct led_classdev cdev;
|
|
struct da9052 *da9052;
|
|
unsigned char led_index;
|
|
unsigned char id;
|
|
};
|
|
|
|
static unsigned char led_reg[] = {
|
|
DA9052_LED_CONT_4_REG,
|
|
DA9052_LED_CONT_5_REG,
|
|
};
|
|
|
|
static int da9052_set_led_brightness(struct da9052_led *led,
|
|
enum led_brightness brightness)
|
|
{
|
|
u8 val;
|
|
int error;
|
|
|
|
val = (brightness & 0x7f) | DA9052_LED_CONT_DIM;
|
|
|
|
error = da9052_reg_write(led->da9052, led_reg[led->led_index], val);
|
|
if (error < 0)
|
|
dev_err(led->da9052->dev, "Failed to set led brightness, %d\n",
|
|
error);
|
|
return error;
|
|
}
|
|
|
|
static int da9052_led_set(struct led_classdev *led_cdev,
|
|
enum led_brightness value)
|
|
{
|
|
struct da9052_led *led =
|
|
container_of(led_cdev, struct da9052_led, cdev);
|
|
|
|
return da9052_set_led_brightness(led, value);
|
|
}
|
|
|
|
static int da9052_configure_leds(struct da9052 *da9052)
|
|
{
|
|
int error;
|
|
unsigned char register_value = DA9052_OPENDRAIN_OUTPUT
|
|
| DA9052_SET_HIGH_LVL_OUTPUT;
|
|
|
|
error = da9052_reg_update(da9052, DA9052_GPIO_14_15_REG,
|
|
DA9052_MASK_LOWER_NIBBLE,
|
|
register_value);
|
|
|
|
if (error < 0) {
|
|
dev_err(da9052->dev, "Failed to write GPIO 14-15 reg, %d\n",
|
|
error);
|
|
return error;
|
|
}
|
|
|
|
error = da9052_reg_update(da9052, DA9052_GPIO_14_15_REG,
|
|
DA9052_MASK_UPPER_NIBBLE,
|
|
register_value << DA9052_NIBBLE_SHIFT);
|
|
if (error < 0)
|
|
dev_err(da9052->dev, "Failed to write GPIO 14-15 reg, %d\n",
|
|
error);
|
|
|
|
return error;
|
|
}
|
|
|
|
static int da9052_led_probe(struct platform_device *pdev)
|
|
{
|
|
struct da9052_pdata *pdata;
|
|
struct da9052 *da9052;
|
|
struct led_platform_data *pled;
|
|
struct da9052_led *led = NULL;
|
|
int error = -ENODEV;
|
|
int i;
|
|
|
|
da9052 = dev_get_drvdata(pdev->dev.parent);
|
|
pdata = dev_get_platdata(da9052->dev);
|
|
if (pdata == NULL) {
|
|
dev_err(&pdev->dev, "No platform data\n");
|
|
goto err;
|
|
}
|
|
|
|
pled = pdata->pled;
|
|
if (pled == NULL) {
|
|
dev_err(&pdev->dev, "No platform data for LED\n");
|
|
goto err;
|
|
}
|
|
|
|
led = devm_kcalloc(&pdev->dev,
|
|
pled->num_leds, sizeof(struct da9052_led),
|
|
GFP_KERNEL);
|
|
if (!led) {
|
|
error = -ENOMEM;
|
|
goto err;
|
|
}
|
|
|
|
for (i = 0; i < pled->num_leds; i++) {
|
|
led[i].cdev.name = pled->leds[i].name;
|
|
led[i].cdev.brightness_set_blocking = da9052_led_set;
|
|
led[i].cdev.brightness = LED_OFF;
|
|
led[i].cdev.max_brightness = DA9052_MAX_BRIGHTNESS;
|
|
led[i].led_index = pled->leds[i].flags;
|
|
led[i].da9052 = dev_get_drvdata(pdev->dev.parent);
|
|
|
|
error = led_classdev_register(pdev->dev.parent, &led[i].cdev);
|
|
if (error) {
|
|
dev_err(&pdev->dev, "Failed to register led %d\n",
|
|
led[i].led_index);
|
|
goto err_register;
|
|
}
|
|
|
|
error = da9052_set_led_brightness(&led[i],
|
|
led[i].cdev.brightness);
|
|
if (error) {
|
|
dev_err(&pdev->dev, "Unable to init led %d\n",
|
|
led[i].led_index);
|
|
continue;
|
|
}
|
|
}
|
|
error = da9052_configure_leds(led->da9052);
|
|
if (error) {
|
|
dev_err(&pdev->dev, "Failed to configure GPIO LED%d\n", error);
|
|
goto err_register;
|
|
}
|
|
|
|
platform_set_drvdata(pdev, led);
|
|
|
|
return 0;
|
|
|
|
err_register:
|
|
for (i = i - 1; i >= 0; i--)
|
|
led_classdev_unregister(&led[i].cdev);
|
|
err:
|
|
return error;
|
|
}
|
|
|
|
static int da9052_led_remove(struct platform_device *pdev)
|
|
{
|
|
struct da9052_led *led = platform_get_drvdata(pdev);
|
|
struct da9052_pdata *pdata;
|
|
struct da9052 *da9052;
|
|
struct led_platform_data *pled;
|
|
int i;
|
|
|
|
da9052 = dev_get_drvdata(pdev->dev.parent);
|
|
pdata = dev_get_platdata(da9052->dev);
|
|
pled = pdata->pled;
|
|
|
|
for (i = 0; i < pled->num_leds; i++) {
|
|
da9052_set_led_brightness(&led[i], LED_OFF);
|
|
led_classdev_unregister(&led[i].cdev);
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static struct platform_driver da9052_led_driver = {
|
|
.driver = {
|
|
.name = "da9052-leds",
|
|
},
|
|
.probe = da9052_led_probe,
|
|
.remove = da9052_led_remove,
|
|
};
|
|
|
|
module_platform_driver(da9052_led_driver);
|
|
|
|
MODULE_AUTHOR("Dialog Semiconductor Ltd <dchen@diasemi.com>");
|
|
MODULE_DESCRIPTION("LED driver for Dialog DA9052 PMIC");
|
|
MODULE_LICENSE("GPL");
|