Benjamin Poirier 2114e83381 selftests: forwarding: Avoid failures to source net/lib.sh ... The expression "source ../lib.sh" added to net/forwarding/lib.sh in commit 25ae948b44 ("selftests/net: add lib.sh") does not work for tests outside net/forwarding which source net/forwarding/lib.sh (1). It also does not work in some cases where only a subset of tests are exported (2). Avoid the problems mentioned above by replacing the faulty expression with a copy of the content from net/lib.sh which is used by files under net/forwarding. A more thorough solution which avoids duplicating content between net/lib.sh and net/forwarding/lib.sh has been posted here: https://lore.kernel.org/netdev/20231222135836.992841-1-bpoirier@nvidia.com/ The approach in the current patch is a stopgap solution to avoid submitting large changes at the eleventh hour of this development cycle. Example of problem 1) tools/testing/selftests/drivers/net/bonding$ ./dev_addr_lists.sh ./net_forwarding_lib.sh: line 41: ../lib.sh: No such file or directory TEST: bonding cleanup mode active-backup [ OK ] TEST: bonding cleanup mode 802.3ad [ OK ] TEST: bonding LACPDU multicast address to slave (from bond down) [ OK ] TEST: bonding LACPDU multicast address to slave (from bond up) [ OK ] An error message is printed but since the test does not use functions from net/lib.sh, the test results are not affected. Example of problem 2) tools/testing/selftests$ make install TARGETS="net/forwarding" tools/testing/selftests$ cd kselftest_install/net/forwarding/ tools/testing/selftests/kselftest_install/net/forwarding$ ./pedit_ip.sh veth{0..3} lib.sh: line 41: ../lib.sh: No such file or directory TEST: ping [ OK ] TEST: ping6 [ OK ] ./pedit_ip.sh: line 135: busywait: command not found TEST: dev veth1 ingress pedit ip src set 198.51.100.1 [FAIL] Expected to get 10 packets, but got . ./pedit_ip.sh: line 135: busywait: command not found TEST: dev veth2 egress pedit ip src set 198.51.100.1 [FAIL] Expected to get 10 packets, but got . ./pedit_ip.sh: line 135: busywait: command not found TEST: dev veth1 ingress pedit ip dst set 198.51.100.1 [FAIL] Expected to get 10 packets, but got . ./pedit_ip.sh: line 135: busywait: command not found TEST: dev veth2 egress pedit ip dst set 198.51.100.1 [FAIL] Expected to get 10 packets, but got . ./pedit_ip.sh: line 135: busywait: command not found TEST: dev veth1 ingress pedit ip6 src set 2001:db8:2::1 [FAIL] Expected to get 10 packets, but got . ./pedit_ip.sh: line 135: busywait: command not found TEST: dev veth2 egress pedit ip6 src set 2001:db8:2::1 [FAIL] Expected to get 10 packets, but got . ./pedit_ip.sh: line 135: busywait: command not found TEST: dev veth1 ingress pedit ip6 dst set 2001:db8:2::1 [FAIL] Expected to get 10 packets, but got . ./pedit_ip.sh: line 135: busywait: command not found TEST: dev veth2 egress pedit ip6 dst set 2001:db8:2::1 [FAIL] Expected to get 10 packets, but got . In this case, the test results are affected. Fixes: 25ae948b44 ("selftests/net: add lib.sh") Suggested-by: Ido Schimmel <idosch@nvidia.com> Suggested-by: Petr Machata <petrm@nvidia.com> Reviewed-by: Ido Schimmel <idosch@nvidia.com> Tested-by: Petr Machata <petrm@nvidia.com> Signed-off-by: Benjamin Poirier <bpoirier@nvidia.com> Reviewed-by: Hangbin Liu <liuhangbin@gmail.com> Link: https://lore.kernel.org/r/20240104141109.100672-1-bpoirier@nvidia.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>		2024-01-05 19:23:11 -08:00
..
accounting
arch	perf tools fixes for v6.7: 1st batch	2023-12-01 10:17:16 +09:00
bootconfig
bpf	bpfilter: remove bpfilter	2024-01-04 10:23:10 -08:00
build	perf tools fixes for v6.6: 2nd batch	2023-10-30 13:46:27 -07:00
certs
cgroup
counter
crypto/ccp
debugging
edid
firewire
firmware
gpio
hv	hv/hv_kvp_daemon: Some small fixes for handling NM keyfiles	2023-11-10 23:27:46 +00:00
iio
include	net/sched: Remove uapi support for CBQ qdisc	2024-01-02 14:25:51 +00:00
kvm/kvm_stat
laptop
leds
lib	libbpf: implement __arg_ctx fallback logic	2024-01-03 21:22:49 -08:00
memory-model
mm	tools/mm: update the usage output to be more organized	2023-10-18 14:34:19 -07:00
net/ynl	tools/net/ynl-gen-rst: Remove extra indentation from generated docs	2023-12-18 14:39:44 -08:00
objtool	cred: get rid of CONFIG_DEBUG_CREDENTIALS	2023-12-15 14:19:48 -08:00
pci
pcmcia
perf	perf list: Fix JSON segfault by setting the used skip_duplicate_pmus callback	2023-12-05 11:16:00 -08:00
power	PM: tools: Fix sleepgraph syntax error	2023-11-20 17:59:58 +01:00
rcu
scripts	tools/build: Fix -s detection code in tools/scripts/Makefile.include	2023-10-18 15:29:47 -07:00
spi
testing	selftests: forwarding: Avoid failures to source net/lib.sh	2024-01-05 19:23:11 -08:00
thermal	tools/thermal: Remove unused 'mds' and 'nrhandler' variables	2023-10-15 23:40:10 +02:00
time
tracing	rtla: Fix uninitialized variable found	2023-10-30 19:00:12 +01:00
usb
verification	verification/dot2k: Delete duplicate imports	2023-10-30 16:59:12 +01:00
virtio	tools/virtio: Add dma sync api for virtio test	2023-10-16 05:32:23 -04:00
wmi
workqueue
Makefile