mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-15 15:15:47 +00:00
c5a61db9bf
My randconfig build setup ran into a rare build failure with CONFIG_SND_SOC_SOF_INTEL_SOUNDWIRE_LINK_BASELINE=y CONFIG_SND_SOC_SOF_INTEL_SOUNDWIRE=m CONFIG_SOUNDWIRE=y CONFIG_SOUNDWIRE_INTEL=m CONFIG_SND_SOC_SOF_HDA=y CONFIG_SND_SOC_SOF_INTEL_TGL=y x86_64-linux-ld: sound/soc/sof/intel/hda.o: in function `hda_init_caps': hda.c:(.text+0x691): undefined reference to `sdw_intel_cnl_hw_ops' x86_64-linux-ld: hda.c:(.text+0x6f2): undefined reference to `sdw_intel_probe' x86_64-linux-ld: sound/soc/sof/intel/hda.o: in function `hda_sdw_startup': hda.c:(.text+0x1c40): undefined reference to `sdw_intel_startup' x86_64-linux-ld: sound/soc/sof/intel/hda.o: in function `hda_sdw_process_wakeen': hda.c:(.text+0x1cb6): undefined reference to `sdw_intel_process_wakeen_event' x86_64-linux-ld: sound/soc/sof/intel/hda.o: in function `hda_dsp_interrupt_thread': hda.c:(.text+0x1d67): undefined reference to `sdw_intel_thread' x86_64-linux-ld: sound/soc/sof/intel/hda.o: in function `hda_dsp_remove': hda.c:(.text+0x2655): undefined reference to `sdw_intel_exit' My best understanding is that the definition of SND_SOC_SOF_INTEL_SOUNDWIRE_LINK_BASELINE was intended to avoid this problem, but got it wrong for the SND_SOC_SOF_INTEL_SOUNDWIRE=m case, where the 'select' is meant to set SOUNDWIRE_INTEL to the value of SND_SOC_SOF_INTEL_SOUNDWIRE_LINK_BASELINE rather than the intersection of SND_SOC_SOF_INTEL_SOUNDWIRE_LINK_BASELINE and SND_SOC_SOF_INTEL_SOUNDWIRE. Change the condition to check for SND_SOC_SOF_INTEL_SOUNDWIRE to be a boolean rather than a tristate expression in order to propagate this as intended. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Link: https://lore.kernel.org/r/20230202102247.806749-1-arnd@kernel.org Signed-off-by: Mark Brown <broonie@kernel.org> |
||
|---|---|---|
| .. | ||
| amd | ||
| imx | ||
| intel | ||
| mediatek | ||
| xtensa | ||
| compress.c | ||
| control.c | ||
| core.c | ||
| debug.c | ||
| iomem-utils.c | ||
| ipc.c | ||
| ipc3-control.c | ||
| ipc3-dtrace.c | ||
| ipc3-loader.c | ||
| ipc3-pcm.c | ||
| ipc3-priv.h | ||
| ipc3-topology.c | ||
| ipc3.c | ||
| ipc4-control.c | ||
| ipc4-loader.c | ||
| ipc4-mtrace.c | ||
| ipc4-pcm.c | ||
| ipc4-priv.h | ||
| ipc4-topology.c | ||
| ipc4-topology.h | ||
| ipc4.c | ||
| Kconfig | ||
| loader.c | ||
| Makefile | ||
| nocodec.c | ||
| ops.c | ||
| ops.h | ||
| pcm.c | ||
| pm.c | ||
| sof-acpi-dev.c | ||
| sof-acpi-dev.h | ||
| sof-audio.c | ||
| sof-audio.h | ||
| sof-client-ipc-flood-test.c | ||
| sof-client-ipc-msg-injector.c | ||
| sof-client-probes-ipc3.c | ||
| sof-client-probes-ipc4.c | ||
| sof-client-probes.c | ||
| sof-client-probes.h | ||
| sof-client.c | ||
| sof-client.h | ||
| sof-of-dev.c | ||
| sof-of-dev.h | ||
| sof-pci-dev.c | ||
| sof-pci-dev.h | ||
| sof-priv.h | ||
| sof-utils.c | ||
| sof-utils.h | ||
| stream-ipc.c | ||
| topology.c | ||
| trace.c | ||