mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-31 16:38:12 +00:00
f2644fb44d
Add selftest validating various aspects of statically linking functions:
- no conflicts and correct resolution for name-conflicting static funcs;
- correct resolution of extern functions;
- correct handling of weak functions, both resolution itself and libbpf's
handling of unused weak function that "lost" (it leaves gaps in code with
no ELF symbols);
- correct handling of hidden visibility to turn global function into
"static" for the purpose of BPF verification.
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Acked-by: Yonghong Song <yhs@fb.com>
Link: https://lore.kernel.org/bpf/20210423181348.1801389-16-andrii@kernel.org
73 lines
1.9 KiB
C
73 lines
1.9 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
/* Copyright (c) 2021 Facebook */
|
|
|
|
#include "vmlinux.h"
|
|
#include <bpf/bpf_helpers.h>
|
|
#include <bpf/bpf_tracing.h>
|
|
|
|
/* weak and shared between two files */
|
|
const volatile int my_tid __weak;
|
|
long syscall_id __weak;
|
|
|
|
int output_val1;
|
|
int output_ctx1;
|
|
int output_weak1;
|
|
|
|
/* same "subprog" name in all files, but it's ok because they all are static */
|
|
static __noinline int subprog(int x)
|
|
{
|
|
/* but different formula */
|
|
return x * 1;
|
|
}
|
|
|
|
/* Global functions can't be void */
|
|
int set_output_val1(int x)
|
|
{
|
|
output_val1 = x + subprog(x);
|
|
return x;
|
|
}
|
|
|
|
/* This function can't be verified as global, as it assumes raw_tp/sys_enter
|
|
* context and accesses syscall id (second argument). So we mark it as
|
|
* __hidden, so that libbpf will mark it as static in the final object file,
|
|
* right before verifying it in the kernel.
|
|
*
|
|
* But we don't mark it as __hidden here, rather at extern site. __hidden is
|
|
* "contaminating" visibility, so it will get propagated from either extern or
|
|
* actual definition (including from the losing __weak definition).
|
|
*/
|
|
void set_output_ctx1(__u64 *ctx)
|
|
{
|
|
output_ctx1 = ctx[1]; /* long id, same as in BPF_PROG below */
|
|
}
|
|
|
|
/* this weak instance should win because it's the first one */
|
|
__weak int set_output_weak(int x)
|
|
{
|
|
output_weak1 = x;
|
|
return x;
|
|
}
|
|
|
|
extern int set_output_val2(int x);
|
|
|
|
/* here we'll force set_output_ctx2() to be __hidden in the final obj file */
|
|
__hidden extern void set_output_ctx2(__u64 *ctx);
|
|
|
|
SEC("raw_tp/sys_enter")
|
|
int BPF_PROG(handler1, struct pt_regs *regs, long id)
|
|
{
|
|
if (my_tid != (u32)bpf_get_current_pid_tgid() || id != syscall_id)
|
|
return 0;
|
|
|
|
set_output_val2(1000);
|
|
set_output_ctx2(ctx); /* ctx definition is hidden in BPF_PROG macro */
|
|
|
|
/* keep input value the same across both files to avoid dependency on
|
|
* handler call order; differentiate by output_weak1 vs output_weak2.
|
|
*/
|
|
set_output_weak(42);
|
|
|
|
return 0;
|
|
}
|
|
|
|
char LICENSE[] SEC("license") = "GPL";
|