linux-stable/drivers/input
Stephan Gerhold c694050c96 Input: pm8xxx-vib - fix handling of separate enable register
commit 996d5d5f89 upstream.

Setting the vibrator enable_mask is not implemented correctly:

For regmap_update_bits(map, reg, mask, val) we give in either
regs->enable_mask or 0 (= no-op) as mask and "val" as value.
But "val" actually refers to the vibrator voltage control register,
which has nothing to do with the enable_mask.

So we usually end up doing nothing when we really wanted
to enable the vibrator.

We want to set or clear the enable_mask (to enable/disable the vibrator).
Therefore, change the call to always modify the enable_mask
and set the bits only if we want to enable the vibrator.

Fixes: d4c7c5c96c ("Input: pm8xxx-vib - handle separate enable register")
Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
Link: https://lore.kernel.org/r/20200114183442.45720-1-stephan@gerhold.net
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2020-01-29 16:43:20 +01:00
..
gameport Input: stop telling users to snail-mail Vojtech 2018-07-26 17:04:37 -07:00
joystick Input: Fix memory leak in psxpad_spi_probe 2019-12-13 08:52:40 +01:00
keyboard Input: nomadik-ske-keypad - fix a loop timeout test 2020-01-27 14:50:07 +01:00
misc Input: pm8xxx-vib - fix handling of separate enable register 2020-01-29 16:43:20 +01:00
mouse Input: synaptics - switch another X1 Carbon 6 to RMI/SMbus 2019-12-13 08:52:38 +01:00
rmi4 Revert "Input: synaptics-rmi4 - don't increment rmiaddr for SMBus transfers" 2020-01-29 16:43:19 +01:00
serio parisc: Fix HP SDC hpa address output 2019-12-05 09:19:57 +01:00
tablet Input: kbtab - sanity check for endpoint type 2019-08-25 10:47:49 +02:00
touchscreen Input: atmel_mxt_ts - disable IRQ across suspend 2020-01-04 19:12:36 +01:00
apm-power.c
evbug.c Input: stop telling users to snail-mail Vojtech 2018-07-26 17:04:37 -07:00
evdev.c Input: input_event - fix struct padding on sparc64 2020-01-14 20:07:01 +01:00
ff-core.c
ff-memless.c Input: ff-memless - kill timer in destroy() 2019-11-20 18:45:14 +01:00
input-compat.c Input: extend usable life of event timestamps to 2106 on 32 bit systems 2018-01-09 16:40:30 -08:00
input-compat.h Input: extend usable life of event timestamps to 2106 on 32 bit systems 2018-01-09 16:40:30 -08:00
input-leds.c treewide: Use struct_size() for kmalloc()-family 2018-06-06 11:15:43 -07:00
input-mt.c Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input 2018-06-27 09:16:53 -07:00
input-polldev.c Input: remove remaining unneeded MODULE_VERSION() usage 2018-01-16 16:48:25 -08:00
input.c Input: add safety guards to input_set_keycode() 2020-01-14 20:07:01 +01:00
joydev.c vfs: do bulk POLL* -> EPOLL* replacement 2018-02-11 14:34:03 -08:00
Kconfig docs: fix broken references with multiple hints 2018-06-15 18:10:01 -03:00
Makefile
matrix-keymap.c treewide: devm_kzalloc() -> devm_kcalloc() 2018-06-12 16:19:22 -07:00
mousedev.c Input: mousedev - add a schedule point in mousedev_write() 2018-10-04 17:42:26 -07:00
sparse-keymap.c Input: remove remaining unneeded MODULE_VERSION() usage 2018-01-16 16:48:25 -08:00