mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-11 11:09:13 +00:00
a774635db5
The APIC ID as parsed from ACPI MADT is validity checked with the apic->apic_id_valid() callback, which depends on the selected APIC type. For non X2APIC types APIC IDs >= 0xFF are invalid, but values > 0x7FFFFFFF are detected as valid. This happens because the 'apicid' argument of the apic_id_valid() callback is type 'int'. So the resulting comparison apicid < 0xFF evaluates to true for all unsigned int values > 0x7FFFFFFF which are handed to default_apic_id_valid(). As a consequence, invalid APIC IDs in !X2APIC mode are considered valid and accounted as possible CPUs. Change the apicid argument type of the apic_id_valid() callback to u32 so the evaluation is unsigned and returns the correct result. [ tglx: Massaged changelog ] Signed-off-by: Li RongQing <lirongqing@baidu.com> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Cc: stable@vger.kernel.org Cc: jgross@suse.com Cc: Dou Liyang <douly.fnst@cn.fujitsu.com> Cc: Peter Zijlstra <peterz@infradead.org> Cc: hpa@zytor.com Link: https://lkml.kernel.org/r/1523322966-10296-1-git-send-email-lirongqing@baidu.com
9 lines
400 B
C
9 lines
400 B
C
/* Common bits for X2APIC cluster/physical modes. */
|
|
|
|
int x2apic_apic_id_valid(u32 apicid);
|
|
int x2apic_apic_id_registered(void);
|
|
void __x2apic_send_IPI_dest(unsigned int apicid, int vector, unsigned int dest);
|
|
unsigned int x2apic_get_apic_id(unsigned long id);
|
|
u32 x2apic_set_apic_id(unsigned int id);
|
|
int x2apic_phys_pkg_id(int initial_apicid, int index_msb);
|
|
void x2apic_send_IPI_self(int vector);
|