Maurizio Lombardi 1533b8b305 scsi: target: iscsi: Fix a race condition between login_work and the login thread ... [ Upstream commit fec1b2fa62 ] In case a malicious initiator sends some random data immediately after a login PDU; the iscsi_target_sk_data_ready() callback will schedule the login_work and, at the same time, the negotiation may end without clearing the LOGIN_FLAGS_INITIAL_PDU flag (because no additional PDU exchanges are required to complete the login). The login has been completed but the login_work function will find the LOGIN_FLAGS_INITIAL_PDU flag set and will never stop from rescheduling itself; at this point, if the initiator drops the connection, the iscsit_conn structure will be freed, login_work will dereference a released socket structure and the kernel crashes. BUG: kernel NULL pointer dereference, address: 0000000000000230 PF: supervisor write access in kernel mode PF: error_code(0x0002) - not-present page Workqueue: events iscsi_target_do_login_rx [iscsi_target_mod] RIP: 0010:_raw_read_lock_bh+0x15/0x30 Call trace: iscsi_target_do_login_rx+0x75/0x3f0 [iscsi_target_mod] process_one_work+0x1e8/0x3c0 Fix this bug by forcing login_work to stop after the login has been completed and the socket callbacks have been restored. Add a comment to clearify the return values of iscsi_target_do_login() Signed-off-by: Maurizio Lombardi <mlombard@redhat.com> Link: https://lore.kernel.org/r/20221115125638.102517-1-mlombard@redhat.com Reviewed-by: Mike Christie <michael.christie@oracle.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> Signed-off-by: Sasha Levin <sashal@kernel.org>		2022-12-31 13:26:48 +01:00
..
iscsi	scsi: target: iscsi: Fix a race condition between login_work and the login thread	2022-12-31 13:26:48 +01:00
loopback	scsi: target: tcm_loop: Fix possible name leak in tcm_loop_setup_hba_bus()	2022-11-26 09:27:53 +01:00
sbp
tcm_fc
Kconfig
Makefile
target_core_alua.c	scsi: target: core: De-RCU of se_lun and se_lun acl	2022-08-01 19:36:02 -04:00
target_core_alua.h
target_core_configfs.c
target_core_device.c	scsi: target: core: De-RCU of se_lun and se_lun acl	2022-08-01 19:36:02 -04:00
target_core_fabric_configfs.c
target_core_fabric_lib.c
target_core_file.c	SCSI misc on 20220804	2022-08-04 19:47:37 -07:00
target_core_file.h
target_core_hba.c
target_core_iblock.c	SCSI misc on 20220804	2022-08-04 19:47:37 -07:00
target_core_iblock.h
target_core_internal.h
target_core_pr.c	scsi: target: core: De-RCU of se_lun and se_lun acl	2022-08-01 19:36:02 -04:00
target_core_pr.h
target_core_pscsi.c
target_core_pscsi.h
target_core_rd.c
target_core_rd.h
target_core_sbc.c	SCSI misc on 20220804	2022-08-04 19:47:37 -07:00
target_core_spc.c
target_core_stat.c	scsi: target: core: De-RCU of se_lun and se_lun acl	2022-08-01 19:36:02 -04:00
target_core_tmr.c
target_core_tpg.c
target_core_transport.c
target_core_ua.c
target_core_ua.h
target_core_user.c
target_core_xcopy.c	scsi: target: core: De-RCU of se_lun and se_lun acl	2022-08-01 19:36:02 -04:00
target_core_xcopy.h