mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-05 18:39:59 +00:00
e4df1511e1
objtool pointed out that various idle-TIF management methods have instrumentation: vmlinux.o: warning: objtool: mwait_idle+0x5: call to current_set_polling_and_test() leaves .noinstr.text section vmlinux.o: warning: objtool: acpi_processor_ffh_cstate_enter+0xc5: call to current_set_polling_and_test() leaves .noinstr.text section vmlinux.o: warning: objtool: cpu_idle_poll.isra.0+0x73: call to test_ti_thread_flag() leaves .noinstr.text section vmlinux.o: warning: objtool: intel_idle+0xbc: call to current_set_polling_and_test() leaves .noinstr.text section vmlinux.o: warning: objtool: intel_idle_irq+0xea: call to current_set_polling_and_test() leaves .noinstr.text section vmlinux.o: warning: objtool: intel_idle_s2idle+0xb4: call to current_set_polling_and_test() leaves .noinstr.text section vmlinux.o: warning: objtool: intel_idle+0xa6: call to current_clr_polling() leaves .noinstr.text section vmlinux.o: warning: objtool: intel_idle_irq+0xbf: call to current_clr_polling() leaves .noinstr.text section vmlinux.o: warning: objtool: intel_idle_s2idle+0xa1: call to current_clr_polling() leaves .noinstr.text section vmlinux.o: warning: objtool: mwait_idle+0xe: call to __current_set_polling() leaves .noinstr.text section vmlinux.o: warning: objtool: acpi_processor_ffh_cstate_enter+0xc5: call to __current_set_polling() leaves .noinstr.text section vmlinux.o: warning: objtool: cpu_idle_poll.isra.0+0x73: call to test_ti_thread_flag() leaves .noinstr.text section vmlinux.o: warning: objtool: intel_idle+0xbc: call to __current_set_polling() leaves .noinstr.text section vmlinux.o: warning: objtool: intel_idle_irq+0xea: call to __current_set_polling() leaves .noinstr.text section vmlinux.o: warning: objtool: intel_idle_s2idle+0xb4: call to __current_set_polling() leaves .noinstr.text section vmlinux.o: warning: objtool: cpu_idle_poll.isra.0+0x73: call to test_ti_thread_flag() leaves .noinstr.text section vmlinux.o: warning: objtool: intel_idle_s2idle+0x73: call to test_ti_thread_flag.constprop.0() leaves .noinstr.text section vmlinux.o: warning: objtool: intel_idle_irq+0x91: call to test_ti_thread_flag.constprop.0() leaves .noinstr.text section vmlinux.o: warning: objtool: intel_idle+0x78: call to test_ti_thread_flag.constprop.0() leaves .noinstr.text section vmlinux.o: warning: objtool: acpi_safe_halt+0xf: call to test_ti_thread_flag.constprop.0() leaves .noinstr.text section Remove the instrumentation, because these methods are used in low-level cpuidle code moving between states, that should not be instrumented. Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> Signed-off-by: Ingo Molnar <mingo@kernel.org> Tested-by: Tony Lindgren <tony@atomide.com> Tested-by: Ulf Hansson <ulf.hansson@linaro.org> Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Acked-by: Frederic Weisbecker <frederic@kernel.org> Link: https://lore.kernel.org/r/20230112195540.988741683@infradead.org
111 lines
2.4 KiB
C
111 lines
2.4 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
#ifndef _LINUX_SCHED_IDLE_H
|
|
#define _LINUX_SCHED_IDLE_H
|
|
|
|
#include <linux/sched.h>
|
|
|
|
enum cpu_idle_type {
|
|
CPU_IDLE,
|
|
CPU_NOT_IDLE,
|
|
CPU_NEWLY_IDLE,
|
|
CPU_MAX_IDLE_TYPES
|
|
};
|
|
|
|
#ifdef CONFIG_SMP
|
|
extern void wake_up_if_idle(int cpu);
|
|
#else
|
|
static inline void wake_up_if_idle(int cpu) { }
|
|
#endif
|
|
|
|
/*
|
|
* Idle thread specific functions to determine the need_resched
|
|
* polling state.
|
|
*/
|
|
#ifdef TIF_POLLING_NRFLAG
|
|
|
|
#ifdef _ASM_GENERIC_BITOPS_INSTRUMENTED_ATOMIC_H
|
|
|
|
static __always_inline void __current_set_polling(void)
|
|
{
|
|
arch_set_bit(TIF_POLLING_NRFLAG,
|
|
(unsigned long *)(¤t_thread_info()->flags));
|
|
}
|
|
|
|
static __always_inline void __current_clr_polling(void)
|
|
{
|
|
arch_clear_bit(TIF_POLLING_NRFLAG,
|
|
(unsigned long *)(¤t_thread_info()->flags));
|
|
}
|
|
|
|
#else
|
|
|
|
static __always_inline void __current_set_polling(void)
|
|
{
|
|
set_bit(TIF_POLLING_NRFLAG,
|
|
(unsigned long *)(¤t_thread_info()->flags));
|
|
}
|
|
|
|
static __always_inline void __current_clr_polling(void)
|
|
{
|
|
clear_bit(TIF_POLLING_NRFLAG,
|
|
(unsigned long *)(¤t_thread_info()->flags));
|
|
}
|
|
|
|
#endif /* _ASM_GENERIC_BITOPS_INSTRUMENTED_ATOMIC_H */
|
|
|
|
static __always_inline bool __must_check current_set_polling_and_test(void)
|
|
{
|
|
__current_set_polling();
|
|
|
|
/*
|
|
* Polling state must be visible before we test NEED_RESCHED,
|
|
* paired by resched_curr()
|
|
*/
|
|
smp_mb__after_atomic();
|
|
|
|
return unlikely(tif_need_resched());
|
|
}
|
|
|
|
static __always_inline bool __must_check current_clr_polling_and_test(void)
|
|
{
|
|
__current_clr_polling();
|
|
|
|
/*
|
|
* Polling state must be visible before we test NEED_RESCHED,
|
|
* paired by resched_curr()
|
|
*/
|
|
smp_mb__after_atomic();
|
|
|
|
return unlikely(tif_need_resched());
|
|
}
|
|
|
|
#else
|
|
static inline void __current_set_polling(void) { }
|
|
static inline void __current_clr_polling(void) { }
|
|
|
|
static inline bool __must_check current_set_polling_and_test(void)
|
|
{
|
|
return unlikely(tif_need_resched());
|
|
}
|
|
static inline bool __must_check current_clr_polling_and_test(void)
|
|
{
|
|
return unlikely(tif_need_resched());
|
|
}
|
|
#endif
|
|
|
|
static __always_inline void current_clr_polling(void)
|
|
{
|
|
__current_clr_polling();
|
|
|
|
/*
|
|
* Ensure we check TIF_NEED_RESCHED after we clear the polling bit.
|
|
* Once the bit is cleared, we'll get IPIs with every new
|
|
* TIF_NEED_RESCHED and the IPI handler, scheduler_ipi(), will also
|
|
* fold.
|
|
*/
|
|
smp_mb(); /* paired with resched_curr() */
|
|
|
|
preempt_fold_need_resched();
|
|
}
|
|
|
|
#endif /* _LINUX_SCHED_IDLE_H */
|