mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-16 15:45:45 +00:00
00b42b70ae
The current codebase makes use of the zero-length array language extension
to the C90 standard, but the preferred mechanism to declare variable-length
types such as these ones is a flexible array member[1][2], introduced in
C99:
struct foo {
int stuff;
struct boo array[];
};
By making use of the mechanism above, we will get a compiler warning in
case the flexible array does not occur last in the structure, which will
help us prevent some kind of undefined behavior bugs from being
inadvertently introduced[3] to the codebase from now on.
Also, notice that, dynamic memory allocations won't be affected by this
change:
"Flexible array members have incomplete type, and so the sizeof operator
may not be applied. As a quirk of the original implementation of
zero-length arrays, sizeof evaluates to zero."[1]
sizeof(flexible-array-member) triggers a warning because flexible array
members have incomplete type[1]. There are some instances of code in which
the sizeof operator is being incorrectly/erroneously applied to zero-length
arrays and the result is zero. Such instances may be hiding some bugs. So,
this work (flexible-array member conversions) will also help to get
completely rid of those sorts of issues.
This issue was found with the help of Coccinelle.
[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit
|
||
|---|---|---|
| .. | ||
| aic94xx.h | ||
| aic94xx_dev.c | ||
| aic94xx_dump.c | ||
| aic94xx_dump.h | ||
| aic94xx_hwi.c | ||
| aic94xx_hwi.h | ||
| aic94xx_init.c | ||
| aic94xx_reg.c | ||
| aic94xx_reg.h | ||
| aic94xx_reg_def.h | ||
| aic94xx_sas.h | ||
| aic94xx_scb.c | ||
| aic94xx_sds.c | ||
| aic94xx_sds.h | ||
| aic94xx_seq.c | ||
| aic94xx_seq.h | ||
| aic94xx_task.c | ||
| aic94xx_tmf.c | ||
| Kconfig | ||
| Makefile | ||