mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-26 10:49:33 +00:00
![Will Newton](/assets/img/avatar_default.png)
Recent changes to tighten the check for UARTs that don't correctly
re-assert THRE (01c194d927
: "serial 8250:
tighten test for using backup timer") caused problems when such a UART was
opened for the second time - the bug could only successfully be detected
at first initialization. For users of this version of this particular
UART IP it is fatal.
This patch stores the information about the bug in the bugs field of the
port structure when the port is first started up so subsequent opens can
check this bit even if the test for the bug fails.
David Brownell: "My own exposure to this is that the UART on DaVinci
hardware, which TI allegedly derived from its original 16550 logic, has
periodically gone from working to unusable with the mainline 8250.c ...
and back and forth a bunch. Currently it's "unusable", a regression from
some previous versions. With this patch from Will, it's usable."
Signed-off-by: Will Newton <will.newton@gmail.com>
Acked-by: Alex Williamson <alex.williamson@hp.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: David Brownell <david-b@pacbell.net>
Cc: <stable@kernel.org> [2.6.26.x]
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
79 lines
2.4 KiB
C
79 lines
2.4 KiB
C
/*
|
|
* linux/drivers/char/8250.h
|
|
*
|
|
* Driver for 8250/16550-type serial ports
|
|
*
|
|
* Based on drivers/char/serial.c, by Linus Torvalds, Theodore Ts'o.
|
|
*
|
|
* Copyright (C) 2001 Russell King.
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*/
|
|
|
|
#include <linux/serial_8250.h>
|
|
|
|
struct old_serial_port {
|
|
unsigned int uart;
|
|
unsigned int baud_base;
|
|
unsigned int port;
|
|
unsigned int irq;
|
|
unsigned int flags;
|
|
unsigned char hub6;
|
|
unsigned char io_type;
|
|
unsigned char *iomem_base;
|
|
unsigned short iomem_reg_shift;
|
|
};
|
|
|
|
/*
|
|
* This replaces serial_uart_config in include/linux/serial.h
|
|
*/
|
|
struct serial8250_config {
|
|
const char *name;
|
|
unsigned short fifo_size;
|
|
unsigned short tx_loadsz;
|
|
unsigned char fcr;
|
|
unsigned int flags;
|
|
};
|
|
|
|
#define UART_CAP_FIFO (1 << 8) /* UART has FIFO */
|
|
#define UART_CAP_EFR (1 << 9) /* UART has EFR */
|
|
#define UART_CAP_SLEEP (1 << 10) /* UART has IER sleep */
|
|
#define UART_CAP_AFE (1 << 11) /* MCR-based hw flow control */
|
|
#define UART_CAP_UUE (1 << 12) /* UART needs IER bit 6 set (Xscale) */
|
|
|
|
#define UART_BUG_QUOT (1 << 0) /* UART has buggy quot LSB */
|
|
#define UART_BUG_TXEN (1 << 1) /* UART has buggy TX IIR status */
|
|
#define UART_BUG_NOMSR (1 << 2) /* UART has buggy MSR status bits (Au1x00) */
|
|
#define UART_BUG_THRE (1 << 3) /* UART has buggy THRE reassertion */
|
|
|
|
#define PROBE_RSA (1 << 0)
|
|
#define PROBE_ANY (~0)
|
|
|
|
#define HIGH_BITS_OFFSET ((sizeof(long)-sizeof(int))*8)
|
|
|
|
#ifdef CONFIG_SERIAL_8250_SHARE_IRQ
|
|
#define SERIAL8250_SHARE_IRQS 1
|
|
#else
|
|
#define SERIAL8250_SHARE_IRQS 0
|
|
#endif
|
|
|
|
#if defined(__alpha__) && !defined(CONFIG_PCI)
|
|
/*
|
|
* Digital did something really horribly wrong with the OUT1 and OUT2
|
|
* lines on at least some ALPHA's. The failure mode is that if either
|
|
* is cleared, the machine locks up with endless interrupts.
|
|
*/
|
|
#define ALPHA_KLUDGE_MCR (UART_MCR_OUT2 | UART_MCR_OUT1)
|
|
#elif defined(CONFIG_SBC8560)
|
|
/*
|
|
* WindRiver did something similarly broken on their SBC8560 board. The
|
|
* UART tristates its IRQ output while OUT2 is clear, but they pulled
|
|
* the interrupt line _up_ instead of down, so if we register the IRQ
|
|
* while the UART is in that state, we die in an IRQ storm. */
|
|
#define ALPHA_KLUDGE_MCR (UART_MCR_OUT2)
|
|
#else
|
|
#define ALPHA_KLUDGE_MCR 0
|
|
#endif
|