linux-stable/drivers/video
Anirudh Rayabharam 02625c9652 video: hgafb: correctly handle card detect failure during probe
The return value of hga_card_detect() is not properly handled causing
the probe to succeed even though hga_card_detect() failed. Since probe
succeeds, hgafb_open() can be called which will end up operating on an
unmapped hga_vram. This results in an out-of-bounds access as reported
by kernel test robot [1].

To fix this, correctly detect failure of hga_card_detect() by checking
for a non-zero error code.

[1]: https://lore.kernel.org/lkml/20210516150019.GB25903@xsang-OptiPlex-9020/

Fixes: dc13cac486 ("video: hgafb: fix potential NULL pointer dereference")
Cc: stable <stable@vger.kernel.org>
Reported-by: kernel test robot <oliver.sang@intel.com>
Reviewed-by: Igor Matheus Andrade Torrente <igormtorrente@gmail.com>
Signed-off-by: Anirudh Rayabharam <mail@anirudhrb.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20210516192714.25823-1-mail@anirudhrb.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-05-21 15:04:05 +02:00
..
backlight backlight: journada720: Fix Wmisleading-indentation warning 2021-03-23 09:42:55 +00:00
console Merge branch 'resizex' (patches from Maciej) 2021-05-13 11:12:51 -07:00
fbdev video: hgafb: correctly handle card detect failure during probe 2021-05-21 15:04:05 +02:00
logo .gitignore: add SPDX License Identifier 2020-03-25 11:50:48 +01:00
display_timing.c
hdmi.c video: fix some kernel-doc markups 2020-11-16 18:23:16 +01:00
Kconfig
Makefile
of_display_timing.c video: Fix kernel-doc warnings in of_display_timing + of_videomode 2020-11-29 22:42:17 +01:00
of_videomode.c video: Fix kernel-doc warnings in of_display_timing + of_videomode 2020-11-29 22:42:17 +01:00
vgastate.c
videomode.c