mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-29 22:02:02 +00:00
199da8714c
Nathan reported below building error: ===== $ curl -LSso .config https://git.alpinelinux.org/aports/plain/community/linux-edge/config-edge.armv7 $ make -skj"$(nproc)" ARCH=arm CROSS_COMPILE=arm-linux-gnueabi- olddefconfig all .. arm-linux-gnueabi-ld: arch/arm/kernel/machine_kexec.o: in function `arch_crash_save_vmcoreinfo': machine_kexec.c:(.text+0x488): undefined reference to `vmcoreinfo_append_str' ==== On architecutres, like arm, s390, ppc, sh, function arch_crash_save_vmcoreinfo() is located in machine_kexec.c and it can only be compiled in when CONFIG_KEXEC_CORE=y. That's not right because arch_crash_save_vmcoreinfo() is used to export arch specific vmcoreinfo. CONFIG_VMCORE_INFO is supposed to control its compiling in. However, CONFIG_VMVCORE_INFO could be independent of CONFIG_KEXEC_CORE, e.g CONFIG_PROC_KCORE=y will select CONFIG_VMVCORE_INFO. Or CONFIG_KEXEC/CONFIG_KEXEC_FILE is set while CONFIG_CRASH_DUMP is not set, it will report linking error. So, on arm, s390, ppc and sh, move arch_crash_save_vmcoreinfo out to a new file vmcore_info.c. Let CONFIG_VMCORE_INFO decide if compiling in arch_crash_save_vmcoreinfo(). [akpm@linux-foundation.org: remove stray newlines at eof] Link: https://lkml.kernel.org/r/20240129135033.157195-3-bhe@redhat.com Signed-off-by: Baoquan He <bhe@redhat.com> Reported-by: Nathan Chancellor <nathan@kernel.org> Closes: https://lore.kernel.org/all/20240126045551.GA126645@dev-arch.thelio-3990X/T/#u Cc: Al Viro <viro@zeniv.linux.org.uk> Cc: Eric W. Biederman <ebiederm@xmission.com> Cc: Hari Bathini <hbathini@linux.ibm.com> Cc: Klara Modin <klarasmodin@gmail.com> Cc: Michael Kelley <mhklinux@outlook.com> Cc: Pingfan Liu <piliu@redhat.com> Cc: Stephen Rothwell <sfr@canb.auug.org.au> Cc: Yang Li <yang.lee@linux.alibaba.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> |
||
|---|---|---|
| .. | ||
| cpu | ||
| syscalls | ||
| vsyscall | ||
| .gitignore | ||
| asm-offsets.c | ||
| crash_dump.c | ||
| debugtraps.S | ||
| disassemble.c | ||
| dma-coherent.c | ||
| dumpstack.c | ||
| dwarf.c | ||
| entry-common.S | ||
| ftrace.c | ||
| head_32.S | ||
| hw_breakpoint.c | ||
| idle.c | ||
| io.c | ||
| io_trapped.c | ||
| iomap.c | ||
| ioport.c | ||
| irq.c | ||
| irq_32.c | ||
| kdebugfs.c | ||
| kgdb.c | ||
| kprobes.c | ||
| machine_kexec.c | ||
| machvec.c | ||
| Makefile | ||
| module.c | ||
| nmi_debug.c | ||
| perf_callchain.c | ||
| perf_event.c | ||
| process.c | ||
| process_32.c | ||
| ptrace.c | ||
| ptrace_32.c | ||
| reboot.c | ||
| relocate_kernel.S | ||
| return_address.c | ||
| setup.c | ||
| sh_bios.c | ||
| sh_ksyms_32.c | ||
| signal_32.c | ||
| smp.c | ||
| stacktrace.c | ||
| swsusp.c | ||
| sys_sh.c | ||
| sys_sh32.c | ||
| syscalls_32.S | ||
| time.c | ||
| topology.c | ||
| traps.c | ||
| traps_32.c | ||
| unwinder.c | ||
| vmcore_info.c | ||
| vmlinux.lds.S | ||