linux-stable

Go to file

Thadeu Lima de Souza Cascardo cb6aedc1fd net: avoid double iput when sock_alloc_file fails commit `649c15c769` upstream. When sock_alloc_file fails to allocate a file, it will call sock_release. __sys_socket_file should then not call sock_release again, otherwise there will be a double free. [ 89.319884] ------------[ cut here ]------------ [ 89.320286] kernel BUG at fs/inode.c:1764! [ 89.320656] invalid opcode: 0000 [#1] PREEMPT SMP NOPTI [ 89.321051] CPU: 7 PID: 125 Comm: iou-sqp-124 Not tainted 6.2.0+ #361 [ 89.321535] RIP: 0010:iput+0x1ff/0x240 [ 89.321808] Code: d1 83 e1 03 48 83 f9 02 75 09 48 81 fa 00 10 00 00 77 05 83 e2 01 75 1f 4c 89 ef e8 fb d2 ba 00 e9 80 fe ff ff c3 cc cc cc cc <0f> 0b 0f 0b e9 d0 fe ff ff 0f 0b eb 8d 49 8d b4 24 08 01 00 00 48 [ 89.322760] RSP: 0018:ffffbdd60068bd50 EFLAGS: 00010202 [ 89.323036] RAX: 0000000000000000 RBX: ffff9d7ad3cacac0 RCX: 0000000000001107 [ 89.323412] RDX: 000000000003af00 RSI: 0000000000000000 RDI: ffff9d7ad3cacb40 [ 89.323785] RBP: ffffbdd60068bd68 R08: ffffffffffffffff R09: ffffffffab606438 [ 89.324157] R10: ffffffffacb3dfa0 R11: 6465686361657256 R12: ffff9d7ad3cacb40 [ 89.324529] R13: 0000000080000001 R14: 0000000080000001 R15: 0000000000000002 [ 89.324904] FS: 00007f7b28516740(0000) GS:ffff9d7aeb1c0000(0000) knlGS:0000000000000000 [ 89.325328] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 89.325629] CR2: 00007f0af52e96c0 CR3: 0000000002a02006 CR4: 0000000000770ee0 [ 89.326004] PKRU: 55555554 [ 89.326161] Call Trace: [ 89.326298] <TASK> [ 89.326419] __sock_release+0xb5/0xc0 [ 89.326632] __sys_socket_file+0xb2/0xd0 [ 89.326844] io_socket+0x88/0x100 [ 89.327039] ? io_issue_sqe+0x6a/0x430 [ 89.327258] io_issue_sqe+0x67/0x430 [ 89.327450] io_submit_sqes+0x1fe/0x670 [ 89.327661] io_sq_thread+0x2e6/0x530 [ 89.327859] ? __pfx_autoremove_wake_function+0x10/0x10 [ 89.328145] ? __pfx_io_sq_thread+0x10/0x10 [ 89.328367] ret_from_fork+0x29/0x50 [ 89.328576] RIP: 0033:0x0 [ 89.328732] Code: Unable to access opcode bytes at 0xffffffffffffffd6. [ 89.329073] RSP: 002b:0000000000000000 EFLAGS: 00000202 ORIG_RAX: 00000000000001a9 [ 89.329477] RAX: 0000000000000000 RBX: 0000000000000000 RCX: 00007f7b28637a3d [ 89.329845] RDX: 00007fff4e4318a8 RSI: 00007fff4e4318b0 RDI: 0000000000000400 [ 89.330216] RBP: 00007fff4e431830 R08: 00007fff4e431711 R09: 00007fff4e4318b0 [ 89.330584] R10: 0000000000000000 R11: 0000000000000202 R12: 00007fff4e441b38 [ 89.330950] R13: 0000563835e3e725 R14: 0000563835e40d10 R15: 00007f7b28784040 [ 89.331318] </TASK> [ 89.331441] Modules linked in: [ 89.331617] ---[ end trace 0000000000000000 ]--- Fixes: `da214a475f` ("net: add __sys_socket_file()") Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com> Reviewed-by: Jens Axboe <axboe@kernel.dk> Reviewed-by: Eric Dumazet <edumazet@google.com> Reviewed-by: Kuniyuki Iwashima <kuniyu@amazon.com> Link: https://lore.kernel.org/r/20230307173707.468744-1-cascardo@canonical.com Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2023-03-10 09:29:57 +01:00
Documentation	mm: memcontrol: deprecate charge moving	2023-03-10 09:29:49 +01:00
LICENSES	LICENSES: Add the copyleft-next-0.3.1 license	2022-11-08 15:44:01 +01:00
arch	MIPS: DTS: CI20: fix otg power gpio	2023-03-10 09:29:53 +01:00
block	block: be a bit more careful in checking for NULL bdev while polling	2023-03-10 09:29:22 +01:00
certs	certs: Fix build error when PKCS#11 URI contains semicolon	2023-01-31 17:53:01 +09:00
crypto	crypto: rsa-pkcs1pad - Use akcipher_request_complete	2023-03-10 09:28:18 +01:00
drivers	brd: use radix_tree_maybe_preload instead of radix_tree_preload	2023-03-10 09:29:57 +01:00
fs	ceph: update the time stamps and try to drop the suid/sgid	2023-03-10 09:29:47 +01:00
include	vfio/type1: exclude mdevs from VFIO_UPDATE_VADDR	2023-03-10 09:29:55 +01:00
init	Kbuild fixes for v6.2 (3rd)	2023-01-21 10:56:37 -08:00
io_uring	io_uring: mark task TASK_RUNNING before handling resume/task work	2023-03-10 09:29:28 +01:00
ipc	Non-MM patches for 6.2-rc1.	2022-12-12 17:28:58 -08:00
kernel	tracing/eprobe: Fix to add filter on eprobe description in README file	2023-03-10 09:29:50 +01:00
lib	cpuidle: lib/bug: Disable rcu_is_watching() during WARN/BUG	2023-03-10 09:29:06 +01:00
mm	memory tier: release the new_memtier in find_create_memory_tier()	2023-03-10 09:29:50 +01:00
net	net: avoid double iput when sock_alloc_file fails	2023-03-10 09:29:57 +01:00
rust	rust: print: avoid evaluating arguments in `pr_*` macros in `unsafe` blocks	2023-01-16 00:54:35 +01:00
samples	ftrace: Export ftrace_free_filter() to modules	2023-01-24 11:20:58 -05:00
scripts	gcc-plugins: drop -std=gnu++11 to fix GCC 13 build	2023-03-10 09:29:11 +01:00
security	ima: Align ima_file_mmap() parameters with mmap_file LSM hook	2023-03-10 09:29:36 +01:00
sound	ALSA: hda/realtek: Add quirk for HP EliteDesk 800 G6 Tower PC	2023-03-10 09:29:41 +01:00
tools	tools/bootconfig: fix single & used for logical condition	2023-03-10 09:29:50 +01:00
usr	usr/gen_init_cpio.c: remove unnecessary -1 values from int file	2022-10-03 14:21:44 -07:00
virt	KVM: Register /dev/kvm as the _very_ last thing during initialization	2023-03-10 09:29:33 +01:00
.clang-format	iommufd for 6.2	2022-12-14 09:15:43 -08:00
.cocciconfig	…
.get_maintainer.ignore	get_maintainer: add Alan to .get_maintainer.ignore	2022-08-20 15:17:44 -07:00
.gitattributes	.gitattributes: use 'dts' diff driver for dts files	2019-12-04 19:44:11 -08:00
.gitignore	.gitignore: ignore *.rpm	2022-12-30 17:22:14 +09:00
.mailmap	12 hotfixes, mostly against mm/. Five of these fixes are cc:stable.	2023-02-13 14:09:20 -08:00
.rustfmt.toml	rust: add `.rustfmt.toml`	2022-09-28 09:02:20 +02:00
COPYING	COPYING: state that all contributions really are covered by this file	2020-02-10 13:32:20 -08:00
CREDITS	MAINTAINERS: update SCTP maintainers	2023-02-02 11:35:33 -08:00
Kbuild	Kbuild updates for v6.1	2022-10-10 12:00:45 -07:00
Kconfig	kbuild: ensure full rebuild when the compiler is updated	2020-05-12 13:28:33 +09:00
MAINTAINERS	audit: update the mailing list in MAINTAINERS	2023-02-25 11:13:29 +01:00
Makefile	Linux 6.2.2	2023-03-03 11:56:18 +01:00
README	Drop all 00-INDEX files from Documentation/	2018-09-09 15:08:58 -06:00

README

Linux kernel
============

There are several guides for kernel developers and users. These guides can
be rendered in a number of formats, like HTML and PDF. Please read
Documentation/admin-guide/README.rst first.

In order to build the documentation, use ``make htmldocs`` or
``make pdfdocs``.  The formatted documentation can also be read online at:

    https://www.kernel.org/doc/html/latest/

There are various text files in the Documentation/ subdirectory,
several of them using the Restructured Text markup notation.

Please read the Documentation/process/changes.rst file, as it contains the
requirements for building and running the kernel, and information about
the problems which may result by upgrading your kernel.