mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-11-01 08:58:07 +00:00
cb77cb5abe
blk_keyslot_manager is misnamed because it doesn't necessarily manage
keyslots. It actually does several different things:
- Contains the crypto capabilities of the device.
- Provides functions to control the inline encryption hardware.
Originally these were just for programming/evicting keyslots;
however, new functionality (hardware-wrapped keys) will require new
functions here which are unrelated to keyslots. Moreover,
device-mapper devices already (ab)use "keyslot_evict" to pass key
eviction requests to their underlying devices even though
device-mapper devices don't have any keyslots themselves (so it
really should be "evict_key", not "keyslot_evict").
- Sometimes (but not always!) it manages keyslots. Originally it
always did, but device-mapper devices don't have keyslots
themselves, so they use a "passthrough keyslot manager" which
doesn't actually manage keyslots. This hack works, but the
terminology is unnatural. Also, some hardware doesn't have keyslots
and thus also uses a "passthrough keyslot manager" (support for such
hardware is yet to be upstreamed, but it will happen eventually).
Let's stop having keyslot managers which don't actually manage keyslots.
Instead, rename blk_keyslot_manager to blk_crypto_profile.
This is a fairly big change, since for consistency it also has to update
keyslot manager-related function names, variable names, and comments --
not just the actual struct name. However it's still a fairly
straightforward change, as it doesn't change any actual functionality.
Acked-by: Ulf Hansson <ulf.hansson@linaro.org> # For MMC
Reviewed-by: Mike Snitzer <snitzer@redhat.com>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Eric Biggers <ebiggers@google.com>
Link: https://lore.kernel.org/r/20211018180453.40441-4-ebiggers@kernel.org
Signed-off-by: Jens Axboe <axboe@kernel.dk>
|
||
|---|---|---|
| .. | ||
| cdns-pltfrm.c | ||
| Kconfig | ||
| Makefile | ||
| tc-dwc-g210-pci.c | ||
| tc-dwc-g210-pltfrm.c | ||
| tc-dwc-g210.c | ||
| tc-dwc-g210.h | ||
| ti-j721e-ufs.c | ||
| ufs-debugfs.c | ||
| ufs-debugfs.h | ||
| ufs-exynos.c | ||
| ufs-exynos.h | ||
| ufs-fault-injection.c | ||
| ufs-fault-injection.h | ||
| ufs-hisi.c | ||
| ufs-hisi.h | ||
| ufs-mediatek-trace.h | ||
| ufs-mediatek.c | ||
| ufs-mediatek.h | ||
| ufs-qcom-ice.c | ||
| ufs-qcom.c | ||
| ufs-qcom.h | ||
| ufs-sysfs.c | ||
| ufs-sysfs.h | ||
| ufs.h | ||
| ufs_bsg.c | ||
| ufs_bsg.h | ||
| ufs_quirks.h | ||
| ufshcd-crypto.c | ||
| ufshcd-crypto.h | ||
| ufshcd-dwc.c | ||
| ufshcd-dwc.h | ||
| ufshcd-pci.c | ||
| ufshcd-pltfrm.c | ||
| ufshcd-pltfrm.h | ||
| ufshcd.c | ||
| ufshcd.h | ||
| ufshci-dwc.h | ||
| ufshci.h | ||
| ufshpb.c | ||
| ufshpb.h | ||
| unipro.h | ||