mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-21 08:19:28 +00:00
![Linus Torvalds](/assets/img/avatar_default.png)
The poll() changes were not well thought out, and completely unexplained. They also caused a huge performance regression, because "->poll()" was no longer a trivial file operation that just called down to the underlying file operations, but instead did at least two indirect calls. Indirect calls are sadly slow now with the Spectre mitigation, but the performance problem could at least be largely mitigated by changing the "->get_poll_head()" operation to just have a per-file-descriptor pointer to the poll head instead. That gets rid of one of the new indirections. But that doesn't fix the new complexity that is completely unwarranted for the regular case. The (undocumented) reason for the poll() changes was some alleged AIO poll race fixing, but we don't make the common case slower and more complex for some uncommon special case, so this all really needs way more explanations and most likely a fundamental redesign. [ This revert is a revert of about 30 different commits, not reverted individually because that would just be unnecessarily messy - Linus ] Cc: Al Viro <viro@zeniv.linux.org.uk> Cc: Christoph Hellwig <hch@lst.de> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
56 lines
1.6 KiB
C
56 lines
1.6 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
/* net/atm/common.h - ATM sockets (common part for PVC and SVC) */
|
|
|
|
/* Written 1995-2000 by Werner Almesberger, EPFL LRC/ICA */
|
|
|
|
|
|
#ifndef NET_ATM_COMMON_H
|
|
#define NET_ATM_COMMON_H
|
|
|
|
#include <linux/net.h>
|
|
#include <linux/poll.h> /* for poll_table */
|
|
|
|
|
|
int vcc_create(struct net *net, struct socket *sock, int protocol, int family, int kern);
|
|
int vcc_release(struct socket *sock);
|
|
int vcc_connect(struct socket *sock, int itf, short vpi, int vci);
|
|
int vcc_recvmsg(struct socket *sock, struct msghdr *msg, size_t size,
|
|
int flags);
|
|
int vcc_sendmsg(struct socket *sock, struct msghdr *m, size_t total_len);
|
|
__poll_t vcc_poll(struct file *file, struct socket *sock, poll_table *wait);
|
|
int vcc_ioctl(struct socket *sock, unsigned int cmd, unsigned long arg);
|
|
int vcc_compat_ioctl(struct socket *sock, unsigned int cmd, unsigned long arg);
|
|
int vcc_setsockopt(struct socket *sock, int level, int optname,
|
|
char __user *optval, unsigned int optlen);
|
|
int vcc_getsockopt(struct socket *sock, int level, int optname,
|
|
char __user *optval, int __user *optlen);
|
|
void vcc_process_recv_queue(struct atm_vcc *vcc);
|
|
|
|
int atmpvc_init(void);
|
|
void atmpvc_exit(void);
|
|
int atmsvc_init(void);
|
|
void atmsvc_exit(void);
|
|
int atm_sysfs_init(void);
|
|
void atm_sysfs_exit(void);
|
|
|
|
#ifdef CONFIG_PROC_FS
|
|
int atm_proc_init(void);
|
|
void atm_proc_exit(void);
|
|
#else
|
|
static inline int atm_proc_init(void)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
static inline void atm_proc_exit(void)
|
|
{
|
|
/* nothing */
|
|
}
|
|
#endif /* CONFIG_PROC_FS */
|
|
|
|
/* SVC */
|
|
int svc_change_qos(struct atm_vcc *vcc,struct atm_qos *qos);
|
|
|
|
void atm_dev_release_vccs(struct atm_dev *dev);
|
|
|
|
#endif
|