mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-21 16:29:59 +00:00
![Dan Williams](/assets/img/avatar_default.png)
In preparation for the dax implementation to start associating dax pages to inodes via page->mapping, we need to provide a 'struct address_space_operations' instance for dax. Otherwise, direct-I/O triggers incorrect page cache assumptions and warnings like the following: WARNING: CPU: 27 PID: 1783 at fs/xfs/xfs_aops.c:1468 xfs_vm_set_page_dirty+0xf3/0x1b0 [xfs] [..] CPU: 27 PID: 1783 Comm: dma-collision Tainted: G O 4.15.0-rc2+ #984 [..] Call Trace: set_page_dirty_lock+0x40/0x60 bio_set_pages_dirty+0x37/0x50 iomap_dio_actor+0x2b7/0x3b0 ? iomap_dio_zero+0x110/0x110 iomap_apply+0xa4/0x110 iomap_dio_rw+0x29e/0x3b0 ? iomap_dio_zero+0x110/0x110 ? xfs_file_dio_aio_read+0x7c/0x1a0 [xfs] xfs_file_dio_aio_read+0x7c/0x1a0 [xfs] xfs_file_read_iter+0xa0/0xc0 [xfs] __vfs_read+0xf9/0x170 vfs_read+0xa6/0x150 SyS_pread64+0x93/0xb0 entry_SYSCALL_64_fastpath+0x1f/0x96 ...where the default set_page_dirty() handler assumes that dirty state is being tracked in 'struct page' flags. Cc: Jeff Moyer <jmoyer@redhat.com> Cc: Matthew Wilcox <mawilcox@microsoft.com> Cc: Ross Zwisler <ross.zwisler@linux.intel.com> Suggested-by: Jan Kara <jack@suse.cz> Suggested-by: Dave Chinner <david@fromorbit.com> Reviewed-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Jan Kara <jack@suse.cz> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
65 lines
2.3 KiB
C
65 lines
2.3 KiB
C
/*
|
|
* Copyright (c) 2005-2006 Silicon Graphics, Inc.
|
|
* All Rights Reserved.
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public License as
|
|
* published by the Free Software Foundation.
|
|
*
|
|
* This program is distributed in the hope that it would be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, write the Free Software Foundation,
|
|
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
|
|
*/
|
|
#ifndef __XFS_AOPS_H__
|
|
#define __XFS_AOPS_H__
|
|
|
|
extern struct bio_set *xfs_ioend_bioset;
|
|
|
|
/*
|
|
* Types of I/O for bmap clustering and I/O completion tracking.
|
|
*/
|
|
enum {
|
|
XFS_IO_INVALID, /* initial state */
|
|
XFS_IO_DELALLOC, /* covers delalloc region */
|
|
XFS_IO_UNWRITTEN, /* covers allocated but uninitialized data */
|
|
XFS_IO_OVERWRITE, /* covers already allocated extent */
|
|
XFS_IO_COW, /* covers copy-on-write extent */
|
|
};
|
|
|
|
#define XFS_IO_TYPES \
|
|
{ XFS_IO_INVALID, "invalid" }, \
|
|
{ XFS_IO_DELALLOC, "delalloc" }, \
|
|
{ XFS_IO_UNWRITTEN, "unwritten" }, \
|
|
{ XFS_IO_OVERWRITE, "overwrite" }, \
|
|
{ XFS_IO_COW, "CoW" }
|
|
|
|
/*
|
|
* Structure for buffered I/O completions.
|
|
*/
|
|
struct xfs_ioend {
|
|
struct list_head io_list; /* next ioend in chain */
|
|
unsigned int io_type; /* delalloc / unwritten */
|
|
struct inode *io_inode; /* file being written to */
|
|
size_t io_size; /* size of the extent */
|
|
xfs_off_t io_offset; /* offset in the file */
|
|
struct work_struct io_work; /* xfsdatad work queue */
|
|
struct xfs_trans *io_append_trans;/* xact. for size update */
|
|
struct bio *io_bio; /* bio being built */
|
|
struct bio io_inline_bio; /* MUST BE LAST! */
|
|
};
|
|
|
|
extern const struct address_space_operations xfs_address_space_operations;
|
|
extern const struct address_space_operations xfs_dax_aops;
|
|
|
|
int xfs_setfilesize(struct xfs_inode *ip, xfs_off_t offset, size_t size);
|
|
|
|
extern void xfs_count_page_state(struct page *, int *, int *);
|
|
extern struct block_device *xfs_find_bdev_for_inode(struct inode *);
|
|
extern struct dax_device *xfs_find_daxdev_for_inode(struct inode *);
|
|
|
|
#endif /* __XFS_AOPS_H__ */
|