linux-stable/drivers/block/drbd
Christoph Böhmwalder acffdf1a7f drbd: correctly submit flush bio on barrier
commit 3899d94e38 upstream.

When we receive a flush command (or "barrier" in DRBD), we currently use
a REQ_OP_FLUSH with the REQ_PREFLUSH flag set.

The correct way to submit a flush bio is by using a REQ_OP_WRITE without
any data, and set the REQ_PREFLUSH flag.

Since commit b4a6bb3a67 ("block: add a sanity check for non-write
flush/fua bios"), this triggers a warning in the block layer, but this
has been broken for quite some time before that.

So use the correct set of flags to actually make the flush happen.

Cc: Christoph Hellwig <hch@infradead.org>
Cc: stable@vger.kernel.org
Fixes: f9ff0da564 ("drbd: allow parallel flushes for multi-volume resources")
Reported-by: Thomas Voegtle <tv@lio96.de>
Signed-off-by: Christoph Böhmwalder <christoph.boehmwalder@linbit.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/20230503121937.17232-1-christoph.boehmwalder@linbit.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2023-05-11 23:03:39 +09:00
..
Kconfig Replace HTTP links with HTTPS ones: DRBD driver 2020-07-05 14:16:44 -06:00
Makefile
drbd_actlog.c block/drbd: Use the enum req_op and blk_opf_t types 2022-07-14 12:14:31 -06:00
drbd_bitmap.c drbd: bm_page_async_io: fix spurious bitmap "IO error" on large volumes 2022-08-02 17:14:31 -06:00
drbd_debugfs.c block: drbd: no need to check return value of debugfs_create functions 2019-06-20 03:28:16 -06:00
drbd_debugfs.h block: drbd: no need to check return value of debugfs_create functions 2019-06-20 03:28:16 -06:00
drbd_int.h block/drbd: remove unused w_start_resync declaration 2022-09-12 01:47:57 -06:00
drbd_interval.c block: drbd: drbd_interval: Demote some kernel-doc abuses and fix another header 2021-04-06 09:21:53 -06:00
drbd_interval.h
drbd_main.c use less confusing names for iov_iter direction initializers 2023-02-09 11:28:04 +01:00
drbd_nl.c drbd: use blk_queue_max_discard_sectors helper 2022-12-31 13:32:10 +01:00
drbd_nla.c
drbd_nla.h
drbd_proc.c drbd: remove a bogus bdi_rw_congested call 2020-07-08 17:05:53 -06:00
drbd_protocol.h drbd: Use struct_group() to zero algs 2021-12-13 16:31:24 -07:00
drbd_receiver.c drbd: correctly submit flush bio on barrier 2023-05-11 23:03:39 +09:00
drbd_req.c block: handle bio_split_to_limits() NULL return 2023-01-18 11:58:33 +01:00
drbd_req.h drbd: remove orphan _req_may_be_done() declaration 2022-09-21 19:44:05 -06:00
drbd_state.c drdb: Switch to kvfree_rcu() API 2022-04-17 19:54:24 -06:00
drbd_state.h
drbd_state_change.h drbd: Fix five use after free bugs in get_initial_state 2022-04-06 13:07:50 -06:00
drbd_strings.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 91 2019-05-24 17:37:53 +02:00
drbd_strings.h
drbd_vli.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 91 2019-05-24 17:37:53 +02:00
drbd_worker.c block/drbd: Combine two drbd_submit_peer_request() arguments 2022-07-14 12:14:31 -06:00