Duoming Zhou 9a995e11b2 dmaengine: mediatek: Fix deadlock caused by synchronize_irq() ... [ Upstream commit 01f1ae2733 ] The synchronize_irq(c->irq) will not return until the IRQ handler mtk_uart_apdma_irq_handler() is completed. If the synchronize_irq() holds a spin_lock and waits the IRQ handler to complete, but the IRQ handler also needs the same spin_lock. The deadlock will happen. The process is shown below: cpu0 cpu1 mtk_uart_apdma_device_pause() | mtk_uart_apdma_irq_handler() spin_lock_irqsave() | | spin_lock_irqsave() //hold the lock to wait | synchronize_irq() | This patch reorders the synchronize_irq(c->irq) outside the spin_lock in order to mitigate the bug. Fixes: 9135408c3a ("dmaengine: mediatek: Add MediaTek UART APDMA support") Signed-off-by: Duoming Zhou <duoming@zju.edu.cn> Reviewed-by: Eugen Hristev <eugen.hristev@collabora.com> Link: https://lore.kernel.org/r/20230806032511.45263-1-duoming@zju.edu.cn Signed-off-by: Vinod Koul <vkoul@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2023-10-19 23:08:58 +02:00
..
Kconfig	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
Makefile	…
mtk-cqdma.c	dmaengine: mediatek-cqdma: fix typo in comment	2022-07-06 10:50:43 +05:30
mtk-hsdma.c	dmaengine: mediatek: mtk-hsdma: Fix typo 'the the' in comment	2022-07-26 22:06:05 +05:30
mtk-uart-apdma.c	dmaengine: mediatek: Fix deadlock caused by synchronize_irq()	2023-10-19 23:08:58 +02:00