Nicolin Chen d7f62fde41 iommu/dma: Force swiotlb_max_mapping_size on an untrusted device ... [ Upstream commit afc5aa46ed ] The swiotlb does not support a mapping size > swiotlb_max_mapping_size(). On the other hand, with a 64KB PAGE_SIZE configuration, it's observed that an NVME device can map a size between 300KB~512KB, which certainly failed the swiotlb mappings, though the default pool of swiotlb has many slots: systemd[1]: Started Journal Service. => nvme 0000:00:01.0: swiotlb buffer is full (sz: 327680 bytes), total 32768 (slots), used 32 (slots) note: journal-offline[392] exited with irqs disabled note: journal-offline[392] exited with preempt_count 1 Call trace: [ 3.099918] swiotlb_tbl_map_single+0x214/0x240 [ 3.099921] iommu_dma_map_page+0x218/0x328 [ 3.099928] dma_map_page_attrs+0x2e8/0x3a0 [ 3.101985] nvme_prep_rq.part.0+0x408/0x878 [nvme] [ 3.102308] nvme_queue_rqs+0xc0/0x300 [nvme] [ 3.102313] blk_mq_flush_plug_list.part.0+0x57c/0x600 [ 3.102321] blk_add_rq_to_plug+0x180/0x2a0 [ 3.102323] blk_mq_submit_bio+0x4c8/0x6b8 [ 3.103463] __submit_bio+0x44/0x220 [ 3.103468] submit_bio_noacct_nocheck+0x2b8/0x360 [ 3.103470] submit_bio_noacct+0x180/0x6c8 [ 3.103471] submit_bio+0x34/0x130 [ 3.103473] ext4_bio_write_folio+0x5a4/0x8c8 [ 3.104766] mpage_submit_folio+0xa0/0x100 [ 3.104769] mpage_map_and_submit_buffers+0x1a4/0x400 [ 3.104771] ext4_do_writepages+0x6a0/0xd78 [ 3.105615] ext4_writepages+0x80/0x118 [ 3.105616] do_writepages+0x90/0x1e8 [ 3.105619] filemap_fdatawrite_wbc+0x94/0xe0 [ 3.105622] __filemap_fdatawrite_range+0x68/0xb8 [ 3.106656] file_write_and_wait_range+0x84/0x120 [ 3.106658] ext4_sync_file+0x7c/0x4c0 [ 3.106660] vfs_fsync_range+0x3c/0xa8 [ 3.106663] do_fsync+0x44/0xc0 Since untrusted devices might go down the swiotlb pathway with dma-iommu, these devices should not map a size larger than swiotlb_max_mapping_size. To fix this bug, add iommu_dma_max_mapping_size() for untrusted devices to take into account swiotlb_max_mapping_size() v.s. iova_rcache_range() from the iommu_dma_opt_mapping_size(). Fixes: 82612d66d5 ("iommu: Allow the dma-iommu api to use bounce buffers") Link: https://lore.kernel.org/r/ee51a3a5c32cf885b18f6416171802669f4a718a.1707851466.git.nicolinc@nvidia.com Signed-off-by: Nicolin Chen <nicolinc@nvidia.com> [will: Drop redundant is_swiotlb_active(dev) check] Signed-off-by: Will Deacon <will@kernel.org> Reviewed-by: Michael Kelley <mhklinux@outlook.com> Acked-by: Robin Murphy <robin.murphy@arm.com> Tested-by: Nicolin Chen <nicolinc@nvidia.com> Tested-by: Michael Kelley <mhklinux@outlook.com> Signed-off-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Sasha Levin <sashal@kernel.org>		2024-04-03 15:19:44 +02:00
..
amd	iommu/amd: Mark interrupt as managed	2024-03-26 18:20:36 -04:00
arm	iommu/arm-smmu-qcom: Limit the SMR groups to 128	2024-03-06 14:45:06 +00:00
intel	iommu: Fix compilation without CONFIG_IOMMU_INTEL	2024-03-26 18:20:41 -04:00
Kconfig	iommu: Fix compilation without CONFIG_IOMMU_INTEL	2024-03-26 18:20:41 -04:00
Makefile	…
apple-dart.c	iommu/dart: Fix apple_dart_device_group for PCI groups	2023-03-10 09:33:36 +01:00
dma-iommu.c	iommu/dma: Force swiotlb_max_mapping_size on an untrusted device	2024-04-03 15:19:44 +02:00
dma-iommu.h	…
exynos-iommu.c	…
fsl_pamu.c	…
fsl_pamu.h	…
fsl_pamu_domain.c	…
fsl_pamu_domain.h	…
hyperv-iommu.c	…
io-pgfault.c	mm: always expand the stack with the mmap write lock held	2023-07-01 13:16:25 +02:00
io-pgtable-arm-v7s.c	…
io-pgtable-arm.c	…
io-pgtable-arm.h	…
io-pgtable-dart.c	…
io-pgtable.c	…
ioasid.c	…
iommu-debugfs.c	…
iommu-sva-lib.c	…
iommu-sva-lib.h	…
iommu-sysfs.c	…
iommu-traces.c	…
iommu.c	iommu: Avoid races around default domain allocations	2024-04-03 15:19:43 +02:00
iova.c	iommu/iova: Fix alloc iova overflows issue	2023-01-18 11:58:20 +01:00
ipmmu-vmsa.c	…
irq_remapping.c	iommu: Fix compilation without CONFIG_IOMMU_INTEL	2024-03-26 18:20:41 -04:00
irq_remapping.h	…
msm_iommu.c	…
msm_iommu.h	…
msm_iommu_hw-8xxx.h	…
mtk_iommu.c	iommu/mediatek: Fix share pgtable for iova over 4GB	2023-10-10 22:00:41 +02:00
mtk_iommu_v1.c	iommu/mediatek-v1: Fix an error handling path in mtk_iommu_v1_probe()	2023-01-18 11:58:21 +01:00
of_iommu.c	iommu: Avoid more races around device probe	2023-12-13 18:39:17 +01:00
omap-iommu-debug.c	…
omap-iommu.c	…
omap-iommu.h	…
omap-iopgtable.h	…
rockchip-iommu.c	iommu: rockchip: Fix directory table address encoding	2023-09-13 09:42:50 +02:00
s390-iommu.c	…
sprd-iommu.c	iommu/sprd: Release dma buffer to avoid memory leak	2024-03-06 14:45:05 +00:00
sun50i-iommu.c	…
tegra-gart.c	…
tegra-smmu.c	…
virtio-iommu.c	iommu/virtio: Return size mapped for a detached domain	2023-07-19 16:21:20 +02:00