Arnd Bergmann 322eb43c0e scsi: bfa: Fix function pointer type mismatch for hcb_qe->cbfn ... [ Upstream commit b69600231f ] Some callback functions used here take a boolean argument, others take a status argument. This breaks KCFI type checking, so clang now warns about the function pointer cast: drivers/scsi/bfa/bfad_bsg.c:2138:29: error: cast from 'void (*)(void *, enum bfa_status)' to 'bfa_cb_cbfn_t' (aka 'void (*)(void *, enum bfa_boolean)') converts to incompatible function type [-Werror,-Wcast-function-type-strict] Assuming the code is actually correct here and the callers always match the argument types of the callee, rework this to replace the explicit cast with a union of the two pointer types. This does not change the behavior of the code, so if something is actually broken here, a larger rework may be necessary. Fixes: 37ea0558b8 ("[SCSI] bfa: Added support to collect and reset fcport stats") Fixes: 3ec4f2c8bf ("[SCSI] bfa: Added support to configure QOS and collect stats.") Reviewed-by: Kees Cook <keescook@chromium.org> Signed-off-by: Arnd Bergmann <arnd@arndb.de> Link: https://lore.kernel.org/r/20240222124433.2046570-1-arnd@kernel.org Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> Signed-off-by: Sasha Levin <sashal@kernel.org>		2024-03-26 18:20:55 -04:00
..
bfa.h
bfa_core.c
bfa_cs.h
bfa_defs.h
bfa_defs_fcs.h
bfa_defs_svc.h
bfa_fc.h
bfa_fcbuild.c
bfa_fcbuild.h
bfa_fcpim.c
bfa_fcpim.h
bfa_fcs.c
bfa_fcs.h
bfa_fcs_fcpim.c
bfa_fcs_lport.c
bfa_fcs_rport.c
bfa_hw_cb.c
bfa_hw_ct.c
bfa_ioc.c
bfa_ioc.h
bfa_ioc_cb.c
bfa_ioc_ct.c
bfa_modules.h
bfa_plog.h
bfa_port.c
bfa_port.h
bfa_svc.c
bfa_svc.h
bfad.c
bfad_attr.c
bfad_bsg.c
bfad_bsg.h
bfad_debugfs.c
bfad_drv.h
bfad_im.c
bfad_im.h
bfi.h
bfi_ms.h
bfi_reg.h
Makefile