Zhihao Cheng 3e5ea6b6a5 jbd2: Fix wrongly judgement for buffer head removing while doing checkpoint ... [ Upstream commit e34c8dd238 ] Following process, jbd2_journal_commit_transaction // there are several dirty buffer heads in transaction->t_checkpoint_list P1 wb_workfn jbd2_log_do_checkpoint if (buffer_locked(bh)) // false __block_write_full_page trylock_buffer(bh) test_clear_buffer_dirty(bh) if (!buffer_dirty(bh)) __jbd2_journal_remove_checkpoint(jh) if (buffer_write_io_error(bh)) // false >> bh IO error occurs << jbd2_cleanup_journal_tail __jbd2_update_log_tail jbd2_write_superblock // The bh won't be replayed in next mount. , which could corrupt the ext4 image, fetch a reproducer in [Link]. Since writeback process clears buffer dirty after locking buffer head, we can fix it by try locking buffer and check dirtiness while buffer is locked, the buffer head can be removed if it is neither dirty nor locked. Link: https://bugzilla.kernel.org/show_bug.cgi?id=217490 Fixes: 470decc613 ("[PATCH] jbd2: initial copy of files from jbd") Signed-off-by: Zhihao Cheng <chengzhihao1@huawei.com> Signed-off-by: Zhang Yi <yi.zhang@huawei.com> Reviewed-by: Jan Kara <jack@suse.cz> Link: https://lore.kernel.org/r/20230606135928.434610-5-yi.zhang@huaweicloud.com Signed-off-by: Theodore Ts'o <tytso@mit.edu> Signed-off-by: Sasha Levin <sashal@kernel.org>		2023-08-03 10:25:41 +02:00
..
Kconfig	treewide: Add SPDX license identifier - Makefile/Kconfig	2019-05-21 10:50:46 +02:00
Makefile	treewide: Add SPDX license identifier - Makefile/Kconfig	2019-05-21 10:50:46 +02:00
checkpoint.c	jbd2: Fix wrongly judgement for buffer head removing while doing checkpoint	2023-08-03 10:25:41 +02:00
commit.c	jbd2,ocfs2: move jbd2_journal_submit_inode_data_buffers to ocfs2	2023-01-18 17:12:51 -08:00
journal.c	Bug fixes and regressions for ext4, the most serious of which is a	2023-03-12 08:55:55 -07:00
recovery.c	- Yu Zhao's Multi-Gen LRU patches are here. They've been under test in	2022-10-10 17:53:04 -07:00
revoke.c	jbd2: rename jbd_debug() to jbd2_debug()	2022-08-02 23:52:19 -04:00
transaction.c	jdb2: Don't refuse invalidation of already invalidated buffers	2023-04-14 19:38:50 -04:00