mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-23 09:19:51 +00:00
![Ryusuke Konishi](/assets/img/avatar_default.png)
During disk space reclamation, nilfs2 still emits the following lockdep warning due to page/folio operations on shadowed page caches that nilfs2 uses to get a snapshot of DAT file in memory: WARNING: CPU: 0 PID: 2643 at include/linux/backing-dev.h:272 __folio_mark_dirty+0x645/0x670 ... RIP: 0010:__folio_mark_dirty+0x645/0x670 ... Call Trace: filemap_dirty_folio+0x74/0xd0 __set_page_dirty_nobuffers+0x85/0xb0 nilfs_copy_dirty_pages+0x288/0x510 [nilfs2] nilfs_mdt_save_to_shadow_map+0x50/0xe0 [nilfs2] nilfs_clean_segments+0xee/0x5d0 [nilfs2] nilfs_ioctl_clean_segments.isra.19+0xb08/0xf40 [nilfs2] nilfs_ioctl+0xc52/0xfb0 [nilfs2] __x64_sys_ioctl+0x11d/0x170 This fixes the remaining warning by using inode objects to hold those page caches. Link: https://lkml.kernel.org/r/1647867427-30498-3-git-send-email-konishi.ryusuke@gmail.com Signed-off-by: Ryusuke Konishi <konishi.ryusuke@gmail.com> Tested-by: Ryusuke Konishi <konishi.ryusuke@gmail.com> Cc: Matthew Wilcox <willy@infradead.org> Cc: David Hildenbrand <david@redhat.com> Cc: Hao Sun <sunhao.th@gmail.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
115 lines
3.6 KiB
C
115 lines
3.6 KiB
C
/* SPDX-License-Identifier: GPL-2.0+ */
|
|
/*
|
|
* NILFS meta data file prototype and definitions
|
|
*
|
|
* Copyright (C) 2005-2008 Nippon Telegraph and Telephone Corporation.
|
|
*
|
|
* Written by Ryusuke Konishi.
|
|
*/
|
|
|
|
#ifndef _NILFS_MDT_H
|
|
#define _NILFS_MDT_H
|
|
|
|
#include <linux/buffer_head.h>
|
|
#include <linux/blockgroup_lock.h>
|
|
#include "nilfs.h"
|
|
#include "page.h"
|
|
|
|
/**
|
|
* struct nilfs_shadow_map - shadow mapping of meta data file
|
|
* @bmap_store: shadow copy of bmap state
|
|
* @inode: holder of page caches used in shadow mapping
|
|
* @frozen_buffers: list of frozen buffers
|
|
*/
|
|
struct nilfs_shadow_map {
|
|
struct nilfs_bmap_store bmap_store;
|
|
struct inode *inode;
|
|
struct list_head frozen_buffers;
|
|
};
|
|
|
|
/**
|
|
* struct nilfs_mdt_info - on-memory private data of meta data files
|
|
* @mi_sem: reader/writer semaphore for meta data operations
|
|
* @mi_bgl: per-blockgroup locking
|
|
* @mi_entry_size: size of an entry
|
|
* @mi_first_entry_offset: offset to the first entry
|
|
* @mi_entries_per_block: number of entries in a block
|
|
* @mi_palloc_cache: persistent object allocator cache
|
|
* @mi_shadow: shadow of bmap and page caches
|
|
* @mi_blocks_per_group: number of blocks in a group
|
|
* @mi_blocks_per_desc_block: number of blocks per descriptor block
|
|
*/
|
|
struct nilfs_mdt_info {
|
|
struct rw_semaphore mi_sem;
|
|
struct blockgroup_lock *mi_bgl;
|
|
unsigned int mi_entry_size;
|
|
unsigned int mi_first_entry_offset;
|
|
unsigned long mi_entries_per_block;
|
|
struct nilfs_palloc_cache *mi_palloc_cache;
|
|
struct nilfs_shadow_map *mi_shadow;
|
|
unsigned long mi_blocks_per_group;
|
|
unsigned long mi_blocks_per_desc_block;
|
|
};
|
|
|
|
static inline struct nilfs_mdt_info *NILFS_MDT(const struct inode *inode)
|
|
{
|
|
return inode->i_private;
|
|
}
|
|
|
|
static inline int nilfs_is_metadata_file_inode(const struct inode *inode)
|
|
{
|
|
return inode->i_private != NULL;
|
|
}
|
|
|
|
/* Default GFP flags using highmem */
|
|
#define NILFS_MDT_GFP (__GFP_RECLAIM | __GFP_IO | __GFP_HIGHMEM)
|
|
|
|
int nilfs_mdt_get_block(struct inode *, unsigned long, int,
|
|
void (*init_block)(struct inode *,
|
|
struct buffer_head *, void *),
|
|
struct buffer_head **);
|
|
int nilfs_mdt_find_block(struct inode *inode, unsigned long start,
|
|
unsigned long end, unsigned long *blkoff,
|
|
struct buffer_head **out_bh);
|
|
int nilfs_mdt_delete_block(struct inode *, unsigned long);
|
|
int nilfs_mdt_forget_block(struct inode *, unsigned long);
|
|
int nilfs_mdt_fetch_dirty(struct inode *);
|
|
|
|
int nilfs_mdt_init(struct inode *inode, gfp_t gfp_mask, size_t objsz);
|
|
void nilfs_mdt_clear(struct inode *inode);
|
|
void nilfs_mdt_destroy(struct inode *inode);
|
|
|
|
void nilfs_mdt_set_entry_size(struct inode *, unsigned int, unsigned int);
|
|
|
|
int nilfs_mdt_setup_shadow_map(struct inode *inode,
|
|
struct nilfs_shadow_map *shadow);
|
|
int nilfs_mdt_save_to_shadow_map(struct inode *inode);
|
|
void nilfs_mdt_restore_from_shadow_map(struct inode *inode);
|
|
void nilfs_mdt_clear_shadow_map(struct inode *inode);
|
|
int nilfs_mdt_freeze_buffer(struct inode *inode, struct buffer_head *bh);
|
|
struct buffer_head *nilfs_mdt_get_frozen_buffer(struct inode *inode,
|
|
struct buffer_head *bh);
|
|
|
|
static inline void nilfs_mdt_mark_dirty(struct inode *inode)
|
|
{
|
|
if (!test_bit(NILFS_I_DIRTY, &NILFS_I(inode)->i_state))
|
|
set_bit(NILFS_I_DIRTY, &NILFS_I(inode)->i_state);
|
|
}
|
|
|
|
static inline void nilfs_mdt_clear_dirty(struct inode *inode)
|
|
{
|
|
clear_bit(NILFS_I_DIRTY, &NILFS_I(inode)->i_state);
|
|
}
|
|
|
|
static inline __u64 nilfs_mdt_cno(struct inode *inode)
|
|
{
|
|
return ((struct the_nilfs *)inode->i_sb->s_fs_info)->ns_cno;
|
|
}
|
|
|
|
static inline spinlock_t *
|
|
nilfs_mdt_bgl_lock(struct inode *inode, unsigned int block_group)
|
|
{
|
|
return bgl_lock_ptr(NILFS_MDT(inode)->mi_bgl, block_group);
|
|
}
|
|
|
|
#endif /* _NILFS_MDT_H */
|