mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-23 17:30:02 +00:00
![Christian Brauner](/assets/img/avatar_default.png)
Convert to struct mnt_idmap.
Last cycle we merged the necessary infrastructure in
256c8aed2b
("fs: introduce dedicated idmap type for mounts").
This is just the conversion to struct mnt_idmap.
Currently we still pass around the plain namespace that was attached to a
mount. This is in general pretty convenient but it makes it easy to
conflate namespaces that are relevant on the filesystem with namespaces
that are relevent on the mount level. Especially for non-vfs developers
without detailed knowledge in this area this can be a potential source for
bugs.
Once the conversion to struct mnt_idmap is done all helpers down to the
really low-level helpers will take a struct mnt_idmap argument instead of
two namespace arguments. This way it becomes impossible to conflate the two
eliminating the possibility of any bugs. All of the vfs and all filesystems
only operate on struct mnt_idmap.
Acked-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Christian Brauner (Microsoft) <brauner@kernel.org>
78 lines
1.9 KiB
C
78 lines
1.9 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
#include <linux/init.h>
|
|
#include <linux/posix_acl.h>
|
|
|
|
#define REISERFS_ACL_VERSION 0x0001
|
|
|
|
typedef struct {
|
|
__le16 e_tag;
|
|
__le16 e_perm;
|
|
__le32 e_id;
|
|
} reiserfs_acl_entry;
|
|
|
|
typedef struct {
|
|
__le16 e_tag;
|
|
__le16 e_perm;
|
|
} reiserfs_acl_entry_short;
|
|
|
|
typedef struct {
|
|
__le32 a_version;
|
|
} reiserfs_acl_header;
|
|
|
|
static inline size_t reiserfs_acl_size(int count)
|
|
{
|
|
if (count <= 4) {
|
|
return sizeof(reiserfs_acl_header) +
|
|
count * sizeof(reiserfs_acl_entry_short);
|
|
} else {
|
|
return sizeof(reiserfs_acl_header) +
|
|
4 * sizeof(reiserfs_acl_entry_short) +
|
|
(count - 4) * sizeof(reiserfs_acl_entry);
|
|
}
|
|
}
|
|
|
|
static inline int reiserfs_acl_count(size_t size)
|
|
{
|
|
ssize_t s;
|
|
size -= sizeof(reiserfs_acl_header);
|
|
s = size - 4 * sizeof(reiserfs_acl_entry_short);
|
|
if (s < 0) {
|
|
if (size % sizeof(reiserfs_acl_entry_short))
|
|
return -1;
|
|
return size / sizeof(reiserfs_acl_entry_short);
|
|
} else {
|
|
if (s % sizeof(reiserfs_acl_entry))
|
|
return -1;
|
|
return s / sizeof(reiserfs_acl_entry) + 4;
|
|
}
|
|
}
|
|
|
|
#ifdef CONFIG_REISERFS_FS_POSIX_ACL
|
|
struct posix_acl *reiserfs_get_acl(struct inode *inode, int type, bool rcu);
|
|
int reiserfs_set_acl(struct mnt_idmap *idmap, struct dentry *dentry,
|
|
struct posix_acl *acl, int type);
|
|
int reiserfs_acl_chmod(struct dentry *dentry);
|
|
int reiserfs_inherit_default_acl(struct reiserfs_transaction_handle *th,
|
|
struct inode *dir, struct dentry *dentry,
|
|
struct inode *inode);
|
|
int reiserfs_cache_default_acl(struct inode *dir);
|
|
|
|
#else
|
|
|
|
#define reiserfs_cache_default_acl(inode) 0
|
|
#define reiserfs_get_acl NULL
|
|
#define reiserfs_set_acl NULL
|
|
|
|
static inline int reiserfs_acl_chmod(struct dentry *dentry)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
static inline int
|
|
reiserfs_inherit_default_acl(struct reiserfs_transaction_handle *th,
|
|
const struct inode *dir, struct dentry *dentry,
|
|
struct inode *inode)
|
|
{
|
|
return 0;
|
|
}
|
|
#endif
|