mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-23 09:19:51 +00:00
![David Hildenbrand](/assets/img/avatar_default.png)
Patch series "mm/nommu: don't use VM_MAYSHARE for MAP_PRIVATE mappings". Trying to reduce the confusion around VM_SHARED and VM_MAYSHARE first requires !CONFIG_MMU to stop using VM_MAYSHARE for MAP_PRIVATE mappings. CONFIG_MMU only sets VM_MAYSHARE for MAP_SHARED mappings. This paves the way for further VM_MAYSHARE and VM_SHARED cleanups: for example, renaming VM_MAYSHARED to VM_MAP_SHARED to make it cleaner what is actually means. Let's first get the weird case out of the way and not use VM_MAYSHARE in MAP_PRIVATE mappings, using a new VM_MAYOVERLAY flag instead. This patch (of 3): We want to stop using VM_MAYSHARE in private mappings to pave the way for clarifying the semantics of VM_MAYSHARE vs. VM_SHARED and reduce the confusion. While CONFIG_MMU uses VM_MAYSHARE to represent MAP_SHARED, !CONFIG_MMU also sets VM_MAYSHARE for selected R/O private file mappings that are an effective overlay of a file mapping. Let's factor out all relevant VM_MAYSHARE checks in !CONFIG_MMU code into is_nommu_shared_mapping() first. Note that whenever VM_SHARED is set, VM_MAYSHARE must be set as well (unless there is a serious BUG). So there is not need to test for VM_SHARED manually. No functional change intended. Link: https://lkml.kernel.org/r/20230102160856.500584-1-david@redhat.com Link: https://lkml.kernel.org/r/20230102160856.500584-2-david@redhat.com Signed-off-by: David Hildenbrand <david@redhat.com> Cc: Arnd Bergmann <arnd@arndb.de> Cc: David Hildenbrand <david@redhat.com> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Jens Axboe <axboe@kernel.dk> Cc: Nicolas Pitre <nico@fluxnic.net> Cc: Pavel Begunkov <asml.silence@gmail.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
85 lines
2.3 KiB
C
85 lines
2.3 KiB
C
// SPDX-License-Identifier: GPL-2.0-or-later
|
|
/* NOMMU mmap support for RomFS on MTD devices
|
|
*
|
|
* Copyright © 2007 Red Hat, Inc. All Rights Reserved.
|
|
* Written by David Howells (dhowells@redhat.com)
|
|
*/
|
|
|
|
#include <linux/mm.h>
|
|
#include <linux/mtd/super.h>
|
|
#include "internal.h"
|
|
|
|
/*
|
|
* try to determine where a shared mapping can be made
|
|
* - only supported for NOMMU at the moment (MMU can't doesn't copy private
|
|
* mappings)
|
|
* - attempts to map through to the underlying MTD device
|
|
*/
|
|
static unsigned long romfs_get_unmapped_area(struct file *file,
|
|
unsigned long addr,
|
|
unsigned long len,
|
|
unsigned long pgoff,
|
|
unsigned long flags)
|
|
{
|
|
struct inode *inode = file->f_mapping->host;
|
|
struct mtd_info *mtd = inode->i_sb->s_mtd;
|
|
unsigned long isize, offset, maxpages, lpages;
|
|
int ret;
|
|
|
|
if (!mtd)
|
|
return (unsigned long) -ENOSYS;
|
|
|
|
/* the mapping mustn't extend beyond the EOF */
|
|
lpages = (len + PAGE_SIZE - 1) >> PAGE_SHIFT;
|
|
isize = i_size_read(inode);
|
|
offset = pgoff << PAGE_SHIFT;
|
|
|
|
maxpages = (isize + PAGE_SIZE - 1) >> PAGE_SHIFT;
|
|
if ((pgoff >= maxpages) || (maxpages - pgoff < lpages))
|
|
return (unsigned long) -EINVAL;
|
|
|
|
if (addr != 0)
|
|
return (unsigned long) -EINVAL;
|
|
|
|
if (len > mtd->size || pgoff >= (mtd->size >> PAGE_SHIFT))
|
|
return (unsigned long) -EINVAL;
|
|
|
|
offset += ROMFS_I(inode)->i_dataoffset;
|
|
if (offset >= mtd->size)
|
|
return (unsigned long) -EINVAL;
|
|
/* the mapping mustn't extend beyond the EOF */
|
|
if ((offset + len) > mtd->size)
|
|
len = mtd->size - offset;
|
|
|
|
ret = mtd_get_unmapped_area(mtd, len, offset, flags);
|
|
if (ret == -EOPNOTSUPP)
|
|
ret = -ENOSYS;
|
|
return (unsigned long) ret;
|
|
}
|
|
|
|
/*
|
|
* permit a R/O mapping to be made directly through onto an MTD device if
|
|
* possible
|
|
*/
|
|
static int romfs_mmap(struct file *file, struct vm_area_struct *vma)
|
|
{
|
|
return is_nommu_shared_mapping(vma->vm_flags) ? 0 : -ENOSYS;
|
|
}
|
|
|
|
static unsigned romfs_mmap_capabilities(struct file *file)
|
|
{
|
|
struct mtd_info *mtd = file_inode(file)->i_sb->s_mtd;
|
|
|
|
if (!mtd)
|
|
return NOMMU_MAP_COPY;
|
|
return mtd_mmap_capabilities(mtd);
|
|
}
|
|
|
|
const struct file_operations romfs_ro_fops = {
|
|
.llseek = generic_file_llseek,
|
|
.read_iter = generic_file_read_iter,
|
|
.splice_read = generic_file_splice_read,
|
|
.mmap = romfs_mmap,
|
|
.get_unmapped_area = romfs_get_unmapped_area,
|
|
.mmap_capabilities = romfs_mmap_capabilities,
|
|
};
|