Anna Schumaker f8cf4dabbd SUNRPC: Fix a suspicious RCU usage warning ... [ Upstream commit 31b6290869 ] I received the following warning while running cthon against an ontap server running pNFS: [ 57.202521] ============================= [ 57.202522] WARNING: suspicious RCU usage [ 57.202523] 6.7.0-rc3-g2cc14f52aeb7 #41492 Not tainted [ 57.202525] ----------------------------- [ 57.202525] net/sunrpc/xprtmultipath.c:349 RCU-list traversed in non-reader section!! [ 57.202527] other info that might help us debug this: [ 57.202528] rcu_scheduler_active = 2, debug_locks = 1 [ 57.202529] no locks held by test5/3567. [ 57.202530] stack backtrace: [ 57.202532] CPU: 0 PID: 3567 Comm: test5 Not tainted 6.7.0-rc3-g2cc14f52aeb7 #41492 5b09971b4965c0aceba19f3eea324a4a806e227e [ 57.202534] Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS unknown 2/2/2022 [ 57.202536] Call Trace: [ 57.202537] <TASK> [ 57.202540] dump_stack_lvl+0x77/0xb0 [ 57.202551] lockdep_rcu_suspicious+0x154/0x1a0 [ 57.202556] rpc_xprt_switch_has_addr+0x17c/0x190 [sunrpc ebe02571b9a8ceebf7d98e71675af20c19bdb1f6] [ 57.202596] rpc_clnt_setup_test_and_add_xprt+0x50/0x180 [sunrpc ebe02571b9a8ceebf7d98e71675af20c19bdb1f6] [ 57.202621] ? rpc_clnt_add_xprt+0x254/0x300 [sunrpc ebe02571b9a8ceebf7d98e71675af20c19bdb1f6] [ 57.202646] rpc_clnt_add_xprt+0x27a/0x300 [sunrpc ebe02571b9a8ceebf7d98e71675af20c19bdb1f6] [ 57.202671] ? __pfx_rpc_clnt_setup_test_and_add_xprt+0x10/0x10 [sunrpc ebe02571b9a8ceebf7d98e71675af20c19bdb1f6] [ 57.202696] nfs4_pnfs_ds_connect+0x345/0x760 [nfsv4 c716d88496ded0ea6d289bbea684fa996f9b57a9] [ 57.202728] ? __pfx_nfs4_test_session_trunk+0x10/0x10 [nfsv4 c716d88496ded0ea6d289bbea684fa996f9b57a9] [ 57.202754] nfs4_fl_prepare_ds+0x75/0xc0 [nfs_layout_nfsv41_files e3a4187f18ae8a27b630f9feae6831b584a9360a] [ 57.202760] filelayout_write_pagelist+0x4a/0x200 [nfs_layout_nfsv41_files e3a4187f18ae8a27b630f9feae6831b584a9360a] [ 57.202765] pnfs_generic_pg_writepages+0xbe/0x230 [nfsv4 c716d88496ded0ea6d289bbea684fa996f9b57a9] [ 57.202788] __nfs_pageio_add_request+0x3fd/0x520 [nfs 6c976fa593a7c2976f5a0aeb4965514a828e6902] [ 57.202813] nfs_pageio_add_request+0x18b/0x390 [nfs 6c976fa593a7c2976f5a0aeb4965514a828e6902] [ 57.202831] nfs_do_writepage+0x116/0x1e0 [nfs 6c976fa593a7c2976f5a0aeb4965514a828e6902] [ 57.202849] nfs_writepages_callback+0x13/0x30 [nfs 6c976fa593a7c2976f5a0aeb4965514a828e6902] [ 57.202866] write_cache_pages+0x265/0x450 [ 57.202870] ? __pfx_nfs_writepages_callback+0x10/0x10 [nfs 6c976fa593a7c2976f5a0aeb4965514a828e6902] [ 57.202891] nfs_writepages+0x141/0x230 [nfs 6c976fa593a7c2976f5a0aeb4965514a828e6902] [ 57.202913] do_writepages+0xd2/0x230 [ 57.202917] ? filemap_fdatawrite_wbc+0x5c/0x80 [ 57.202921] filemap_fdatawrite_wbc+0x67/0x80 [ 57.202924] filemap_write_and_wait_range+0xd9/0x170 [ 57.202930] nfs_wb_all+0x49/0x180 [nfs 6c976fa593a7c2976f5a0aeb4965514a828e6902] [ 57.202947] nfs4_file_flush+0x72/0xb0 [nfsv4 c716d88496ded0ea6d289bbea684fa996f9b57a9] [ 57.202969] __se_sys_close+0x46/0xd0 [ 57.202972] do_syscall_64+0x68/0x100 [ 57.202975] ? do_syscall_64+0x77/0x100 [ 57.202976] ? do_syscall_64+0x77/0x100 [ 57.202979] entry_SYSCALL_64_after_hwframe+0x6e/0x76 [ 57.202982] RIP: 0033:0x7fe2b12e4a94 [ 57.202985] Code: 00 f7 d8 64 89 01 48 83 c8 ff c3 66 2e 0f 1f 84 00 00 00 00 00 90 f3 0f 1e fa 80 3d d5 18 0e 00 00 74 13 b8 03 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 44 c3 0f 1f 00 48 83 ec 18 89 7c 24 0c e8 c3 [ 57.202987] RSP: 002b:00007ffe857ddb38 EFLAGS: 00000202 ORIG_RAX: 0000000000000003 [ 57.202989] RAX: ffffffffffffffda RBX: 00007ffe857dfd68 RCX: 00007fe2b12e4a94 [ 57.202991] RDX: 0000000000002000 RSI: 00007ffe857ddc40 RDI: 0000000000000003 [ 57.202992] RBP: 00007ffe857dfc50 R08: 7fffffffffffffff R09: 0000000065650f49 [ 57.202993] R10: 00007fe2b11f8300 R11: 0000000000000202 R12: 0000000000000000 [ 57.202994] R13: 00007ffe857dfd80 R14: 00007fe2b1445000 R15: 0000000000000000 [ 57.202999] </TASK> The problem seems to be that two out of three callers aren't taking the rcu_read_lock() before calling the list_for_each_entry_rcu() function in rpc_xprt_switch_has_addr(). I fix this by having rpc_xprt_switch_has_addr() unconditionaly take the rcu_read_lock(), which is okay to do recursively in the case that the lock has already been taken by a caller. Reviewed-by: Jeff Layton <jlayton@kernel.org> Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com> Signed-off-by: Sasha Levin <sashal@kernel.org>		2024-02-23 08:54:40 +01:00
..
auth_gss	SUNRPC: ensure the matching upcall is in-flight upon downcall	2023-01-12 11:59:08 +01:00
xprtrdma	svcrdma: Drop connection after an RDMA Read error	2023-11-28 16:56:29 +00:00
addr.c	nfsd: don't alloc under spinlock in rpc_parse_scope_id	2021-11-18 19:16:58 +01:00
auth.c	sunrpc: fix expiry of auth creds	2022-08-25 11:40:05 +02:00
auth_null.c
auth_unix.c
backchannel_rqst.c	SUNRPC: Reinitialise the backchannel request buffers before reuse	2022-08-25 11:40:05 +02:00
cache.c	SUNRPC: improve error response to over-size gss credential	2021-09-03 13:38:11 -04:00
clnt.c	SUNRPC: Fix RPC client cleaned up the freed pipefs dentries	2023-11-28 16:56:22 +00:00
debugfs.c	NFS Client Updates for Linux 5.15	2021-09-04 10:25:26 -07:00
fail.h	SUNRPC: Server-side disconnect injection	2021-08-20 13:50:33 -04:00
Kconfig
Makefile	sunrpc: Create a sunrpc directory under /sys/kernel/	2021-07-08 14:03:23 -04:00
netns.h
rpc_pipe.c	fsnotify: fix fsnotify hooks in pseudo filesystems	2022-02-01 17:27:01 +01:00
rpcb_clnt.c	SUNRPC: Add an IS_ERR() check back to where it was	2023-11-28 16:56:21 +00:00
sched.c	SUNRPC: remove the maximum number of retries in call_bind_status	2023-05-11 23:00:37 +09:00
socklib.c
socklib.h
stats.c
sunrpc.h
sunrpc_syms.c	sunrpc: add IDs to multipath	2021-07-08 14:03:23 -04:00
svc.c	SUNRPC: Fix trace_svc_register() call site	2023-05-24 17:36:51 +01:00
svc_xprt.c	SUNRPC: always free ctxt when freeing deferred request	2023-05-24 17:36:51 +01:00
svcauth.c	SUNRPC: Add svc_rqst::rq_auth_stat	2021-08-10 14:18:35 -04:00
svcauth_unix.c	sunrpc: only free unix grouplist after RCU settles	2023-04-13 16:48:19 +02:00
svcsock.c	SUNRPC: Fix UAF in svc_tcp_listen_data_ready()	2023-07-23 13:47:20 +02:00
sysctl.c
sysfs.c	SUNRPC: Fix null-ptr-deref when xps sysfs alloc failed	2022-11-10 18:15:26 +01:00
sysfs.h	SUNRPC: take a xprt offline using sysfs	2021-07-08 14:03:24 -04:00
timer.c
xdr.c	SUNRPC: Fix READ_PLUS crasher	2022-07-07 17:53:25 +02:00
xprt.c	SUNRPC: Ensure we flush any closed sockets before xs_xprt_free()	2022-05-18 10:26:57 +02:00
xprtmultipath.c	SUNRPC: Fix a suspicious RCU usage warning	2024-02-23 08:54:40 +01:00
xprtsock.c	SUNRPC: fix shutdown of NFS TCP client socket	2023-04-05 11:24:55 +02:00