mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-27 11:19:37 +00:00
![Philipp Zabel](/assets/img/avatar_default.png)
When disabling the foreground DP channel during a modeset, the DC is already disabled without waiting for end of frame. There is no reason to wait for a frame boundary before updating the DP registers in that case. Add support to apply updates immediately. No functional changes, yet. Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de> Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
508 lines
14 KiB
C
508 lines
14 KiB
C
/*
|
|
* i.MX IPUv3 DP Overlay Planes
|
|
*
|
|
* Copyright (C) 2013 Philipp Zabel, Pengutronix
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public License
|
|
* as published by the Free Software Foundation; either version 2
|
|
* of the License, or (at your option) any later version.
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*/
|
|
|
|
#include <drm/drmP.h>
|
|
#include <drm/drm_atomic.h>
|
|
#include <drm/drm_atomic_helper.h>
|
|
#include <drm/drm_fb_cma_helper.h>
|
|
#include <drm/drm_gem_cma_helper.h>
|
|
#include <drm/drm_plane_helper.h>
|
|
|
|
#include "video/imx-ipu-v3.h"
|
|
#include "ipuv3-plane.h"
|
|
|
|
static inline struct ipu_plane *to_ipu_plane(struct drm_plane *p)
|
|
{
|
|
return container_of(p, struct ipu_plane, base);
|
|
}
|
|
|
|
static const uint32_t ipu_plane_formats[] = {
|
|
DRM_FORMAT_ARGB1555,
|
|
DRM_FORMAT_XRGB1555,
|
|
DRM_FORMAT_ABGR1555,
|
|
DRM_FORMAT_XBGR1555,
|
|
DRM_FORMAT_RGBA5551,
|
|
DRM_FORMAT_BGRA5551,
|
|
DRM_FORMAT_ARGB4444,
|
|
DRM_FORMAT_ARGB8888,
|
|
DRM_FORMAT_XRGB8888,
|
|
DRM_FORMAT_ABGR8888,
|
|
DRM_FORMAT_XBGR8888,
|
|
DRM_FORMAT_RGBA8888,
|
|
DRM_FORMAT_RGBX8888,
|
|
DRM_FORMAT_BGRA8888,
|
|
DRM_FORMAT_BGRA8888,
|
|
DRM_FORMAT_UYVY,
|
|
DRM_FORMAT_VYUY,
|
|
DRM_FORMAT_YUYV,
|
|
DRM_FORMAT_YVYU,
|
|
DRM_FORMAT_YUV420,
|
|
DRM_FORMAT_YVU420,
|
|
DRM_FORMAT_YUV422,
|
|
DRM_FORMAT_YVU422,
|
|
DRM_FORMAT_YUV444,
|
|
DRM_FORMAT_YVU444,
|
|
DRM_FORMAT_NV12,
|
|
DRM_FORMAT_NV16,
|
|
DRM_FORMAT_RGB565,
|
|
};
|
|
|
|
int ipu_plane_irq(struct ipu_plane *ipu_plane)
|
|
{
|
|
return ipu_idmac_channel_irq(ipu_plane->ipu, ipu_plane->ipu_ch,
|
|
IPU_IRQ_EOF);
|
|
}
|
|
|
|
static inline unsigned long
|
|
drm_plane_state_to_eba(struct drm_plane_state *state)
|
|
{
|
|
struct drm_framebuffer *fb = state->fb;
|
|
struct drm_gem_cma_object *cma_obj;
|
|
int x = state->src.x1 >> 16;
|
|
int y = state->src.y1 >> 16;
|
|
|
|
cma_obj = drm_fb_cma_get_gem_obj(fb, 0);
|
|
BUG_ON(!cma_obj);
|
|
|
|
return cma_obj->paddr + fb->offsets[0] + fb->pitches[0] * y +
|
|
fb->format->cpp[0] * x;
|
|
}
|
|
|
|
static inline unsigned long
|
|
drm_plane_state_to_ubo(struct drm_plane_state *state)
|
|
{
|
|
struct drm_framebuffer *fb = state->fb;
|
|
struct drm_gem_cma_object *cma_obj;
|
|
unsigned long eba = drm_plane_state_to_eba(state);
|
|
int x = state->src.x1 >> 16;
|
|
int y = state->src.y1 >> 16;
|
|
|
|
cma_obj = drm_fb_cma_get_gem_obj(fb, 1);
|
|
BUG_ON(!cma_obj);
|
|
|
|
x /= drm_format_horz_chroma_subsampling(fb->format->format);
|
|
y /= drm_format_vert_chroma_subsampling(fb->format->format);
|
|
|
|
return cma_obj->paddr + fb->offsets[1] + fb->pitches[1] * y +
|
|
fb->format->cpp[1] * x - eba;
|
|
}
|
|
|
|
static inline unsigned long
|
|
drm_plane_state_to_vbo(struct drm_plane_state *state)
|
|
{
|
|
struct drm_framebuffer *fb = state->fb;
|
|
struct drm_gem_cma_object *cma_obj;
|
|
unsigned long eba = drm_plane_state_to_eba(state);
|
|
int x = state->src.x1 >> 16;
|
|
int y = state->src.y1 >> 16;
|
|
|
|
cma_obj = drm_fb_cma_get_gem_obj(fb, 2);
|
|
BUG_ON(!cma_obj);
|
|
|
|
x /= drm_format_horz_chroma_subsampling(fb->format->format);
|
|
y /= drm_format_vert_chroma_subsampling(fb->format->format);
|
|
|
|
return cma_obj->paddr + fb->offsets[2] + fb->pitches[2] * y +
|
|
fb->format->cpp[2] * x - eba;
|
|
}
|
|
|
|
void ipu_plane_put_resources(struct ipu_plane *ipu_plane)
|
|
{
|
|
if (!IS_ERR_OR_NULL(ipu_plane->dp))
|
|
ipu_dp_put(ipu_plane->dp);
|
|
if (!IS_ERR_OR_NULL(ipu_plane->dmfc))
|
|
ipu_dmfc_put(ipu_plane->dmfc);
|
|
if (!IS_ERR_OR_NULL(ipu_plane->ipu_ch))
|
|
ipu_idmac_put(ipu_plane->ipu_ch);
|
|
}
|
|
|
|
int ipu_plane_get_resources(struct ipu_plane *ipu_plane)
|
|
{
|
|
int ret;
|
|
|
|
ipu_plane->ipu_ch = ipu_idmac_get(ipu_plane->ipu, ipu_plane->dma);
|
|
if (IS_ERR(ipu_plane->ipu_ch)) {
|
|
ret = PTR_ERR(ipu_plane->ipu_ch);
|
|
DRM_ERROR("failed to get idmac channel: %d\n", ret);
|
|
return ret;
|
|
}
|
|
|
|
ipu_plane->dmfc = ipu_dmfc_get(ipu_plane->ipu, ipu_plane->dma);
|
|
if (IS_ERR(ipu_plane->dmfc)) {
|
|
ret = PTR_ERR(ipu_plane->dmfc);
|
|
DRM_ERROR("failed to get dmfc: ret %d\n", ret);
|
|
goto err_out;
|
|
}
|
|
|
|
if (ipu_plane->dp_flow >= 0) {
|
|
ipu_plane->dp = ipu_dp_get(ipu_plane->ipu, ipu_plane->dp_flow);
|
|
if (IS_ERR(ipu_plane->dp)) {
|
|
ret = PTR_ERR(ipu_plane->dp);
|
|
DRM_ERROR("failed to get dp flow: %d\n", ret);
|
|
goto err_out;
|
|
}
|
|
}
|
|
|
|
return 0;
|
|
err_out:
|
|
ipu_plane_put_resources(ipu_plane);
|
|
|
|
return ret;
|
|
}
|
|
|
|
static void ipu_plane_enable(struct ipu_plane *ipu_plane)
|
|
{
|
|
if (ipu_plane->dp)
|
|
ipu_dp_enable(ipu_plane->ipu);
|
|
ipu_dmfc_enable_channel(ipu_plane->dmfc);
|
|
ipu_idmac_enable_channel(ipu_plane->ipu_ch);
|
|
if (ipu_plane->dp)
|
|
ipu_dp_enable_channel(ipu_plane->dp);
|
|
}
|
|
|
|
static int ipu_disable_plane(struct drm_plane *plane)
|
|
{
|
|
struct ipu_plane *ipu_plane = to_ipu_plane(plane);
|
|
|
|
DRM_DEBUG_KMS("[%d] %s\n", __LINE__, __func__);
|
|
|
|
ipu_idmac_wait_busy(ipu_plane->ipu_ch, 50);
|
|
|
|
if (ipu_plane->dp)
|
|
ipu_dp_disable_channel(ipu_plane->dp, true);
|
|
ipu_idmac_disable_channel(ipu_plane->ipu_ch);
|
|
ipu_dmfc_disable_channel(ipu_plane->dmfc);
|
|
if (ipu_plane->dp)
|
|
ipu_dp_disable(ipu_plane->ipu);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static void ipu_plane_destroy(struct drm_plane *plane)
|
|
{
|
|
struct ipu_plane *ipu_plane = to_ipu_plane(plane);
|
|
|
|
DRM_DEBUG_KMS("[%d] %s\n", __LINE__, __func__);
|
|
|
|
drm_plane_cleanup(plane);
|
|
kfree(ipu_plane);
|
|
}
|
|
|
|
static const struct drm_plane_funcs ipu_plane_funcs = {
|
|
.update_plane = drm_atomic_helper_update_plane,
|
|
.disable_plane = drm_atomic_helper_disable_plane,
|
|
.destroy = ipu_plane_destroy,
|
|
.reset = drm_atomic_helper_plane_reset,
|
|
.atomic_duplicate_state = drm_atomic_helper_plane_duplicate_state,
|
|
.atomic_destroy_state = drm_atomic_helper_plane_destroy_state,
|
|
};
|
|
|
|
static int ipu_plane_atomic_check(struct drm_plane *plane,
|
|
struct drm_plane_state *state)
|
|
{
|
|
struct drm_plane_state *old_state = plane->state;
|
|
struct drm_crtc_state *crtc_state;
|
|
struct device *dev = plane->dev->dev;
|
|
struct drm_framebuffer *fb = state->fb;
|
|
struct drm_framebuffer *old_fb = old_state->fb;
|
|
unsigned long eba, ubo, vbo, old_ubo, old_vbo;
|
|
bool can_position = (plane->type == DRM_PLANE_TYPE_OVERLAY);
|
|
struct drm_rect clip;
|
|
int hsub, vsub;
|
|
int ret;
|
|
|
|
/* Ok to disable */
|
|
if (!fb)
|
|
return 0;
|
|
|
|
if (!state->crtc)
|
|
return -EINVAL;
|
|
|
|
crtc_state =
|
|
drm_atomic_get_existing_crtc_state(state->state, state->crtc);
|
|
if (WARN_ON(!crtc_state))
|
|
return -EINVAL;
|
|
|
|
clip.x1 = 0;
|
|
clip.y1 = 0;
|
|
clip.x2 = crtc_state->adjusted_mode.hdisplay;
|
|
clip.y2 = crtc_state->adjusted_mode.vdisplay;
|
|
ret = drm_plane_helper_check_state(state, &clip,
|
|
DRM_PLANE_HELPER_NO_SCALING,
|
|
DRM_PLANE_HELPER_NO_SCALING,
|
|
can_position, true);
|
|
if (ret)
|
|
return ret;
|
|
|
|
/* CRTC should be enabled */
|
|
if (!crtc_state->enable)
|
|
return -EINVAL;
|
|
|
|
switch (plane->type) {
|
|
case DRM_PLANE_TYPE_PRIMARY:
|
|
/* full plane minimum width is 13 pixels */
|
|
if (drm_rect_width(&state->dst) < 13)
|
|
return -EINVAL;
|
|
break;
|
|
case DRM_PLANE_TYPE_OVERLAY:
|
|
break;
|
|
default:
|
|
dev_warn(dev, "Unsupported plane type %d\n", plane->type);
|
|
return -EINVAL;
|
|
}
|
|
|
|
if (drm_rect_height(&state->dst) < 2)
|
|
return -EINVAL;
|
|
|
|
/*
|
|
* We support resizing active plane or changing its format by
|
|
* forcing CRTC mode change in plane's ->atomic_check callback
|
|
* and disabling all affected active planes in CRTC's ->atomic_disable
|
|
* callback. The planes will be reenabled in plane's ->atomic_update
|
|
* callback.
|
|
*/
|
|
if (old_fb &&
|
|
(drm_rect_width(&state->dst) != drm_rect_width(&old_state->dst) ||
|
|
drm_rect_height(&state->dst) != drm_rect_height(&old_state->dst) ||
|
|
fb->format != old_fb->format))
|
|
crtc_state->mode_changed = true;
|
|
|
|
eba = drm_plane_state_to_eba(state);
|
|
|
|
if (eba & 0x7)
|
|
return -EINVAL;
|
|
|
|
if (fb->pitches[0] < 1 || fb->pitches[0] > 16384)
|
|
return -EINVAL;
|
|
|
|
if (old_fb && fb->pitches[0] != old_fb->pitches[0])
|
|
crtc_state->mode_changed = true;
|
|
|
|
switch (fb->format->format) {
|
|
case DRM_FORMAT_YUV420:
|
|
case DRM_FORMAT_YVU420:
|
|
case DRM_FORMAT_YUV422:
|
|
case DRM_FORMAT_YVU422:
|
|
case DRM_FORMAT_YUV444:
|
|
case DRM_FORMAT_YVU444:
|
|
/*
|
|
* Multiplanar formats have to meet the following restrictions:
|
|
* - The (up to) three plane addresses are EBA, EBA+UBO, EBA+VBO
|
|
* - EBA, UBO and VBO are a multiple of 8
|
|
* - UBO and VBO are unsigned and not larger than 0xfffff8
|
|
* - Only EBA may be changed while scanout is active
|
|
* - The strides of U and V planes must be identical.
|
|
*/
|
|
vbo = drm_plane_state_to_vbo(state);
|
|
|
|
if (vbo & 0x7 || vbo > 0xfffff8)
|
|
return -EINVAL;
|
|
|
|
if (old_fb && (fb->format == old_fb->format)) {
|
|
old_vbo = drm_plane_state_to_vbo(old_state);
|
|
if (vbo != old_vbo)
|
|
crtc_state->mode_changed = true;
|
|
}
|
|
|
|
if (fb->pitches[1] != fb->pitches[2])
|
|
return -EINVAL;
|
|
|
|
/* fall-through */
|
|
case DRM_FORMAT_NV12:
|
|
case DRM_FORMAT_NV16:
|
|
ubo = drm_plane_state_to_ubo(state);
|
|
|
|
if (ubo & 0x7 || ubo > 0xfffff8)
|
|
return -EINVAL;
|
|
|
|
if (old_fb && (fb->format == old_fb->format)) {
|
|
old_ubo = drm_plane_state_to_ubo(old_state);
|
|
if (ubo != old_ubo)
|
|
crtc_state->mode_changed = true;
|
|
}
|
|
|
|
if (fb->pitches[1] < 1 || fb->pitches[1] > 16384)
|
|
return -EINVAL;
|
|
|
|
if (old_fb && old_fb->pitches[1] != fb->pitches[1])
|
|
crtc_state->mode_changed = true;
|
|
|
|
/*
|
|
* The x/y offsets must be even in case of horizontal/vertical
|
|
* chroma subsampling.
|
|
*/
|
|
hsub = drm_format_horz_chroma_subsampling(fb->format->format);
|
|
vsub = drm_format_vert_chroma_subsampling(fb->format->format);
|
|
if (((state->src.x1 >> 16) & (hsub - 1)) ||
|
|
((state->src.y1 >> 16) & (vsub - 1)))
|
|
return -EINVAL;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static void ipu_plane_atomic_disable(struct drm_plane *plane,
|
|
struct drm_plane_state *old_state)
|
|
{
|
|
ipu_disable_plane(plane);
|
|
}
|
|
|
|
static void ipu_plane_atomic_update(struct drm_plane *plane,
|
|
struct drm_plane_state *old_state)
|
|
{
|
|
struct ipu_plane *ipu_plane = to_ipu_plane(plane);
|
|
struct drm_plane_state *state = plane->state;
|
|
struct drm_crtc_state *crtc_state = state->crtc->state;
|
|
struct drm_framebuffer *fb = state->fb;
|
|
struct drm_rect *dst = &state->dst;
|
|
unsigned long eba, ubo, vbo;
|
|
enum ipu_color_space ics;
|
|
int active;
|
|
|
|
if (ipu_plane->dp_flow == IPU_DP_FLOW_SYNC_FG)
|
|
ipu_dp_set_window_pos(ipu_plane->dp, dst->x1, dst->y1);
|
|
|
|
eba = drm_plane_state_to_eba(state);
|
|
|
|
if (old_state->fb && !drm_atomic_crtc_needs_modeset(crtc_state)) {
|
|
active = ipu_idmac_get_current_buffer(ipu_plane->ipu_ch);
|
|
ipu_cpmem_set_buffer(ipu_plane->ipu_ch, !active, eba);
|
|
ipu_idmac_select_buffer(ipu_plane->ipu_ch, !active);
|
|
return;
|
|
}
|
|
|
|
switch (ipu_plane->dp_flow) {
|
|
case IPU_DP_FLOW_SYNC_BG:
|
|
ipu_dp_setup_channel(ipu_plane->dp,
|
|
IPUV3_COLORSPACE_RGB,
|
|
IPUV3_COLORSPACE_RGB);
|
|
ipu_dp_set_global_alpha(ipu_plane->dp, true, 0, true);
|
|
break;
|
|
case IPU_DP_FLOW_SYNC_FG:
|
|
ics = ipu_drm_fourcc_to_colorspace(state->fb->format->format);
|
|
ipu_dp_setup_channel(ipu_plane->dp, ics,
|
|
IPUV3_COLORSPACE_UNKNOWN);
|
|
/* Enable local alpha on partial plane */
|
|
switch (state->fb->format->format) {
|
|
case DRM_FORMAT_ARGB1555:
|
|
case DRM_FORMAT_ABGR1555:
|
|
case DRM_FORMAT_RGBA5551:
|
|
case DRM_FORMAT_BGRA5551:
|
|
case DRM_FORMAT_ARGB4444:
|
|
case DRM_FORMAT_ARGB8888:
|
|
case DRM_FORMAT_ABGR8888:
|
|
case DRM_FORMAT_RGBA8888:
|
|
case DRM_FORMAT_BGRA8888:
|
|
ipu_dp_set_global_alpha(ipu_plane->dp, false, 0, false);
|
|
break;
|
|
default:
|
|
ipu_dp_set_global_alpha(ipu_plane->dp, true, 0, true);
|
|
break;
|
|
}
|
|
}
|
|
|
|
ipu_dmfc_config_wait4eot(ipu_plane->dmfc, drm_rect_width(dst));
|
|
|
|
ipu_cpmem_zero(ipu_plane->ipu_ch);
|
|
ipu_cpmem_set_resolution(ipu_plane->ipu_ch,
|
|
drm_rect_width(&state->src) >> 16,
|
|
drm_rect_height(&state->src) >> 16);
|
|
ipu_cpmem_set_fmt(ipu_plane->ipu_ch, state->fb->format->format);
|
|
ipu_cpmem_set_high_priority(ipu_plane->ipu_ch);
|
|
ipu_idmac_set_double_buffer(ipu_plane->ipu_ch, 1);
|
|
ipu_cpmem_set_stride(ipu_plane->ipu_ch, state->fb->pitches[0]);
|
|
switch (fb->format->format) {
|
|
case DRM_FORMAT_YUV420:
|
|
case DRM_FORMAT_YVU420:
|
|
case DRM_FORMAT_YUV422:
|
|
case DRM_FORMAT_YVU422:
|
|
case DRM_FORMAT_YUV444:
|
|
case DRM_FORMAT_YVU444:
|
|
ubo = drm_plane_state_to_ubo(state);
|
|
vbo = drm_plane_state_to_vbo(state);
|
|
if (fb->format->format == DRM_FORMAT_YVU420 ||
|
|
fb->format->format == DRM_FORMAT_YVU422 ||
|
|
fb->format->format == DRM_FORMAT_YVU444)
|
|
swap(ubo, vbo);
|
|
|
|
ipu_cpmem_set_yuv_planar_full(ipu_plane->ipu_ch,
|
|
fb->pitches[1], ubo, vbo);
|
|
|
|
dev_dbg(ipu_plane->base.dev->dev,
|
|
"phy = %lu %lu %lu, x = %d, y = %d", eba, ubo, vbo,
|
|
state->src.x1 >> 16, state->src.y1 >> 16);
|
|
break;
|
|
case DRM_FORMAT_NV12:
|
|
case DRM_FORMAT_NV16:
|
|
ubo = drm_plane_state_to_ubo(state);
|
|
|
|
ipu_cpmem_set_yuv_planar_full(ipu_plane->ipu_ch,
|
|
fb->pitches[1], ubo, ubo);
|
|
|
|
dev_dbg(ipu_plane->base.dev->dev,
|
|
"phy = %lu %lu, x = %d, y = %d", eba, ubo,
|
|
state->src.x1 >> 16, state->src.y1 >> 16);
|
|
break;
|
|
default:
|
|
dev_dbg(ipu_plane->base.dev->dev, "phys = %lu, x = %d, y = %d",
|
|
eba, state->src.x1 >> 16, state->src.y1 >> 16);
|
|
break;
|
|
}
|
|
ipu_cpmem_set_buffer(ipu_plane->ipu_ch, 0, eba);
|
|
ipu_cpmem_set_buffer(ipu_plane->ipu_ch, 1, eba);
|
|
ipu_plane_enable(ipu_plane);
|
|
}
|
|
|
|
static const struct drm_plane_helper_funcs ipu_plane_helper_funcs = {
|
|
.prepare_fb = drm_fb_cma_prepare_fb,
|
|
.atomic_check = ipu_plane_atomic_check,
|
|
.atomic_disable = ipu_plane_atomic_disable,
|
|
.atomic_update = ipu_plane_atomic_update,
|
|
};
|
|
|
|
struct ipu_plane *ipu_plane_init(struct drm_device *dev, struct ipu_soc *ipu,
|
|
int dma, int dp, unsigned int possible_crtcs,
|
|
enum drm_plane_type type)
|
|
{
|
|
struct ipu_plane *ipu_plane;
|
|
int ret;
|
|
|
|
DRM_DEBUG_KMS("channel %d, dp flow %d, possible_crtcs=0x%x\n",
|
|
dma, dp, possible_crtcs);
|
|
|
|
ipu_plane = kzalloc(sizeof(*ipu_plane), GFP_KERNEL);
|
|
if (!ipu_plane) {
|
|
DRM_ERROR("failed to allocate plane\n");
|
|
return ERR_PTR(-ENOMEM);
|
|
}
|
|
|
|
ipu_plane->ipu = ipu;
|
|
ipu_plane->dma = dma;
|
|
ipu_plane->dp_flow = dp;
|
|
|
|
ret = drm_universal_plane_init(dev, &ipu_plane->base, possible_crtcs,
|
|
&ipu_plane_funcs, ipu_plane_formats,
|
|
ARRAY_SIZE(ipu_plane_formats), type,
|
|
NULL);
|
|
if (ret) {
|
|
DRM_ERROR("failed to initialize plane\n");
|
|
kfree(ipu_plane);
|
|
return ERR_PTR(ret);
|
|
}
|
|
|
|
drm_plane_helper_add(&ipu_plane->base, &ipu_plane_helper_funcs);
|
|
|
|
return ipu_plane;
|
|
}
|