mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-14 06:35:12 +00:00
e2705b0304
This debug code is called on every xfs_iflush() call, which then
checks every inode in the buffer for non-zero unlinked list field.
Hence it checks every inode in the cluster buffer every time a
single inode on that cluster it flushed. This is resulting in:
- 38.91% 5.33% [kernel] [k] xfs_iflush
- 17.70% xfs_iflush
- 9.93% xfs_inobp_check
4.36% xfs_buf_offset
10% of the CPU time spent flushing inodes is repeatedly checking
unlinked fields in the buffer. We don't need to do this.
The other place we call xfs_inobp_check() is
xfs_iunlink_update_dinode(), and this is after we've done this
assert for the agino we are about to write into that inode:
ASSERT(xfs_verify_agino_or_null(mp, agno, next_agino));
which means we've already checked that the agino we are about to
write is not 0 on debug kernels. The inode buffer verifiers do
everything else we need, so let's just remove this debug code.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
63 lines
2.3 KiB
C
63 lines
2.3 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
/*
|
|
* Copyright (c) 2000-2003,2005 Silicon Graphics, Inc.
|
|
* All Rights Reserved.
|
|
*/
|
|
#ifndef __XFS_INODE_BUF_H__
|
|
#define __XFS_INODE_BUF_H__
|
|
|
|
struct xfs_inode;
|
|
struct xfs_dinode;
|
|
|
|
/*
|
|
* In memory representation of the XFS inode. This is held in the in-core struct
|
|
* xfs_inode and represents the current on disk values but the structure is not
|
|
* in on-disk format. That is, this structure is always translated to on-disk
|
|
* format specific structures at the appropriate time.
|
|
*/
|
|
struct xfs_icdinode {
|
|
uint16_t di_flushiter; /* incremented on flush */
|
|
uint32_t di_projid; /* owner's project id */
|
|
xfs_fsize_t di_size; /* number of bytes in file */
|
|
xfs_rfsblock_t di_nblocks; /* # of direct & btree blocks used */
|
|
xfs_extlen_t di_extsize; /* basic/minimum extent size for file */
|
|
uint8_t di_forkoff; /* attr fork offs, <<3 for 64b align */
|
|
uint32_t di_dmevmask; /* DMIG event mask */
|
|
uint16_t di_dmstate; /* DMIG state info */
|
|
uint16_t di_flags; /* random flags, XFS_DIFLAG_... */
|
|
|
|
uint64_t di_flags2; /* more random flags */
|
|
uint32_t di_cowextsize; /* basic cow extent size for file */
|
|
|
|
struct timespec64 di_crtime; /* time created */
|
|
};
|
|
|
|
/*
|
|
* Inode location information. Stored in the inode and passed to
|
|
* xfs_imap_to_bp() to get a buffer and dinode for a given inode.
|
|
*/
|
|
struct xfs_imap {
|
|
xfs_daddr_t im_blkno; /* starting BB of inode chunk */
|
|
unsigned short im_len; /* length in BBs of inode chunk */
|
|
unsigned short im_boffset; /* inode offset in block in bytes */
|
|
};
|
|
|
|
int xfs_imap_to_bp(struct xfs_mount *, struct xfs_trans *,
|
|
struct xfs_imap *, struct xfs_dinode **,
|
|
struct xfs_buf **, uint);
|
|
void xfs_dinode_calc_crc(struct xfs_mount *, struct xfs_dinode *);
|
|
void xfs_inode_to_disk(struct xfs_inode *ip, struct xfs_dinode *to,
|
|
xfs_lsn_t lsn);
|
|
int xfs_inode_from_disk(struct xfs_inode *ip, struct xfs_dinode *from);
|
|
void xfs_log_dinode_to_disk(struct xfs_log_dinode *from,
|
|
struct xfs_dinode *to);
|
|
|
|
xfs_failaddr_t xfs_dinode_verify(struct xfs_mount *mp, xfs_ino_t ino,
|
|
struct xfs_dinode *dip);
|
|
xfs_failaddr_t xfs_inode_validate_extsize(struct xfs_mount *mp,
|
|
uint32_t extsize, uint16_t mode, uint16_t flags);
|
|
xfs_failaddr_t xfs_inode_validate_cowextsize(struct xfs_mount *mp,
|
|
uint32_t cowextsize, uint16_t mode, uint16_t flags,
|
|
uint64_t flags2);
|
|
|
|
#endif /* __XFS_INODE_BUF_H__ */
|