mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-30 14:19:16 +00:00
4ad8766cd3
The am65_cpts_release() function is registered as a devm_action in the
am65_cpts_create() function in am65-cpts driver. When the am65-cpsw driver
invokes am65_cpts_create(), am65_cpts_release() is added in the set of devm
actions associated with the am65-cpsw driver's device.
In the event of probe failure or probe deferral, the platform_drv_probe()
function invokes dev_pm_domain_detach() which powers off the CPSW and the
CPSW's CPTS hardware, both of which share the same power domain. Since the
am65_cpts_disable() function invoked by the am65_cpts_release() function
attempts to reset the CPTS hardware by writing to its registers, the CPTS
hardware is assumed to be powered on at this point. However, the hardware
is powered off before the devm actions are executed.
Fix this by getting rid of the devm action for am65_cpts_release() and
invoking it directly on the cleanup and exit paths.
Fixes: f6bd59526c ("net: ethernet: ti: introduce am654 common platform time sync driver")
Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Reviewed-by: Tony Nguyen <anthony.l.nguyen@intel.com>
Reviewed-by: Roger Quadros <rogerq@kernel.org>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
89 lines
2.1 KiB
C
89 lines
2.1 KiB
C
/* SPDX-License-Identifier: GPL-2.0+ */
|
|
/* TI K3 AM65 CPTS driver interface
|
|
*
|
|
* Copyright (C) 2020 Texas Instruments Incorporated - http://www.ti.com
|
|
*/
|
|
|
|
#ifndef K3_CPTS_H_
|
|
#define K3_CPTS_H_
|
|
|
|
#include <linux/device.h>
|
|
#include <linux/of.h>
|
|
|
|
struct am65_cpts;
|
|
|
|
struct am65_cpts_estf_cfg {
|
|
u64 ns_period;
|
|
u64 ns_start;
|
|
};
|
|
|
|
#if IS_ENABLED(CONFIG_TI_K3_AM65_CPTS)
|
|
void am65_cpts_release(struct am65_cpts *cpts);
|
|
struct am65_cpts *am65_cpts_create(struct device *dev, void __iomem *regs,
|
|
struct device_node *node);
|
|
int am65_cpts_phc_index(struct am65_cpts *cpts);
|
|
void am65_cpts_tx_timestamp(struct am65_cpts *cpts, struct sk_buff *skb);
|
|
void am65_cpts_prep_tx_timestamp(struct am65_cpts *cpts, struct sk_buff *skb);
|
|
void am65_cpts_rx_enable(struct am65_cpts *cpts, bool en);
|
|
u64 am65_cpts_ns_gettime(struct am65_cpts *cpts);
|
|
int am65_cpts_estf_enable(struct am65_cpts *cpts, int idx,
|
|
struct am65_cpts_estf_cfg *cfg);
|
|
void am65_cpts_estf_disable(struct am65_cpts *cpts, int idx);
|
|
void am65_cpts_suspend(struct am65_cpts *cpts);
|
|
void am65_cpts_resume(struct am65_cpts *cpts);
|
|
#else
|
|
static inline void am65_cpts_release(struct am65_cpts *cpts)
|
|
{
|
|
}
|
|
|
|
static inline struct am65_cpts *am65_cpts_create(struct device *dev,
|
|
void __iomem *regs,
|
|
struct device_node *node)
|
|
{
|
|
return ERR_PTR(-EOPNOTSUPP);
|
|
}
|
|
|
|
static inline int am65_cpts_phc_index(struct am65_cpts *cpts)
|
|
{
|
|
return -1;
|
|
}
|
|
|
|
static inline void am65_cpts_tx_timestamp(struct am65_cpts *cpts,
|
|
struct sk_buff *skb)
|
|
{
|
|
}
|
|
|
|
static inline void am65_cpts_prep_tx_timestamp(struct am65_cpts *cpts,
|
|
struct sk_buff *skb)
|
|
{
|
|
}
|
|
|
|
static inline void am65_cpts_rx_enable(struct am65_cpts *cpts, bool en)
|
|
{
|
|
}
|
|
|
|
static inline s64 am65_cpts_ns_gettime(struct am65_cpts *cpts)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
static inline int am65_cpts_estf_enable(struct am65_cpts *cpts, int idx,
|
|
struct am65_cpts_estf_cfg *cfg)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
static inline void am65_cpts_estf_disable(struct am65_cpts *cpts, int idx)
|
|
{
|
|
}
|
|
|
|
static inline void am65_cpts_suspend(struct am65_cpts *cpts)
|
|
{
|
|
}
|
|
|
|
static inline void am65_cpts_resume(struct am65_cpts *cpts)
|
|
{
|
|
}
|
|
#endif
|
|
|
|
#endif /* K3_CPTS_H_ */
|