mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-23 17:30:02 +00:00
![Ville Syrjälä](/assets/img/avatar_default.png)
Make I915_READ and I915_WRITE more type safe by wrapping the register offset in a struct. This should eliminate most of the fumbles we've had with misplaced parens. This only takes care of normal mmio registers. We could extend the idea to other register types and define each with its own struct. That way you wouldn't be able to accidentally pass the wrong thing to a specific register access function. The gpio_reg setup is probably the ugliest thing left. But I figure I'd just leave it for now, and wait for some divine inspiration to strike before making it nice. As for the generated code, it's actually a bit better sometimes. Eg. looking at i915_irq_handler(), we can see the following change: lea 0x70024(%rdx,%rax,1),%r9d mov $0x1,%edx - movslq %r9d,%r9 - mov %r9,%rsi - mov %r9,-0x58(%rbp) - callq *0xd8(%rbx) + mov %r9d,%esi + mov %r9d,-0x48(%rbp) callq *0xd8(%rbx) So previously gcc thought the register offset might be signed and decided to sign extend it, just in case. The rest appears to be mostly just minor shuffling of instructions. v2: i915_mmio_reg_{offset,equal,valid}() helpers added s/_REG/_MMIO/ in the register defines mo more switch statements left to worry about ring_emit stuff got sorted in a prep patch cmd parser, lrc context and w/a batch buildup also in prep patch vgpu stuff cleaned up and moved to a prep patch all other unrelated changes split out v3: Rebased due to BXT DSI/BLC, MOCS, etc. v4: Rebased due to churn, s/i915_mmio_reg_t/i915_reg_t/ Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> Link: http://patchwork.freedesktop.org/patch/msgid/1447853606-2751-1-git-send-email-ville.syrjala@linux.intel.com
110 lines
4.1 KiB
C
110 lines
4.1 KiB
C
/*
|
|
* Copyright © 2014 Intel Corporation
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person obtaining a
|
|
* copy of this software and associated documentation files (the "Software"),
|
|
* to deal in the Software without restriction, including without limitation
|
|
* the rights to use, copy, modify, merge, publish, distribute, sublicense,
|
|
* and/or sell copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following conditions:
|
|
*
|
|
* The above copyright notice and this permission notice (including the next
|
|
* paragraph) shall be included in all copies or substantial portions of the
|
|
* Software.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
|
|
* IN THE SOFTWARE.
|
|
*
|
|
*/
|
|
#ifndef _I915_GUC_REG_H_
|
|
#define _I915_GUC_REG_H_
|
|
|
|
/* Definitions of GuC H/W registers, bits, etc */
|
|
|
|
#define GUC_STATUS _MMIO(0xc000)
|
|
#define GS_BOOTROM_SHIFT 1
|
|
#define GS_BOOTROM_MASK (0x7F << GS_BOOTROM_SHIFT)
|
|
#define GS_BOOTROM_RSA_FAILED (0x50 << GS_BOOTROM_SHIFT)
|
|
#define GS_UKERNEL_SHIFT 8
|
|
#define GS_UKERNEL_MASK (0xFF << GS_UKERNEL_SHIFT)
|
|
#define GS_UKERNEL_LAPIC_DONE (0x30 << GS_UKERNEL_SHIFT)
|
|
#define GS_UKERNEL_DPC_ERROR (0x60 << GS_UKERNEL_SHIFT)
|
|
#define GS_UKERNEL_READY (0xF0 << GS_UKERNEL_SHIFT)
|
|
#define GS_MIA_SHIFT 16
|
|
#define GS_MIA_MASK (0x07 << GS_MIA_SHIFT)
|
|
#define GS_MIA_CORE_STATE (1 << GS_MIA_SHIFT)
|
|
|
|
#define SOFT_SCRATCH(n) _MMIO(0xc180 + (n) * 4)
|
|
|
|
#define UOS_RSA_SCRATCH(i) _MMIO(0xc200 + (i) * 4)
|
|
#define UOS_RSA_SCRATCH_MAX_COUNT 64
|
|
#define DMA_ADDR_0_LOW _MMIO(0xc300)
|
|
#define DMA_ADDR_0_HIGH _MMIO(0xc304)
|
|
#define DMA_ADDR_1_LOW _MMIO(0xc308)
|
|
#define DMA_ADDR_1_HIGH _MMIO(0xc30c)
|
|
#define DMA_ADDRESS_SPACE_WOPCM (7 << 16)
|
|
#define DMA_ADDRESS_SPACE_GTT (8 << 16)
|
|
#define DMA_COPY_SIZE _MMIO(0xc310)
|
|
#define DMA_CTRL _MMIO(0xc314)
|
|
#define UOS_MOVE (1<<4)
|
|
#define START_DMA (1<<0)
|
|
#define DMA_GUC_WOPCM_OFFSET _MMIO(0xc340)
|
|
#define GUC_WOPCM_OFFSET_VALUE 0x80000 /* 512KB */
|
|
#define GUC_MAX_IDLE_COUNT _MMIO(0xC3E4)
|
|
|
|
#define GUC_WOPCM_SIZE _MMIO(0xc050)
|
|
#define GUC_WOPCM_SIZE_VALUE (0x80 << 12) /* 512KB */
|
|
|
|
/* GuC addresses below GUC_WOPCM_TOP don't map through the GTT */
|
|
#define GUC_WOPCM_TOP (GUC_WOPCM_SIZE_VALUE)
|
|
|
|
#define GEN8_GT_PM_CONFIG _MMIO(0x138140)
|
|
#define GEN9LP_GT_PM_CONFIG _MMIO(0x138140)
|
|
#define GEN9_GT_PM_CONFIG _MMIO(0x13816c)
|
|
#define GT_DOORBELL_ENABLE (1<<0)
|
|
|
|
#define GEN8_GTCR _MMIO(0x4274)
|
|
#define GEN8_GTCR_INVALIDATE (1<<0)
|
|
|
|
#define GUC_ARAT_C6DIS _MMIO(0xA178)
|
|
|
|
#define GUC_SHIM_CONTROL _MMIO(0xc064)
|
|
#define GUC_DISABLE_SRAM_INIT_TO_ZEROES (1<<0)
|
|
#define GUC_ENABLE_READ_CACHE_LOGIC (1<<1)
|
|
#define GUC_ENABLE_MIA_CACHING (1<<2)
|
|
#define GUC_GEN10_MSGCH_ENABLE (1<<4)
|
|
#define GUC_ENABLE_READ_CACHE_FOR_SRAM_DATA (1<<9)
|
|
#define GUC_ENABLE_READ_CACHE_FOR_WOPCM_DATA (1<<10)
|
|
#define GUC_ENABLE_MIA_CLOCK_GATING (1<<15)
|
|
#define GUC_GEN10_SHIM_WC_ENABLE (1<<21)
|
|
|
|
#define GUC_SHIM_CONTROL_VALUE (GUC_DISABLE_SRAM_INIT_TO_ZEROES | \
|
|
GUC_ENABLE_READ_CACHE_LOGIC | \
|
|
GUC_ENABLE_MIA_CACHING | \
|
|
GUC_ENABLE_READ_CACHE_FOR_SRAM_DATA | \
|
|
GUC_ENABLE_READ_CACHE_FOR_WOPCM_DATA | \
|
|
GUC_ENABLE_MIA_CLOCK_GATING)
|
|
|
|
#define HOST2GUC_INTERRUPT _MMIO(0xc4c8)
|
|
#define HOST2GUC_TRIGGER (1<<0)
|
|
|
|
#define DRBMISC1 0x1984
|
|
#define DOORBELL_ENABLE (1<<0)
|
|
|
|
#define GEN8_DRBREGL(x) _MMIO(0x1000 + (x) * 8)
|
|
#define GEN8_DRB_VALID (1<<0)
|
|
#define GEN8_DRBREGU(x) _MMIO(0x1000 + (x) * 8 + 4)
|
|
|
|
#define DE_GUCRMR _MMIO(0x44054)
|
|
|
|
#define GUC_BCS_RCS_IER _MMIO(0xC550)
|
|
#define GUC_VCS2_VCS1_IER _MMIO(0xC554)
|
|
#define GUC_WD_VECS_IER _MMIO(0xC558)
|
|
#define GUC_PM_P24C_IER _MMIO(0xC55C)
|
|
|
|
#endif
|