mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-23 17:30:02 +00:00
![Ville Syrjälä](/assets/img/avatar_default.png)
Make I915_READ and I915_WRITE more type safe by wrapping the register offset in a struct. This should eliminate most of the fumbles we've had with misplaced parens. This only takes care of normal mmio registers. We could extend the idea to other register types and define each with its own struct. That way you wouldn't be able to accidentally pass the wrong thing to a specific register access function. The gpio_reg setup is probably the ugliest thing left. But I figure I'd just leave it for now, and wait for some divine inspiration to strike before making it nice. As for the generated code, it's actually a bit better sometimes. Eg. looking at i915_irq_handler(), we can see the following change: lea 0x70024(%rdx,%rax,1),%r9d mov $0x1,%edx - movslq %r9d,%r9 - mov %r9,%rsi - mov %r9,-0x58(%rbp) - callq *0xd8(%rbx) + mov %r9d,%esi + mov %r9d,-0x48(%rbp) callq *0xd8(%rbx) So previously gcc thought the register offset might be signed and decided to sign extend it, just in case. The rest appears to be mostly just minor shuffling of instructions. v2: i915_mmio_reg_{offset,equal,valid}() helpers added s/_REG/_MMIO/ in the register defines mo more switch statements left to worry about ring_emit stuff got sorted in a prep patch cmd parser, lrc context and w/a batch buildup also in prep patch vgpu stuff cleaned up and moved to a prep patch all other unrelated changes split out v3: Rebased due to BXT DSI/BLC, MOCS, etc. v4: Rebased due to churn, s/i915_mmio_reg_t/i915_reg_t/ Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> Link: http://patchwork.freedesktop.org/patch/msgid/1447853606-2751-1-git-send-email-ville.syrjala@linux.intel.com
344 lines
11 KiB
C
344 lines
11 KiB
C
/*
|
|
* Copyright (c) 2015 Intel Corporation
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person obtaining a
|
|
* copy of this software and associated documentation files (the "Software"),
|
|
* to deal in the Software without restriction, including without limitation
|
|
* the rights to use, copy, modify, merge, publish, distribute, sublicense,
|
|
* and/or sell copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following conditions: *
|
|
* The above copyright notice and this permission notice (including the next
|
|
* paragraph) shall be included in all copies or substantial portions of the
|
|
* Software.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
|
|
* SOFTWARE.
|
|
*/
|
|
|
|
#include "intel_mocs.h"
|
|
#include "intel_lrc.h"
|
|
#include "intel_ringbuffer.h"
|
|
|
|
/* structures required */
|
|
struct drm_i915_mocs_entry {
|
|
u32 control_value;
|
|
u16 l3cc_value;
|
|
};
|
|
|
|
struct drm_i915_mocs_table {
|
|
u32 size;
|
|
const struct drm_i915_mocs_entry *table;
|
|
};
|
|
|
|
/* Defines for the tables (XXX_MOCS_0 - XXX_MOCS_63) */
|
|
#define LE_CACHEABILITY(value) ((value) << 0)
|
|
#define LE_TGT_CACHE(value) ((value) << 2)
|
|
#define LE_LRUM(value) ((value) << 4)
|
|
#define LE_AOM(value) ((value) << 6)
|
|
#define LE_RSC(value) ((value) << 7)
|
|
#define LE_SCC(value) ((value) << 8)
|
|
#define LE_PFM(value) ((value) << 11)
|
|
#define LE_SCF(value) ((value) << 14)
|
|
|
|
/* Defines for the tables (LNCFMOCS0 - LNCFMOCS31) - two entries per word */
|
|
#define L3_ESC(value) ((value) << 0)
|
|
#define L3_SCC(value) ((value) << 1)
|
|
#define L3_CACHEABILITY(value) ((value) << 4)
|
|
|
|
/* Helper defines */
|
|
#define GEN9_NUM_MOCS_ENTRIES 62 /* 62 out of 64 - 63 & 64 are reserved. */
|
|
|
|
/* (e)LLC caching options */
|
|
#define LE_PAGETABLE 0
|
|
#define LE_UC 1
|
|
#define LE_WT 2
|
|
#define LE_WB 3
|
|
|
|
/* L3 caching options */
|
|
#define L3_DIRECT 0
|
|
#define L3_UC 1
|
|
#define L3_RESERVED 2
|
|
#define L3_WB 3
|
|
|
|
/* Target cache */
|
|
#define ELLC 0
|
|
#define LLC 1
|
|
#define LLC_ELLC 2
|
|
|
|
/*
|
|
* MOCS tables
|
|
*
|
|
* These are the MOCS tables that are programmed across all the rings.
|
|
* The control value is programmed to all the rings that support the
|
|
* MOCS registers. While the l3cc_values are only programmed to the
|
|
* LNCFCMOCS0 - LNCFCMOCS32 registers.
|
|
*
|
|
* These tables are intended to be kept reasonably consistent across
|
|
* platforms. However some of the fields are not applicable to all of
|
|
* them.
|
|
*
|
|
* Entries not part of the following tables are undefined as far as
|
|
* userspace is concerned and shouldn't be relied upon. For the time
|
|
* being they will be implicitly initialized to the strictest caching
|
|
* configuration (uncached) to guarantee forwards compatibility with
|
|
* userspace programs written against more recent kernels providing
|
|
* additional MOCS entries.
|
|
*
|
|
* NOTE: These tables MUST start with being uncached and the length
|
|
* MUST be less than 63 as the last two registers are reserved
|
|
* by the hardware. These tables are part of the kernel ABI and
|
|
* may only be updated incrementally by adding entries at the
|
|
* end.
|
|
*/
|
|
static const struct drm_i915_mocs_entry skylake_mocs_table[] = {
|
|
/* { 0x00000009, 0x0010 } */
|
|
{ (LE_CACHEABILITY(LE_UC) | LE_TGT_CACHE(LLC_ELLC) | LE_LRUM(0) |
|
|
LE_AOM(0) | LE_RSC(0) | LE_SCC(0) | LE_PFM(0) | LE_SCF(0)),
|
|
(L3_ESC(0) | L3_SCC(0) | L3_CACHEABILITY(L3_UC)) },
|
|
/* { 0x00000038, 0x0030 } */
|
|
{ (LE_CACHEABILITY(LE_PAGETABLE) | LE_TGT_CACHE(LLC_ELLC) | LE_LRUM(3) |
|
|
LE_AOM(0) | LE_RSC(0) | LE_SCC(0) | LE_PFM(0) | LE_SCF(0)),
|
|
(L3_ESC(0) | L3_SCC(0) | L3_CACHEABILITY(L3_WB)) },
|
|
/* { 0x0000003b, 0x0030 } */
|
|
{ (LE_CACHEABILITY(LE_WB) | LE_TGT_CACHE(LLC_ELLC) | LE_LRUM(3) |
|
|
LE_AOM(0) | LE_RSC(0) | LE_SCC(0) | LE_PFM(0) | LE_SCF(0)),
|
|
(L3_ESC(0) | L3_SCC(0) | L3_CACHEABILITY(L3_WB)) }
|
|
};
|
|
|
|
/* NOTE: the LE_TGT_CACHE is not used on Broxton */
|
|
static const struct drm_i915_mocs_entry broxton_mocs_table[] = {
|
|
/* { 0x00000009, 0x0010 } */
|
|
{ (LE_CACHEABILITY(LE_UC) | LE_TGT_CACHE(LLC_ELLC) | LE_LRUM(0) |
|
|
LE_AOM(0) | LE_RSC(0) | LE_SCC(0) | LE_PFM(0) | LE_SCF(0)),
|
|
(L3_ESC(0) | L3_SCC(0) | L3_CACHEABILITY(L3_UC)) },
|
|
/* { 0x00000038, 0x0030 } */
|
|
{ (LE_CACHEABILITY(LE_PAGETABLE) | LE_TGT_CACHE(LLC_ELLC) | LE_LRUM(3) |
|
|
LE_AOM(0) | LE_RSC(0) | LE_SCC(0) | LE_PFM(0) | LE_SCF(0)),
|
|
(L3_ESC(0) | L3_SCC(0) | L3_CACHEABILITY(L3_WB)) },
|
|
/* { 0x0000003b, 0x0030 } */
|
|
{ (LE_CACHEABILITY(LE_WB) | LE_TGT_CACHE(LLC_ELLC) | LE_LRUM(3) |
|
|
LE_AOM(0) | LE_RSC(0) | LE_SCC(0) | LE_PFM(0) | LE_SCF(0)),
|
|
(L3_ESC(0) | L3_SCC(0) | L3_CACHEABILITY(L3_WB)) }
|
|
};
|
|
|
|
/**
|
|
* get_mocs_settings()
|
|
* @dev: DRM device.
|
|
* @table: Output table that will be made to point at appropriate
|
|
* MOCS values for the device.
|
|
*
|
|
* This function will return the values of the MOCS table that needs to
|
|
* be programmed for the platform. It will return the values that need
|
|
* to be programmed and if they need to be programmed.
|
|
*
|
|
* Return: true if there are applicable MOCS settings for the device.
|
|
*/
|
|
static bool get_mocs_settings(struct drm_device *dev,
|
|
struct drm_i915_mocs_table *table)
|
|
{
|
|
bool result = false;
|
|
|
|
if (IS_SKYLAKE(dev) || IS_KABYLAKE(dev)) {
|
|
table->size = ARRAY_SIZE(skylake_mocs_table);
|
|
table->table = skylake_mocs_table;
|
|
result = true;
|
|
} else if (IS_BROXTON(dev)) {
|
|
table->size = ARRAY_SIZE(broxton_mocs_table);
|
|
table->table = broxton_mocs_table;
|
|
result = true;
|
|
} else {
|
|
WARN_ONCE(INTEL_INFO(dev)->gen >= 9,
|
|
"Platform that should have a MOCS table does not.\n");
|
|
}
|
|
|
|
return result;
|
|
}
|
|
|
|
static i915_reg_t mocs_register(enum intel_ring_id ring, int index)
|
|
{
|
|
switch (ring) {
|
|
case RCS:
|
|
return GEN9_GFX_MOCS(index);
|
|
case VCS:
|
|
return GEN9_MFX0_MOCS(index);
|
|
case BCS:
|
|
return GEN9_BLT_MOCS(index);
|
|
case VECS:
|
|
return GEN9_VEBOX_MOCS(index);
|
|
case VCS2:
|
|
return GEN9_MFX1_MOCS(index);
|
|
default:
|
|
MISSING_CASE(ring);
|
|
return INVALID_MMIO_REG;
|
|
}
|
|
}
|
|
|
|
/**
|
|
* emit_mocs_control_table() - emit the mocs control table
|
|
* @req: Request to set up the MOCS table for.
|
|
* @table: The values to program into the control regs.
|
|
* @ring: The engine for whom to emit the registers.
|
|
*
|
|
* This function simply emits a MI_LOAD_REGISTER_IMM command for the
|
|
* given table starting at the given address.
|
|
*
|
|
* Return: 0 on success, otherwise the error status.
|
|
*/
|
|
static int emit_mocs_control_table(struct drm_i915_gem_request *req,
|
|
const struct drm_i915_mocs_table *table,
|
|
enum intel_ring_id ring)
|
|
{
|
|
struct intel_ringbuffer *ringbuf = req->ringbuf;
|
|
unsigned int index;
|
|
int ret;
|
|
|
|
if (WARN_ON(table->size > GEN9_NUM_MOCS_ENTRIES))
|
|
return -ENODEV;
|
|
|
|
ret = intel_logical_ring_begin(req, 2 + 2 * GEN9_NUM_MOCS_ENTRIES);
|
|
if (ret) {
|
|
DRM_DEBUG("intel_logical_ring_begin failed %d\n", ret);
|
|
return ret;
|
|
}
|
|
|
|
intel_logical_ring_emit(ringbuf,
|
|
MI_LOAD_REGISTER_IMM(GEN9_NUM_MOCS_ENTRIES));
|
|
|
|
for (index = 0; index < table->size; index++) {
|
|
intel_logical_ring_emit_reg(ringbuf, mocs_register(ring, index));
|
|
intel_logical_ring_emit(ringbuf,
|
|
table->table[index].control_value);
|
|
}
|
|
|
|
/*
|
|
* Ok, now set the unused entries to uncached. These entries
|
|
* are officially undefined and no contract for the contents
|
|
* and settings is given for these entries.
|
|
*
|
|
* Entry 0 in the table is uncached - so we are just writing
|
|
* that value to all the used entries.
|
|
*/
|
|
for (; index < GEN9_NUM_MOCS_ENTRIES; index++) {
|
|
intel_logical_ring_emit_reg(ringbuf, mocs_register(ring, index));
|
|
intel_logical_ring_emit(ringbuf, table->table[0].control_value);
|
|
}
|
|
|
|
intel_logical_ring_emit(ringbuf, MI_NOOP);
|
|
intel_logical_ring_advance(ringbuf);
|
|
|
|
return 0;
|
|
}
|
|
|
|
/**
|
|
* emit_mocs_l3cc_table() - emit the mocs control table
|
|
* @req: Request to set up the MOCS table for.
|
|
* @table: The values to program into the control regs.
|
|
*
|
|
* This function simply emits a MI_LOAD_REGISTER_IMM command for the
|
|
* given table starting at the given address. This register set is
|
|
* programmed in pairs.
|
|
*
|
|
* Return: 0 on success, otherwise the error status.
|
|
*/
|
|
static int emit_mocs_l3cc_table(struct drm_i915_gem_request *req,
|
|
const struct drm_i915_mocs_table *table)
|
|
{
|
|
struct intel_ringbuffer *ringbuf = req->ringbuf;
|
|
unsigned int count;
|
|
unsigned int i;
|
|
u32 value;
|
|
u32 filler = (table->table[0].l3cc_value & 0xffff) |
|
|
((table->table[0].l3cc_value & 0xffff) << 16);
|
|
int ret;
|
|
|
|
if (WARN_ON(table->size > GEN9_NUM_MOCS_ENTRIES))
|
|
return -ENODEV;
|
|
|
|
ret = intel_logical_ring_begin(req, 2 + GEN9_NUM_MOCS_ENTRIES);
|
|
if (ret) {
|
|
DRM_DEBUG("intel_logical_ring_begin failed %d\n", ret);
|
|
return ret;
|
|
}
|
|
|
|
intel_logical_ring_emit(ringbuf,
|
|
MI_LOAD_REGISTER_IMM(GEN9_NUM_MOCS_ENTRIES / 2));
|
|
|
|
for (i = 0, count = 0; i < table->size / 2; i++, count += 2) {
|
|
value = (table->table[count].l3cc_value & 0xffff) |
|
|
((table->table[count + 1].l3cc_value & 0xffff) << 16);
|
|
|
|
intel_logical_ring_emit_reg(ringbuf, GEN9_LNCFCMOCS(i));
|
|
intel_logical_ring_emit(ringbuf, value);
|
|
}
|
|
|
|
if (table->size & 0x01) {
|
|
/* Odd table size - 1 left over */
|
|
value = (table->table[count].l3cc_value & 0xffff) |
|
|
((table->table[0].l3cc_value & 0xffff) << 16);
|
|
} else
|
|
value = filler;
|
|
|
|
/*
|
|
* Now set the rest of the table to uncached - use entry 0 as
|
|
* this will be uncached. Leave the last pair uninitialised as
|
|
* they are reserved by the hardware.
|
|
*/
|
|
for (; i < GEN9_NUM_MOCS_ENTRIES / 2; i++) {
|
|
intel_logical_ring_emit_reg(ringbuf, GEN9_LNCFCMOCS(i));
|
|
intel_logical_ring_emit(ringbuf, value);
|
|
|
|
value = filler;
|
|
}
|
|
|
|
intel_logical_ring_emit(ringbuf, MI_NOOP);
|
|
intel_logical_ring_advance(ringbuf);
|
|
|
|
return 0;
|
|
}
|
|
|
|
/**
|
|
* intel_rcs_context_init_mocs() - program the MOCS register.
|
|
* @req: Request to set up the MOCS tables for.
|
|
*
|
|
* This function will emit a batch buffer with the values required for
|
|
* programming the MOCS register values for all the currently supported
|
|
* rings.
|
|
*
|
|
* These registers are partially stored in the RCS context, so they are
|
|
* emitted at the same time so that when a context is created these registers
|
|
* are set up. These registers have to be emitted into the start of the
|
|
* context as setting the ELSP will re-init some of these registers back
|
|
* to the hw values.
|
|
*
|
|
* Return: 0 on success, otherwise the error status.
|
|
*/
|
|
int intel_rcs_context_init_mocs(struct drm_i915_gem_request *req)
|
|
{
|
|
struct drm_i915_mocs_table t;
|
|
int ret;
|
|
|
|
if (get_mocs_settings(req->ring->dev, &t)) {
|
|
struct drm_i915_private *dev_priv = req->i915;
|
|
struct intel_engine_cs *ring;
|
|
enum intel_ring_id ring_id;
|
|
|
|
/* Program the control registers */
|
|
for_each_ring(ring, dev_priv, ring_id) {
|
|
ret = emit_mocs_control_table(req, &t, ring_id);
|
|
if (ret)
|
|
return ret;
|
|
}
|
|
|
|
/* Now program the l3cc registers */
|
|
ret = emit_mocs_l3cc_table(req, &t);
|
|
if (ret)
|
|
return ret;
|
|
}
|
|
|
|
return 0;
|
|
}
|