Gwendal Grignou 0cd8232c66 HID: intel-ish-hid: Use dma_alloc_coherent for firmware update ... commit f97ec5d75e upstream. Allocating memory with kmalloc and GPF_DMA32 is not allowed, the allocator will ignore the attribute. Instead, use dma_alloc_coherent() API as we allocate a small amount of memory to transfer firmware fragment to the ISH. On Arcada chromebook, after the patch the warning: "Unexpected gfp: 0x4 (GFP_DMA32). Fixing up to gfp: 0xcc0 (GFP_KERNEL). Fix your code!" is gone. The ISH firmware is loaded properly and we can interact with the ISH: > ectool --name cros_ish version ... Build info: arcada_ish_v2.0.3661+3c1a1c1ae0 2022-02-08 05:37:47 @localhost Tool version: v2.0.12300-900b03ec7f 2022-02-08 10:01:48 @localhost Fixes: commit 91b228107d ("HID: intel-ish-hid: ISH firmware loader client driver") Signed-off-by: Gwendal Grignou <gwendal@chromium.org> Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> Cc: stable@vger.kernel.org Signed-off-by: Jiri Kosina <jkosina@suse.cz> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2022-04-08 13:57:17 +02:00
..
ipc	HID: intel-ish-hid: ipc: Specify no cache snooping on TGL and ADL	2022-01-06 15:39:43 +01:00
ishtp	HID: intel-ish-hid: fix module device-id handling	2021-11-11 22:45:40 +01:00
Kconfig	HID: intel-ish-hid: Set ISH driver depends on x86	2021-06-14 15:55:09 +02:00
Makefile	treewide: prefix header search paths with $(srctree)/	2019-05-18 11:49:57 +09:00
ishtp-fw-loader.c	HID: intel-ish-hid: Use dma_alloc_coherent for firmware update	2022-04-08 13:57:17 +02:00
ishtp-hid-client.c	HID: intel-ish-hid: fix module device-id handling	2021-11-11 22:45:40 +01:00
ishtp-hid.c	HID: intel-ish-hid: Fix potential copy/paste error	2021-04-07 17:56:34 +02:00
ishtp-hid.h	HID: intel-ish-hid: use async resume function	2021-07-15 20:49:09 +02:00