mirrors
/
linux-stable
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
1
0
Fork 0
Code Issues Releases Wiki Activity
linux-stable/tools/testing/selftests/net/mptcp
History
Matthieu Baerts d328fe8706 selftests: mptcp: join: avoid using 'cmp --bytes' 
BusyBox's 'cmp' command doesn't support the '--bytes' parameter.

Some CIs -- i.e. LKFT -- use BusyBox and have the mptcp_join.sh test
failing [1] because their 'cmp' command doesn't support this '--bytes'
option:

    cmp: unrecognized option '--bytes=1024'
    BusyBox v1.35.0 () multi-call binary.

    Usage: cmp [-ls] [-n NUM] FILE1 [FILE2]

Instead, 'head --bytes' can be used as this option is supported by
BusyBox. A temporary file is needed for this operation.

Because it is apparently quite common to use BusyBox, it is certainly
better to backport this fix to impacted kernels.

Fixes: 6bf41020b7 ("selftests: mptcp: update and extend fastclose test-cases")
Cc: stable@vger.kernel.org
Link: https://qa-reports.linaro.org/lkft/linux-mainline-master/build/v6.3-rc5-5-g148341f0a2f5/testrun/16088933/suite/kselftest-net-mptcp/test/net_mptcp_userspace_pm_sh/log [1]
Suggested-by: Paolo Abeni <pabeni@redhat.com>
Reviewed-by: Mat Martineau <martineau@kernel.org>
Signed-off-by: Matthieu Baerts <matthieu.baerts@tessares.net>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
 		2023-05-30 13:21:02 +02:00
..
.gitignore selftests: mptcp: add inq test case 2021-12-07 11:36:30 -08:00
Makefile linux-kselftest-next-5.20-rc1 2022-08-02 19:44:56 -07:00
config selftests: mptcp: add infinite map testcase 2022-04-27 10:45:53 +01:00
diag.sh selftest: mptcp: add test for mptcp socket in use 2023-01-09 07:30:50 +00:00
mptcp_connect.c selftests: mptcp: remove duplicated entries in usage 2023-04-17 08:25:33 +01:00
mptcp_connect.sh selftests: mptcp: uniform 'rndh' variable 2022-12-01 20:06:06 -08:00
mptcp_inq.c selftests: mptcp: Initialize variables to quiet gcc 12 warnings 2022-06-28 20:45:43 -07:00
mptcp_join.sh selftests: mptcp: join: avoid using 'cmp --bytes' 2023-05-30 13:21:02 +02:00
mptcp_sockopt.c selftests: mptcp: Initialize variables to quiet gcc 12 warnings 2022-06-28 20:45:43 -07:00
mptcp_sockopt.sh selftests: mptcp: declare var as local 2022-12-01 20:06:06 -08:00
pm_netlink.sh selftests: mptcp: add set_flags tests in pm_netlink.sh 2022-02-04 20:30:24 -08:00
pm_nl_ctl.c selftests: mptcp: update pm_nl_ctl usage header 2022-07-09 12:19:24 +01:00
settings selftests: mptcp: increase timeout to 20 minutes 2022-02-17 19:59:58 -08:00
simult_flows.sh selftests: mptcp: uniform 'rndh' variable 2022-12-01 20:06:06 -08:00
userspace_pm.sh selftests: mptcp: userspace pm: uniform verify events 2023-04-13 09:58:55 -07:00