Dmitry Antipov 4b81d155fe uapi: propagate __struct_group() attributes to the container union ... [ Upstream commit 4e86f32a13 ] Recently the kernel test robot has reported an ARM-specific BUILD_BUG_ON() in an old and unmaintained wil6210 wireless driver. The problem comes from the structure packing rules of old ARM ABI ('-mabi=apcs-gnu'). For example, the following structure is packed to 18 bytes instead of 16: struct poorly_packed { unsigned int a; unsigned int b; unsigned short c; union { struct { unsigned short d; unsigned int e; } __attribute__((packed)); struct { unsigned short d; unsigned int e; } __attribute__((packed)) inner; }; } __attribute__((packed)); To fit it into 16 bytes, it's required to add packed attribute to the container union as well: struct poorly_packed { unsigned int a; unsigned int b; unsigned short c; union { struct { unsigned short d; unsigned int e; } __attribute__((packed)); struct { unsigned short d; unsigned int e; } __attribute__((packed)) inner; } __attribute__((packed)); } __attribute__((packed)); Thanks to Andrew Pinski of GCC team for sorting the things out at https://gcc.gnu.org/pipermail/gcc/2023-November/242888.html. Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202311150821.cI4yciFE-lkp@intel.com Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru> Link: https://lore.kernel.org/r/20231120110607.98956-1-dmantipov@yandex.ru Fixes: 50d7bd38c3 ("stddef: Introduce struct_group() helper macro") Signed-off-by: Kees Cook <keescook@chromium.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2023-12-08 08:52:22 +01:00
..
acpi	ACPI: PM: Add acpi_device_fix_up_power_children() function	2023-12-03 07:33:07 +01:00
asm-generic	hyperv-fixes for v6.6-rc6	2023-10-10 11:01:21 -07:00
clocksource
crypto
drm	drm: bridge: samsung-dsim: Fix waiting for empty cmd transfer FIFO on older Exynos	2023-11-20 11:59:08 +01:00
dt-bindings
keys
kunit
kvm	KVM: arm64: timers: Correctly handle TGE flip with CNTPOFF_EL2	2023-10-12 16:55:21 +01:00
linux	io_uring/kbuf: defer release of mapped buffer rings	2023-12-08 08:52:20 +01:00
math-emu
media	media: ipu-bridge: increase sensor_name size	2023-11-28 17:19:46 +00:00
memory
misc
net	net: sched: do not offload flows with a helper in act_ct	2023-11-28 17:19:54 +00:00
pcmcia
ras
rdma
rv
scsi	scsi: sd: Fix system start for ATA devices	2023-12-08 08:52:17 +01:00
soc	firmware: tegra: Add suspend hook and reset BPMP IPC early on resume	2023-11-20 11:59:16 +01:00
sound	ASoC: soc-dai: add flag to mute and unmute stream during trigger	2023-11-28 17:20:04 +00:00
target
trace	rxrpc: Fix RTT determination to use any ACK as a source	2023-12-03 07:33:02 +01:00
uapi	uapi: propagate __struct_group() attributes to the container union	2023-12-08 08:52:22 +01:00
ufs
vdso
video	fbdev: stifb: Make the STI next font pointer a 32-bit signed offset	2023-11-28 17:19:58 +00:00
xen	arm/xen: remove lazy mode related definitions	2023-09-19 07:04:49 +02:00