Jon Maxwell 95372b040a ipv6: remove max_size check inline with ipv4 ... commit af6d10345c upstream. In ip6_dst_gc() replace: if (entries > gc_thresh) With: if (entries > ops->gc_thresh) Sending Ipv6 packets in a loop via a raw socket triggers an issue where a route is cloned by ip6_rt_cache_alloc() for each packet sent. This quickly consumes the Ipv6 max_size threshold which defaults to 4096 resulting in these warnings: [1] 99.187805] dst_alloc: 7728 callbacks suppressed [2] Route cache is full: consider increasing sysctl net.ipv6.route.max_size. . . [300] Route cache is full: consider increasing sysctl net.ipv6.route.max_size. When this happens the packet is dropped and sendto() gets a network is unreachable error: remaining pkt 200557 errno 101 remaining pkt 196462 errno 101 . . remaining pkt 126821 errno 101 Implement David Aherns suggestion to remove max_size check seeing that Ipv6 has a GC to manage memory usage. Ipv4 already does not check max_size. Here are some memory comparisons for Ipv4 vs Ipv6 with the patch: Test by running 5 instances of a program that sends UDP packets to a raw socket 5000000 times. Compare Ipv4 and Ipv6 performance with a similar program. Ipv4: Before test: MemFree: 29427108 kB Slab: 237612 kB ip6_dst_cache 1912 2528 256 32 2 : tunables 0 0 0 xfrm_dst_cache 0 0 320 25 2 : tunables 0 0 0 ip_dst_cache 2881 3990 192 42 2 : tunables 0 0 0 During test: MemFree: 29417608 kB Slab: 247712 kB ip6_dst_cache 1912 2528 256 32 2 : tunables 0 0 0 xfrm_dst_cache 0 0 320 25 2 : tunables 0 0 0 ip_dst_cache 44394 44394 192 42 2 : tunables 0 0 0 After test: MemFree: 29422308 kB Slab: 238104 kB ip6_dst_cache 1912 2528 256 32 2 : tunables 0 0 0 xfrm_dst_cache 0 0 320 25 2 : tunables 0 0 0 ip_dst_cache 3048 4116 192 42 2 : tunables 0 0 0 Ipv6 with patch: Errno 101 errors are not observed anymore with the patch. Before test: MemFree: 29422308 kB Slab: 238104 kB ip6_dst_cache 1912 2528 256 32 2 : tunables 0 0 0 xfrm_dst_cache 0 0 320 25 2 : tunables 0 0 0 ip_dst_cache 3048 4116 192 42 2 : tunables 0 0 0 During Test: MemFree: 29431516 kB Slab: 240940 kB ip6_dst_cache 11980 12064 256 32 2 : tunables 0 0 0 xfrm_dst_cache 0 0 320 25 2 : tunables 0 0 0 ip_dst_cache 3048 4116 192 42 2 : tunables 0 0 0 After Test: MemFree: 29441816 kB Slab: 238132 kB ip6_dst_cache 1902 2432 256 32 2 : tunables 0 0 0 xfrm_dst_cache 0 0 320 25 2 : tunables 0 0 0 ip_dst_cache 3048 4116 192 42 2 : tunables 0 0 0 Tested-by: Andrea Mayer <andrea.mayer@uniroma2.it> Signed-off-by: Jon Maxwell <jmaxwell37@gmail.com> Reviewed-by: David Ahern <dsahern@kernel.org> Link: https://lore.kernel.org/r/20230112012532.311021-1-jmaxwell37@gmail.com Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Suraj Jitindar Singh <surajjs@amazon.com> Cc: <stable@vger.kernel.org> # 4.19.x Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2024-01-15 18:23:44 +01:00
..
datagram.c	net: datagram: fix data-races in datagram_poll()	2023-05-30 12:42:08 +01:00
dev.c	net: check dev->gso_max_size in gso_features_check()	2024-01-08 11:27:34 +01:00
dev_addr_lists.c
dev_ioctl.c
devlink.c	devlink: Add missing genlmsg_cancel() in devlink_nl_sb_port_pool_fill()	2020-11-24 13:27:16 +01:00
drop_monitor.c	drop_monitor: Require 'CAP_SYS_ADMIN' when joining "events" group	2023-12-13 17:42:20 +01:00
dst.c	ipv6: remove max_size check inline with ipv4	2024-01-15 18:23:44 +01:00
dst_cache.c
ethtool.c	net/ethtool/ioctl: return -EOPNOTSUPP if we have no phy stats	2023-01-24 07:11:49 +01:00
failover.c	failover: allow name change on IFF_UP slave interfaces	2019-04-27 09:36:30 +02:00
fib_notifier.c
fib_rules.c	fib: Return the correct errno code	2021-06-30 08:48:13 -04:00
filter.c	bpf: Always return target ifindex in bpf_fib_lookup	2023-02-22 12:47:19 +01:00
flow_dissector.c	net/sched: flower: fix parsing of ethertype following VLAN header	2022-04-20 09:12:48 +02:00
gen_estimator.c	net_sched: gen_estimator: support large ewma log	2021-02-07 14:48:37 +01:00
gen_stats.c
gro_cells.c
hwbm.c
link_watch.c
lwt_bpf.c	lwt: Disable BH too in run_lwt_bpf()	2020-12-30 11:26:06 +01:00
lwtunnel.c
Makefile
neighbour.c	neighbour: delete neigh_lookup_nodev as not used	2023-06-21 15:39:59 +02:00
net-procfs.c	net-procfs: show net devices bound packet types	2022-02-08 18:23:09 +01:00
net-sysfs.c	net-sysfs: add check for netdevice being present to speed_show	2022-03-16 13:20:27 +01:00
net-sysfs.h
net-traces.c
net_namespace.c	net: fix UaF in netns ops registration error path	2023-02-06 07:49:42 +01:00
netclassid_cgroup.c	cgroup, netclassid: remove double cond_resched	2020-05-10 10:30:12 +02:00
netevent.c
netpoll.c	net: don't let netpoll invoke NAPI if in xmit context	2023-04-20 12:04:38 +02:00
netprio_cgroup.c	netprio_cgroup: Fix unlimited memory leak of v2 cgroups	2020-05-20 08:18:38 +02:00
page_pool.c
pktgen.c	net: pktgen: Fix interface flags printing	2023-10-25 11:16:49 +02:00
ptp_classifier.c
request_sock.c
rtnetlink.c	rtnetlink: Reject negative ifindexes in RTM_NEWLINK	2023-10-10 21:45:02 +02:00
scm.c
secure_seq.c	secure_seq: use the 64 bits of the siphash for port offset calculation	2022-06-06 08:24:20 +02:00
skbuff.c	skbuff: skb_segment, Call zero copy functions before using skbuff frags	2023-09-23 10:48:09 +02:00
sock.c	net: annotate data-races around sk->sk_dst_pending_confirm	2023-11-28 16:46:31 +00:00
sock_diag.c
sock_reuseport.c	udp: Prevent reuseport_select_sock from reading uninitialized socks	2021-01-23 15:49:55 +01:00
stream.c	tcp: reduce POLLOUT events caused by TCP_NOTSENT_LOWAT	2023-05-30 12:42:07 +01:00
sysctl_net_core.c	net: Fix data-races around weight_p and dev_weight_[rt]x_bias.	2022-09-05 10:26:30 +02:00
timestamping.c
tso.c
utils.c	net: Fix skb->csum update in inet_proto_csum_replace16().	2020-02-05 14:43:53 +00:00
xdp.c