Paul Moore d3b990b7f3 netlabel: fix problems with mapping removal ... This patch fixes two main problems seen when removing NetLabel mappings: memory leaks and potentially extra audit noise. The memory leaks are caused by not properly free'ing the mapping's address selector struct when free'ing the entire entry as well as not properly cleaning up a temporary mapping entry when adding new address selectors to an existing entry. This patch fixes both these problems such that kmemleak reports no NetLabel associated leaks after running the SELinux test suite. The potentially extra audit noise was caused by the auditing code in netlbl_domhsh_remove_entry() being called regardless of the entry's validity. If another thread had already marked the entry as invalid, but not removed/free'd it from the list of mappings, then it was possible that an additional mapping removal audit record would be generated. This patch fixes this by returning early from the removal function when the entry was previously marked invalid. This change also had the side benefit of improving the code by decreasing the indentation level of large chunk of code by one (accounting for most of the diffstat). Fixes: 63c4168874 ("netlabel: Add network address selectors to the NetLabel/LSM domain mapping") Reported-by: Stephen Smalley <stephen.smalley.work@gmail.com> Signed-off-by: Paul Moore <paul@paul-moore.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2020-08-24 16:08:00 -07:00
..
6lowpan	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
9p	9p pull request for inclusion in 5.9	2020-08-15 08:34:36 -07:00
802
8021q	net: get rid of lockdep_set_class_and_subclass()	2020-06-28 21:37:23 -07:00
appletalk	appletalk: Fix atalk_proc_init() return path	2020-08-03 15:48:32 -07:00
atm	mm, treewide: rename kzfree() to kfree_sensitive()	2020-08-07 11:33:22 -07:00
ax25	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2020-07-25 17:49:04 -07:00
batman-adv	batman-adv: Introduce a configurable per interface hop penalty	2020-06-26 10:37:11 +02:00
bluetooth	mm, treewide: rename kzfree() to kfree_sensitive()	2020-08-07 11:33:22 -07:00
bpf	bpf: Allow to specify ifindex for skb in bpf_prog_test_run_skb	2020-08-03 23:32:23 +02:00
bpfilter	Merge branch 'exec-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace	2020-08-04 14:27:25 -07:00
bridge	netfilter: ebtables: reject bogus getopt len value	2020-08-14 11:59:08 +02:00
caif	net: pass a sockptr_t into ->setsockopt	2020-07-24 15:41:54 -07:00
can	can: j1939: add rxtimer for multipacket broadcast session	2020-08-15 11:12:58 +02:00
ceph	libceph: replace HTTP links with HTTPS ones	2020-08-03 11:05:26 +02:00
core	Merge git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf	2020-08-21 12:54:50 -07:00
dcb	dcb_doit: remove redundant skb check	2020-06-23 20:27:09 -07:00
dccp	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next	2020-08-05 20:13:21 -07:00
decnet	Merge git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next	2020-08-03 16:03:18 -07:00
dns_resolver
dsa	net: dsa: stop overriding master's ndo_get_phys_port_name	2020-07-23 15:14:58 -07:00
ethernet	net: move devres helpers into a separate source file	2020-05-23 16:56:17 -07:00
ethtool	ethtool: Don't omit the netlink reply if no features were changed	2020-08-18 16:00:24 -07:00
hsr	hsr: Use %pM format specifier for MAC addresses	2020-07-31 16:46:26 -07:00
ieee802154	net: pass a sockptr_t into ->setsockopt	2020-07-24 15:41:54 -07:00
ife
ipv4	net: nexthop: don't allow empty NHA_GROUP	2020-08-22 12:39:55 -07:00
ipv6	gre6: Fix reception with IP6_TNL_F_RCV_DSCP_COPY	2020-08-20 16:28:04 -07:00
iucv	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next	2020-08-05 20:13:21 -07:00
kcm	net: pass a sockptr_t into ->setsockopt	2020-07-24 15:41:54 -07:00
key	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2020-08-02 01:02:12 -07:00
l2tp	l2tp: improve API documentation in l2tp_core.h	2020-07-30 16:45:31 -07:00
l3mdev	l3mdev: add infrastructure for table to VRF mapping	2020-06-20 17:22:22 -07:00
lapb	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
llc	net: pass a sockptr_t into ->setsockopt	2020-07-24 15:41:54 -07:00
mac80211	mm, treewide: rename kzfree() to kfree_sensitive()	2020-08-07 11:33:22 -07:00
mac802154	mm, treewide: rename kzfree() to kfree_sensitive()	2020-08-07 11:33:22 -07:00
mpls	net: Removed the device type check to add mpls support for devices	2020-07-27 11:40:47 -07:00
mptcp	mptcp: sendmsg: reset iter on error redux	2020-08-16 21:11:37 -07:00
ncsi	net/ncsi: use eth_zero_addr() to clear mac address	2020-07-23 11:49:41 -07:00
netfilter	netfilter: nf_tables: fix destination register zeroing	2020-08-21 19:00:33 +02:00
netlabel	netlabel: fix problems with mapping removal	2020-08-24 16:08:00 -07:00
netlink	netlink: fix state reallocation in policy export	2020-08-19 15:39:36 -07:00
netrom	net: pass a sockptr_t into ->setsockopt	2020-07-24 15:41:54 -07:00
nfc	net/nfc/rawsock.c: add CAP_NET_RAW check.	2020-08-11 10:34:30 -07:00
nsh	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
openvswitch	net: openvswitch: introduce common code for flushing flows	2020-08-13 15:53:30 -07:00
packet	af_packet: TPACKET_V3: fix fill status rwlock imbalance	2020-08-13 15:37:30 -07:00
phonet	net: pass a sockptr_t into ->setsockopt	2020-07-24 15:41:54 -07:00
psample	net: psample: fix build error when CONFIG_INET is not enabled	2020-05-23 16:36:05 -07:00
qrtr	net: qrtr: fix usage of idr in port assignment to socket	2020-08-17 15:00:41 -07:00
rds	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2020-08-02 01:02:12 -07:00
rfkill
rose	net: pass a sockptr_t into ->setsockopt	2020-07-24 15:41:54 -07:00
rxrpc	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2020-08-02 01:02:12 -07:00
sched	net/sched: act_ct: Fix skb double-free in tcf_ct_handle_fragments() error flow	2020-08-20 16:39:31 -07:00
sctp	sctp: not disable bh in the whole sctp_get_port_local()	2020-08-24 15:50:17 -07:00
smc	net/smc: Prevent kernel-infoleak in __smc_diag_dump()	2020-08-20 12:07:31 -07:00
strparser
sunrpc	NFS client updates for Linux 5.9	2020-08-15 08:26:55 -07:00
switchdev	net: switchdev: kerneldoc fixes	2020-07-13 17:20:40 -07:00
tipc	tipc: call rcu_read_lock() in tipc_aead_encrypt_done()	2020-08-20 16:42:08 -07:00
tls	net/tls: Fix kmap usage	2020-08-11 10:20:34 -07:00
unix	net: make ->{get,set}sockopt in proto_ops optional	2020-07-19 18:16:41 -07:00
vmw_vsock	vsock: fix potential null pointer dereference in vsock_poll()	2020-08-12 12:56:06 -07:00
wimax
wireless	mm, treewide: rename kzfree() to kfree_sensitive()	2020-08-07 11:33:22 -07:00
x25	net: pass a sockptr_t into ->setsockopt	2020-07-24 15:41:54 -07:00
xdp	xdp: Prevent kernel-infoleak in xsk_getsockopt()	2020-07-28 12:50:15 +02:00
xfrm	A set of locking fixes and updates:	2020-08-10 19:07:44 -07:00
compat.c	net/scm: Fix typo in SCM_RIGHTS compat refactoring	2020-08-07 12:43:25 -07:00
devres.c	net: devres: rename the release callback of devm_register_netdev()	2020-06-30 15:57:34 -07:00
Kconfig	net: ethtool: Remove PHYLIB direct dependency	2020-07-07 15:41:05 -07:00
Makefile	net: move devres helpers into a separate source file	2020-05-23 16:56:17 -07:00
socket.c	net: Revert "net: optimize the sockptr_t for unified kernel/user address spaces"	2020-08-10 12:06:44 -07:00
sysctl_net.c