Ilias Apalodimas d4a714873d efivarfs: force RO when remounting if SetVariable is not supported ... [ Upstream commit 0e8d244416 ] If SetVariable at runtime is not supported by the firmware we never assign a callback for that function. At the same time mount the efivarfs as RO so no one can call that. However, we never check the permission flags when someone remounts the filesystem as RW. As a result this leads to a crash looking like this: $ mount -o remount,rw /sys/firmware/efi/efivars $ efi-updatevar -f PK.auth PK [ 303.279166] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000000 [ 303.280482] Mem abort info: [ 303.280854] ESR = 0x0000000086000004 [ 303.281338] EC = 0x21: IABT (current EL), IL = 32 bits [ 303.282016] SET = 0, FnV = 0 [ 303.282414] EA = 0, S1PTW = 0 [ 303.282821] FSC = 0x04: level 0 translation fault [ 303.283771] user pgtable: 4k pages, 48-bit VAs, pgdp=000000004258c000 [ 303.284913] [0000000000000000] pgd=0000000000000000, p4d=0000000000000000 [ 303.286076] Internal error: Oops: 0000000086000004 [#1] PREEMPT SMP [ 303.286936] Modules linked in: qrtr tpm_tis tpm_tis_core crct10dif_ce arm_smccc_trng rng_core drm fuse ip_tables x_tables ipv6 [ 303.288586] CPU: 1 PID: 755 Comm: efi-updatevar Not tainted 6.3.0-rc1-00108-gc7d0c4695c68 #1 [ 303.289748] Hardware name: Unknown Unknown Product/Unknown Product, BIOS 2023.04-00627-g88336918701d 04/01/2023 [ 303.291150] pstate: 60400005 (nZCv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--) [ 303.292123] pc : 0x0 [ 303.292443] lr : efivar_set_variable_locked+0x74/0xec [ 303.293156] sp : ffff800008673c10 [ 303.293619] x29: ffff800008673c10 x28: ffff0000037e8000 x27: 0000000000000000 [ 303.294592] x26: 0000000000000800 x25: ffff000002467400 x24: 0000000000000027 [ 303.295572] x23: ffffd49ea9832000 x22: ffff0000020c9800 x21: ffff000002467000 [ 303.296566] x20: 0000000000000001 x19: 00000000000007fc x18: 0000000000000000 [ 303.297531] x17: 0000000000000000 x16: 0000000000000000 x15: 0000aaaac807ab54 [ 303.298495] x14: ed37489f673633c0 x13: 71c45c606de13f80 x12: 47464259e219acf4 [ 303.299453] x11: ffff000002af7b01 x10: 0000000000000003 x9 : 0000000000000002 [ 303.300431] x8 : 0000000000000010 x7 : ffffd49ea8973230 x6 : 0000000000a85201 [ 303.301412] x5 : 0000000000000000 x4 : ffff0000020c9800 x3 : 00000000000007fc [ 303.302370] x2 : 0000000000000027 x1 : ffff000002467400 x0 : ffff000002467000 [ 303.303341] Call trace: [ 303.303679] 0x0 [ 303.303938] efivar_entry_set_get_size+0x98/0x16c [ 303.304585] efivarfs_file_write+0xd0/0x1a4 [ 303.305148] vfs_write+0xc4/0x2e4 [ 303.305601] ksys_write+0x70/0x104 [ 303.306073] __arm64_sys_write+0x1c/0x28 [ 303.306622] invoke_syscall+0x48/0x114 [ 303.307156] el0_svc_common.constprop.0+0x44/0xec [ 303.307803] do_el0_svc+0x38/0x98 [ 303.308268] el0_svc+0x2c/0x84 [ 303.308702] el0t_64_sync_handler+0xf4/0x120 [ 303.309293] el0t_64_sync+0x190/0x194 [ 303.309794] Code: ???????? ???????? ???????? ???????? (????????) [ 303.310612] ---[ end trace 0000000000000000 ]--- Fix this by adding a .reconfigure() function to the fs operations which we can use to check the requested flags and deny anything that's not RO if the firmware doesn't implement SetVariable at runtime. Fixes: f88814cc25 ("efi/efivars: Expose RT service availability via efivars abstraction") Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org> Signed-off-by: Ard Biesheuvel <ardb@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2024-01-25 15:44:39 -08:00
..
9p	Bunch of small fixes:	2023-11-04 09:20:04 -10:00
adfs	adfs: convert to new timestamp accessors	2023-10-18 13:26:18 +02:00
affs	vfs-6.7.fsid	2023-11-07 12:11:26 -08:00
afs	afs: Fix use-after-free due to get/remove race in volume tree	2023-12-21 10:16:07 -08:00
autofs	autofs: add: new_inode check in autofs_fill_super()	2023-11-20 14:56:36 +01:00
bcachefs	bcachefs: make RO snapshots actually RO	2024-01-01 11:47:07 -05:00
befs	vfs-6.7.fsid	2023-11-07 12:11:26 -08:00
bfs	bfs: convert to new timestamp accessors	2023-10-18 13:26:19 +02:00
btrfs	for-6.7-rc5-tag	2023-12-17 09:27:36 -08:00
cachefiles	- Some swap cleanups from Ma Wupeng ("fix WARN_ON in add_to_avail_list")	2023-08-29 14:25:26 -07:00
ceph	Two items:	2023-11-10 09:52:56 -08:00
coda	coda: convert to new timestamp accessors	2023-10-18 13:26:19 +02:00
configfs	configfs: convert to new timestamp accessors	2023-10-18 13:26:19 +02:00
cramfs	vfs-6.7.ctime	2023-10-30 09:47:13 -10:00
crypto	This update includes the following changes:	2023-11-02 16:15:30 -10:00
debugfs	debugfs: initialize cancellations earlier	2023-12-22 07:33:02 +01:00
devpts	devpts: convert to new timestamp accessors	2023-10-18 13:26:20 +02:00
dlm	dlm: slow down filling up processing queue	2023-10-12 15:21:00 -05:00
ecryptfs	fs: Pass AT_GETATTR_NOSEC flag to getattr interface function	2023-11-18 14:54:07 +01:00
efivarfs	efivarfs: force RO when remounting if SetVariable is not supported	2024-01-25 15:44:39 -08:00
efs	vfs-6.7.fsid	2023-11-07 12:11:26 -08:00
erofs	MAINTAINERS: erofs: add EROFS webpage	2023-11-17 19:55:46 +08:00
exfat	exfat: fix ctime is not updated	2023-11-03 22:24:11 +09:00
exportfs	fs: fix build error with CONFIG_EXPORTFS=m or not defined	2023-10-28 16:16:19 +02:00
ext2	ext2: Fix ki_pos update for DIO buffered-io fallback case	2023-11-22 10:17:10 +01:00
ext4	ext4: fix warning in ext4_dio_write_end_io()	2023-11-30 23:29:34 -05:00
f2fs	f2fs: explicitly null-terminate the xattr list	2024-01-20 11:53:00 +01:00
fat	vfs-6.7.fsid	2023-11-07 12:11:26 -08:00
freevxfs	vfs-6.7.fsid	2023-11-07 12:11:26 -08:00
fscache
fuse	fuse: disable FOPEN_PARALLEL_DIRECT_WRITES with FUSE_DIRECT_IO_ALLOW_MMAP	2023-12-04 10:19:32 +01:00
gfs2	gfs2 fixes	2023-11-07 11:54:17 -08:00
hfs	vfs-6.7.ctime	2023-10-30 09:47:13 -10:00
hfsplus	vfs-6.7.ctime	2023-10-30 09:47:13 -10:00
hostfs	hostfs: convert to new timestamp accessors	2023-10-18 14:08:22 +02:00
hpfs	hpfs: convert to new timestamp accessors	2023-10-18 14:08:22 +02:00
hugetlbfs	vfs-6.7.fsid	2023-11-07 12:11:26 -08:00
iomap	Many singleton patches against the MM code. The patch series which are	2023-11-02 19:38:47 -10:00
isofs	isofs: convert to new timestamp accessors	2023-10-18 14:08:22 +02:00
jbd2	jbd2: fix soft lockup in journal_finish_inode_data_buffers()	2023-12-12 10:25:46 -05:00
jffs2	vfs-6.7.fsid	2023-11-07 12:11:26 -08:00
jfs	vfs-6.7.fsid	2023-11-07 12:11:26 -08:00
kernfs	Driver core changes for 6.7-rc1	2023-11-03 15:15:47 -10:00
lockd	SUNRPC: change how svc threads are asked to exit.	2023-10-16 12:44:04 -04:00
minix	minix: convert to new timestamp accessors	2023-10-18 14:08:23 +02:00
netfs	netfs: Only call folio_start_fscache() one time for each folio	2023-09-18 12:03:46 -07:00
nfs	NFS client updates for Linux 6.7	2023-11-08 13:39:16 -08:00
nfs_common	NFSv4.2: remove MODULE_LICENSE in non-modules	2023-04-13 13:13:52 -07:00
nfsd	nfsd-6.7 fixes:	2024-01-05 13:12:29 -08:00
nilfs2	nilfs2: prevent WARNING in nilfs_sufile_set_segment_usage()	2023-12-06 16:12:50 -08:00
nls	nls: Hide new NLS_UCS2_UTILS	2023-08-31 12:07:34 -05:00
notify	vfs-6.7.fsid	2023-11-07 12:11:26 -08:00
ntfs	vfs-6.7.fsid	2023-11-07 12:11:26 -08:00
ntfs3	vfs-6.7.fsid	2023-11-07 12:11:26 -08:00
ocfs2	As usual, lots of singleton and doubleton patches all over the tree and	2023-11-02 20:53:31 -10:00
omfs	omfs: convert to new timestamp accessors	2023-10-18 14:08:25 +02:00
openpromfs	openpromfs: convert to new timestamp accessors	2023-10-18 14:08:25 +02:00
orangefs	vfs-6.7.ctime	2023-10-30 09:47:13 -10:00
overlayfs	overlayfs fixes for 6.7-rc7	2023-12-20 12:04:03 -08:00
proc	mm/pagemap: fix wr-protect even if PM_SCAN_WP_MATCHING not set	2023-12-06 16:12:45 -08:00
pstore	pstore updates for v6.7-rc1	2023-10-30 19:26:39 -10:00
qnx4	qnx4: convert to new timestamp accessors	2023-10-18 14:08:26 +02:00
qnx6	qnx6: convert to new timestamp accessors	2023-10-18 14:08:26 +02:00
quota	Many singleton patches against the MM code. The patch series which are	2023-11-02 19:38:47 -10:00
ramfs	ramfs: convert to new timestamp accessors	2023-10-18 14:08:26 +02:00
reiserfs	Many singleton patches against the MM code. The patch series which are	2023-11-02 19:38:47 -10:00
romfs	vfs-6.7.ctime	2023-10-30 09:47:13 -10:00
smb	ksmbd: free ppace array on error in parse_dacl	2024-01-20 11:53:01 +01:00
squashfs	squashfs: squashfs_read_data need to check if the length is 0	2023-12-06 16:12:45 -08:00
sysfs	kernfs: sysfs: support custom llseek method for sysfs entries	2023-10-05 13:42:11 +02:00
sysv	sysv: convert to new timestamp accessors	2023-10-18 14:08:28 +02:00
tracefs	eventfs: Fix bitwise fields for "is_events"	2024-01-02 15:20:44 -05:00
ubifs	This pull request contains updates for UBI and UBIFS	2023-11-05 08:28:32 -10:00
udf	\n	2023-11-02 08:19:51 -10:00
ufs	fix ufs_get_locked_folio() breakage	2023-12-13 11:14:09 -05:00
unicode	unicode: remove MODULE_LICENSE in non-modules	2023-04-13 13:13:54 -07:00
vboxsf	vboxsf: convert to new timestamp accessors	2023-10-18 14:08:29 +02:00
verity	fsverity: skip PKCS#7 parser when keyring is empty	2023-08-20 10:33:43 -07:00
xfs	Code changes for 6.7-rc2:	2023-11-25 08:57:09 -08:00
zonefs	zonefs: convert to new timestamp accessors	2023-10-18 14:08:29 +02:00
aio.c	aio: Annotate struct kioctx_table with __counted_by	2023-09-20 14:22:01 +02:00
anon_inodes.c	treewide: mark stuff as __ro_after_init	2023-10-18 14:43:23 -07:00
attr.c	fs: convert core infrastructure to new timestamp accessors	2023-10-18 13:26:15 +02:00
bad_inode.c	fs: convert core infrastructure to new timestamp accessors	2023-10-18 13:26:15 +02:00
binfmt_elf.c	binfmt_elf: Only report padzero() errors when PROT_WRITE	2023-10-03 19:48:44 -07:00
binfmt_elf_fdpic.c	execve updates for v6.7-rc1	2023-10-30 19:28:19 -10:00
binfmt_elf_test.c
binfmt_flat.c
binfmt_misc.c	execve updates for v6.7-rc1	2023-10-30 19:28:19 -10:00
binfmt_script.c
buffer.c	As usual, lots of singleton and doubleton patches all over the tree and	2023-11-02 20:53:31 -10:00
char_dev.c	As usual, lots of singleton and doubleton patches all over the tree and	2023-11-02 20:53:31 -10:00
compat_binfmt_elf.c
coredump.c	v6.5/vfs.misc	2023-06-26 09:50:21 -07:00
d_path.c	fs: d_path: include internal.h	2023-05-17 09:16:59 +02:00
dax.c	mm: convert DAX lock/unlock page to lock/unlock folio	2023-10-04 10:32:20 -07:00
dcache.c	As usual, lots of singleton and doubleton patches all over the tree and	2023-11-02 20:53:31 -10:00
direct-io.c	treewide: mark stuff as __ro_after_init	2023-10-18 14:43:23 -07:00
drop_caches.c	fs: drop_caches: draining pages before dropping caches	2023-08-18 10:12:11 -07:00
eventfd.c	eventfd: prevent underflow for eventfd semaphores	2023-07-11 11:41:34 +02:00
eventpoll.c	treewide: mark stuff as __ro_after_init	2023-10-18 14:43:23 -07:00
exec.c	mm/mremap: allow moves within the same VMA for stack moves	2023-10-04 10:32:20 -07:00
fcntl.c	treewide: mark stuff as __ro_after_init	2023-10-18 14:43:23 -07:00
fhandle.c	exportfs: add helpers to check if filesystem can encode/decode file handles	2023-10-24 17:57:45 +02:00
file.c	file, i915: fix file reference for mmap_singleton()	2023-10-25 22:17:04 +02:00
file_table.c	As usual, lots of singleton and doubleton patches all over the tree and	2023-11-02 20:53:31 -10:00
filesystems.c
fs-writeback.c	vfs-6.7.misc	2023-10-30 09:14:19 -10:00
fs_context.c	fs: factor out vfs_parse_monolithic_sep() helper	2023-10-12 18:53:36 +03:00
fs_parser.c
fs_pin.c
fs_struct.c	kill do_each_thread()	2023-08-21 13:46:25 -07:00
fs_types.c
fsopen.c	fsconfig: ensure that dirfd is set to aux	2023-09-22 14:09:06 +02:00
init.c	fs: add a new SB_I_NOUMASK flag	2023-10-19 11:02:47 +02:00
inode.c	filemap: add a per-mapping stable writes flag	2023-11-20 15:05:18 +01:00
internal.h	fs: store real path instead of fake path in backing file f_path	2023-10-19 11:03:15 +02:00
ioctl.c	v6.6-vfs.super	2023-08-28 11:04:18 -07:00
Kconfig	mm/hugetlb: have CONFIG_HUGETLB_PAGE select CONFIG_XARRAY_MULTI	2023-12-06 16:12:49 -08:00
Kconfig.binfmt	riscv: support the elf-fdpic binfmt loader	2023-08-23 14:17:43 -07:00
kernel_read_file.c	fs: Fix kernel-doc warnings	2023-08-19 12:12:12 +02:00
libfs.c	libfs: getdents() should return 0 after reaching EOD	2023-11-20 15:34:22 +01:00
locks.c	As usual, lots of singleton and doubleton patches all over the tree and	2023-11-02 20:53:31 -10:00
Makefile	bcachefs: Initial commit	2023-10-22 17:08:07 -04:00
mbcache.c	mbcache: dynamically allocate the mbcache shrinker	2023-10-04 10:32:25 -07:00
mnt_idmapping.c	fs: export mnt_idmap_get/mnt_idmap_put	2023-11-03 23:28:33 +01:00
mount.h
mpage.c	buffer: remove folio_create_empty_buffers()	2023-10-25 16:47:10 -07:00
namei.c	vfs-6.7.misc	2023-10-30 09:14:19 -10:00
namespace.c	As usual, lots of singleton and doubleton patches all over the tree and	2023-11-02 20:53:31 -10:00
nsfs.c	fs: convert core infrastructure to new timestamp accessors	2023-10-18 13:26:15 +02:00
open.c	cred: get rid of CONFIG_DEBUG_CREDENTIALS	2023-12-15 14:19:48 -08:00
pipe.c	fs/pipe: Fix lockdep false-positive in watchqueue pipe_write()	2024-01-25 15:44:37 -08:00
pnode.c	fs: allow to mount beneath top mount	2023-05-19 04:30:22 +02:00
pnode.h	fs: allow to mount beneath top mount	2023-05-19 04:30:22 +02:00
posix_acl.c	fs: convert to ctime accessor functions	2023-07-13 10:28:04 +02:00
proc_namespace.c	tty, proc, kernfs, random: Use copy_splice_read()	2023-05-24 08:42:16 -06:00
read_write.c	fs: Fix one kernel-doc comment	2023-08-15 08:32:45 +02:00
readdir.c	vfs: get rid of old '->iterate' directory operation	2023-08-06 15:08:35 +02:00
remap_range.c	fs: use UB-safe check for signed addition overflow in remap_verify_area	2023-05-24 11:03:59 +02:00
select.c
seq_file.c
signalfd.c
splice.c	- Some swap cleanups from Ma Wupeng ("fix WARN_ON in add_to_avail_list")	2023-08-29 14:25:26 -07:00
stack.c	fs: convert core infrastructure to new timestamp accessors	2023-10-18 13:26:15 +02:00
stat.c	fs: Pass AT_GETATTR_NOSEC flag to getattr interface function	2023-11-18 14:54:07 +01:00
statfs.c	statfs: enforce statfs[64] structure initialization	2023-05-17 15:20:17 +02:00
super.c	overlayfs update for 6.7-rc1	2023-11-07 11:46:31 -08:00
sync.c
sysctls.c	sysctl: Refactor base paths registrations	2023-05-23 21:43:26 -07:00
timerfd.c
userfaultfd.c	As usual, lots of singleton and doubleton patches all over the tree and	2023-11-02 20:53:31 -10:00
utimes.c
xattr.c	xattr: make the xattr array itself const	2023-10-09 16:24:16 +02:00