mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-29 05:44:11 +00:00
7ebf22461c
commit62c07983be
upstream. Christophe Leroy reported a ~80ms latency spike happening at first TCP connect() time. This is because __inet_hash_connect() uses get_random_once() to populate a perturbation table which became quite big after commit4c2c8f03a5
("tcp: increase source port perturb table to 2^16") get_random_once() uses DO_ONCE(), which block hard irqs for the duration of the operation. This patch adds DO_ONCE_SLOW() which uses a mutex instead of a spinlock for operations where we prefer to stay in process context. Then __inet_hash_connect() can use get_random_slow_once() to populate its perturbation table. Fixes:4c2c8f03a5
("tcp: increase source port perturb table to 2^16") Fixes:190cc82489
("tcp: change source port randomizarion at connect() time") Reported-by: Christophe Leroy <christophe.leroy@csgroup.eu> Link: https://lore.kernel.org/netdev/CANn89iLAEYBaoYajy0Y9UmGFff5GPxDUoG-ErVB2jDdRNQ5Tug@mail.gmail.com/T/#t Signed-off-by: Eric Dumazet <edumazet@google.com> Cc: Willy Tarreau <w@1wt.eu> Tested-by: Christophe Leroy <christophe.leroy@csgroup.eu> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Sasha Levin <sashal@kernel.org> Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
88 lines
2.7 KiB
C
88 lines
2.7 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
#ifndef _LINUX_ONCE_H
|
|
#define _LINUX_ONCE_H
|
|
|
|
#include <linux/types.h>
|
|
#include <linux/jump_label.h>
|
|
|
|
/* Helpers used from arbitrary contexts.
|
|
* Hard irqs are blocked, be cautious.
|
|
*/
|
|
bool __do_once_start(bool *done, unsigned long *flags);
|
|
void __do_once_done(bool *done, struct static_key *once_key,
|
|
unsigned long *flags);
|
|
|
|
/* Variant for process contexts only. */
|
|
bool __do_once_slow_start(bool *done);
|
|
void __do_once_slow_done(bool *done, struct static_key *once_key,
|
|
struct module *mod);
|
|
|
|
/* Call a function exactly once. The idea of DO_ONCE() is to perform
|
|
* a function call such as initialization of random seeds, etc, only
|
|
* once, where DO_ONCE() can live in the fast-path. After @func has
|
|
* been called with the passed arguments, the static key will patch
|
|
* out the condition into a nop. DO_ONCE() guarantees type safety of
|
|
* arguments!
|
|
*
|
|
* Not that the following is not equivalent ...
|
|
*
|
|
* DO_ONCE(func, arg);
|
|
* DO_ONCE(func, arg);
|
|
*
|
|
* ... to this version:
|
|
*
|
|
* void foo(void)
|
|
* {
|
|
* DO_ONCE(func, arg);
|
|
* }
|
|
*
|
|
* foo();
|
|
* foo();
|
|
*
|
|
* In case the one-time invocation could be triggered from multiple
|
|
* places, then a common helper function must be defined, so that only
|
|
* a single static key will be placed there!
|
|
*/
|
|
#define DO_ONCE(func, ...) \
|
|
({ \
|
|
bool ___ret = false; \
|
|
static bool ___done = false; \
|
|
static struct static_key ___once_key = STATIC_KEY_INIT_TRUE; \
|
|
if (static_key_true(&___once_key)) { \
|
|
unsigned long ___flags; \
|
|
___ret = __do_once_start(&___done, &___flags); \
|
|
if (unlikely(___ret)) { \
|
|
func(__VA_ARGS__); \
|
|
__do_once_done(&___done, &___once_key, \
|
|
&___flags); \
|
|
} \
|
|
} \
|
|
___ret; \
|
|
})
|
|
|
|
/* Variant of DO_ONCE() for process/sleepable contexts. */
|
|
#define DO_ONCE_SLOW(func, ...) \
|
|
({ \
|
|
bool ___ret = false; \
|
|
static bool ___done = false; \
|
|
static struct static_key ___once_key = STATIC_KEY_INIT_TRUE; \
|
|
if (static_key_true(&___once_key)) { \
|
|
___ret = __do_once_slow_start(&___done); \
|
|
if (unlikely(___ret)) { \
|
|
func(__VA_ARGS__); \
|
|
__do_once_slow_done(&___done, &___once_key, \
|
|
THIS_MODULE); \
|
|
} \
|
|
} \
|
|
___ret; \
|
|
})
|
|
|
|
#define get_random_once(buf, nbytes) \
|
|
DO_ONCE(get_random_bytes, (buf), (nbytes))
|
|
#define get_random_once_wait(buf, nbytes) \
|
|
DO_ONCE(get_random_bytes_wait, (buf), (nbytes)) \
|
|
|
|
#define get_random_slow_once(buf, nbytes) \
|
|
DO_ONCE_SLOW(get_random_bytes, (buf), (nbytes))
|
|
|
|
#endif /* _LINUX_ONCE_H */
|