Hangyu Hua a41b17ff9d dccp: put dccp_qpolicy_full() and dccp_qpolicy_push() in the same lock ... In the case of sk->dccps_qpolicy == DCCPQ_POLICY_PRIO, dccp_qpolicy_full will drop a skb when qpolicy is full. And the lock in dccp_sendmsg is released before sock_alloc_send_skb and then relocked after sock_alloc_send_skb. The following conditions may lead dccp_qpolicy_push to add skb to an already full sk_write_queue: thread1--->lock thread1--->dccp_qpolicy_full: queue is full. drop a skb thread1--->unlock thread2--->lock thread2--->dccp_qpolicy_full: queue is not full. no need to drop. thread2--->unlock thread1--->lock thread1--->dccp_qpolicy_push: add a skb. queue is full. thread1--->unlock thread2--->lock thread2--->dccp_qpolicy_push: add a skb! thread2--->unlock Fix this by moving dccp_qpolicy_full. Fixes: b1308dc015 ("[DCCP]: Set TX Queue Length Bounds via Sysctl") Signed-off-by: Hangyu Hua <hbh25y@gmail.com> Link: https://lore.kernel.org/r/20220729110027.40569-1-hbh25y@gmail.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>		2022-08-01 12:11:56 -07:00
..
ccids	dccp: tfrc: fix doc warnings in tfrc_equation.c	2021-06-10 14:08:49 -07:00
ackvec.c	net: dccp: Fix most of the kerneldoc warnings	2020-10-30 12:08:54 -07:00
ackvec.h
ccid.c	net: dccp: Add __printf() markup to fix -Wsuggest-attribute=format	2020-10-30 11:31:46 -07:00
ccid.h	net: dccp: Replace zero-length array with flexible-array member	2020-02-28 12:08:37 -08:00
dccp.h	net: remove noblock parameter from recvmsg() entities	2022-04-12 15:00:25 +02:00
diag.c	inet_diag: Move the INET_DIAG_REQ_BYTECODE nlattr to cb->data	2020-02-27 18:50:19 -08:00
feat.c	dccp: Return the correct errno code	2021-02-06 11:15:28 -08:00
feat.h
input.c	net: dccp: Convert to use the preferred fallthrough macro	2020-08-22 12:38:34 -07:00
ipv4.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2022-05-19 11:23:59 -07:00
ipv6.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2022-05-19 11:23:59 -07:00
ipv6.h
Kconfig	dccp: Replace HTTP links with HTTPS ones	2020-07-13 11:54:07 -07:00
Makefile
minisocks.c	tcp: allocate tcp_death_row outside of struct netns_ipv4	2022-01-26 19:00:31 -08:00
options.c	net: dccp: Convert to use the preferred fallthrough macro	2020-08-22 12:38:34 -07:00
output.c	net: dccp: Fix most of the kerneldoc warnings	2020-10-30 12:08:54 -07:00
proto.c	dccp: put dccp_qpolicy_full() and dccp_qpolicy_push() in the same lock	2022-08-01 12:11:56 -07:00
qpolicy.c	net: dccp: Fix most of the kerneldoc warnings	2020-10-30 12:08:54 -07:00
sysctl.c
timer.c	net: sock: introduce sk_error_report	2021-06-29 11:28:21 -07:00
trace.h	net: dccp: Use memset_startat() for TP zeroing	2021-11-19 11:22:49 +00:00