mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-28 23:24:50 +00:00
bf7660dab3
There is a mix of drivers using either 'depends on HID' or 'select HID',
which causes both circular dependencies and missed dependencies for
a 'select':
WARNING: unment direct dependencies for HID
Depends on [m]: HID_SUPPORT [=y] && INPUT [=m]
Selected by [y]:
- AMD_SFH_HID [=y] && HID_SUPPORT [=y] && (X86_64 || COMPILE_TEST [=y]) && PCI [=y]
Selected by [m]:
- I2C_HID_CORE [=m] && HID_SUPPORT [=y]
WARNING: unmet direct dependencies detected for INPUT_FF_MEMLESS
Depends on [m]: INPUT [=m]
Selected by [y]:
- DRAGONRISE_FF [=y] && HID_SUPPORT [=y] && HID [=y] && HID_DRAGONRISE [=y]
- HID_MICROSOFT [=y] && HID_SUPPORT [=y] && HID [=y]
- GREENASIA_FF [=y] && HID_SUPPORT [=y] && HID [=y] && HID_GREENASIA [=y]
Selected by [m]:
- INPUT_ARIZONA_HAPTICS [=m] && INPUT [=m] && INPUT_MISC [=y] && MFD_ARIZONA [=y] && SND_SOC [=m]
- INPUT_PM8XXX_VIBRATOR [=m] && INPUT [=m] && INPUT_MISC [=y] && (MFD_PM8XXX [=m] || MFD_SPMI_PMIC [=n])
- INPUT_MAX8997_HAPTIC [=m] && INPUT [=m] && INPUT_MISC [=y] && PWM [=y] && MFD_MAX8997 [=y]
- INPUT_GPIO_VIBRA [=m] && INPUT [=m] && INPUT_MISC [=y] && (GPIOLIB [=y] || COMPILE_TEST [=y])
- INPUT_REGULATOR_HAPTIC [=m] && INPUT [=m] && INPUT_MISC [=y] && REGULATOR [=y]
- INPUT_TWL6040_VIBRA [=m] && INPUT [=m] && INPUT_MISC [=y] && TWL6040_CORE [=y]
- INPUT_PWM_VIBRA [=m] && INPUT [=m] && INPUT_MISC [=y] && PWM [=y]
- INPUT_DRV260X_HAPTICS [=m] && INPUT_MISC [=y] && INPUT [=m] && I2C [=y] && (GPIOLIB [=y] || COMPILE_TEST [=y])
- INPUT_DRV2665_HAPTICS [=m] && INPUT_MISC [=y] && INPUT [=m] && I2C [=y]
- INPUT_DRV2667_HAPTICS [=m] && INPUT_MISC [=y] && INPUT [=m] && I2C [=y]
- INPUT_SC27XX_VIBRA [=m] && INPUT [=m] && INPUT_MISC [=y] && (MFD_SC27XX_PMIC [=y] || COMPILE_TEST [=y])
- HID_MAYFLASH [=m] && HID_SUPPORT [=y] && HID [=y]
Avoid this by changing all HID client drivers to use 'depends on HID'.
For I2C_HID, this requires a larger rework of the Kconfig description,
but it hopefully becomes easier to understand without the complex
I2C_HID_CORE definition.
Fixes: 25621bcc89 ("HID: Kconfig: split HID support and hid-core compilation")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
34 lines
1.2 KiB
Text
34 lines
1.2 KiB
Text
# SPDX-License-Identifier: GPL-2.0-only
|
|
menu "Intel ISH HID support"
|
|
depends on (X86_64 || COMPILE_TEST) && PCI
|
|
|
|
config INTEL_ISH_HID
|
|
tristate "Intel Integrated Sensor Hub"
|
|
default n
|
|
depends on X86
|
|
depends on HID
|
|
help
|
|
The Integrated Sensor Hub (ISH) enables the ability to offload
|
|
sensor polling and algorithm processing to a dedicated low power
|
|
processor in the chipset. This allows the core processor to go into
|
|
low power modes more often, resulting in the increased battery life.
|
|
The current processors that support ISH are: Cherrytrail, Skylake,
|
|
Broxton and Kaby Lake.
|
|
|
|
Say Y here if you want to support Intel ISH. If unsure, say N.
|
|
|
|
config INTEL_ISH_FIRMWARE_DOWNLOADER
|
|
tristate "Host Firmware Load feature for Intel ISH"
|
|
depends on INTEL_ISH_HID
|
|
depends on X86
|
|
help
|
|
The Integrated Sensor Hub (ISH) enables the kernel to offload
|
|
sensor polling and algorithm processing to a dedicated low power
|
|
processor in the chipset.
|
|
|
|
The Host Firmware Load feature adds support to load the ISH
|
|
firmware from host file system at boot.
|
|
|
|
Say M here if you want to support Host Firmware Loading feature
|
|
for Intel ISH. If unsure, say N.
|
|
endmenu
|