mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-24 09:50:04 +00:00
f74d4b8b97
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Link: https://lore.kernel.org/r/20230303172041.2103336-18-u.kleine-koenig@pengutronix.de Signed-off-by: Mark Brown <broonie@kernel.org>
100 lines
2.4 KiB
C
100 lines
2.4 KiB
C
/*
|
|
* This file is subject to the terms and conditions of the GNU General Public
|
|
* License. See the file "COPYING" in the main directory of this archive
|
|
* for more details.
|
|
*
|
|
* Copyright (C) 2011, 2012 Cavium, Inc.
|
|
*/
|
|
|
|
#include <linux/platform_device.h>
|
|
#include <linux/spi/spi.h>
|
|
#include <linux/module.h>
|
|
#include <linux/io.h>
|
|
#include <linux/of.h>
|
|
|
|
#include <asm/octeon/octeon.h>
|
|
|
|
#include "spi-cavium.h"
|
|
|
|
static int octeon_spi_probe(struct platform_device *pdev)
|
|
{
|
|
void __iomem *reg_base;
|
|
struct spi_master *master;
|
|
struct octeon_spi *p;
|
|
int err = -ENOENT;
|
|
|
|
master = spi_alloc_master(&pdev->dev, sizeof(struct octeon_spi));
|
|
if (!master)
|
|
return -ENOMEM;
|
|
p = spi_master_get_devdata(master);
|
|
platform_set_drvdata(pdev, master);
|
|
|
|
reg_base = devm_platform_ioremap_resource(pdev, 0);
|
|
if (IS_ERR(reg_base)) {
|
|
err = PTR_ERR(reg_base);
|
|
goto fail;
|
|
}
|
|
|
|
p->register_base = reg_base;
|
|
p->sys_freq = octeon_get_io_clock_rate();
|
|
|
|
p->regs.config = 0;
|
|
p->regs.status = 0x08;
|
|
p->regs.tx = 0x10;
|
|
p->regs.data = 0x80;
|
|
|
|
master->num_chipselect = 4;
|
|
master->mode_bits = SPI_CPHA |
|
|
SPI_CPOL |
|
|
SPI_CS_HIGH |
|
|
SPI_LSB_FIRST |
|
|
SPI_3WIRE;
|
|
|
|
master->transfer_one_message = octeon_spi_transfer_one_message;
|
|
master->bits_per_word_mask = SPI_BPW_MASK(8);
|
|
master->max_speed_hz = OCTEON_SPI_MAX_CLOCK_HZ;
|
|
|
|
master->dev.of_node = pdev->dev.of_node;
|
|
err = devm_spi_register_master(&pdev->dev, master);
|
|
if (err) {
|
|
dev_err(&pdev->dev, "register master failed: %d\n", err);
|
|
goto fail;
|
|
}
|
|
|
|
dev_info(&pdev->dev, "OCTEON SPI bus driver\n");
|
|
|
|
return 0;
|
|
fail:
|
|
spi_master_put(master);
|
|
return err;
|
|
}
|
|
|
|
static void octeon_spi_remove(struct platform_device *pdev)
|
|
{
|
|
struct spi_master *master = platform_get_drvdata(pdev);
|
|
struct octeon_spi *p = spi_master_get_devdata(master);
|
|
|
|
/* Clear the CSENA* and put everything in a known state. */
|
|
writeq(0, p->register_base + OCTEON_SPI_CFG(p));
|
|
}
|
|
|
|
static const struct of_device_id octeon_spi_match[] = {
|
|
{ .compatible = "cavium,octeon-3010-spi", },
|
|
{},
|
|
};
|
|
MODULE_DEVICE_TABLE(of, octeon_spi_match);
|
|
|
|
static struct platform_driver octeon_spi_driver = {
|
|
.driver = {
|
|
.name = "spi-octeon",
|
|
.of_match_table = octeon_spi_match,
|
|
},
|
|
.probe = octeon_spi_probe,
|
|
.remove_new = octeon_spi_remove,
|
|
};
|
|
|
|
module_platform_driver(octeon_spi_driver);
|
|
|
|
MODULE_DESCRIPTION("Cavium, Inc. OCTEON SPI bus driver");
|
|
MODULE_AUTHOR("David Daney");
|
|
MODULE_LICENSE("GPL");
|