Toke Høiland-Jørgensen 7a4b21250b bpf: Fix stackmap overflow check on 32-bit arches ... The stackmap code relies on roundup_pow_of_two() to compute the number of hash buckets, and contains an overflow check by checking if the resulting value is 0. However, on 32-bit arches, the roundup code itself can overflow by doing a 32-bit left-shift of an unsigned long value, which is undefined behaviour, so it is not guaranteed to truncate neatly. This was triggered by syzbot on the DEVMAP_HASH type, which contains the same check, copied from the hashtab code. The commit in the fixes tag actually attempted to fix this, but the fix did not account for the UB, so the fix only works on CPUs where an overflow does result in a neat truncation to zero, which is not guaranteed. Checking the value before rounding does not have this problem. Fixes: 6183f4d3a0 ("bpf: Check for integer overflow when using roundup_pow_of_two()") Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com> Reviewed-by: Bui Quang Minh <minhquangbui99@gmail.com> Message-ID: <20240307120340.99577-4-toke@redhat.com> Signed-off-by: Alexei Starovoitov <ast@kernel.org>		2024-03-07 20:06:25 -08:00
..
preload	bpf: make preloaded map iterators to display map elements count	2023-07-06 12:42:25 -07:00
arraymap.c	bpf: Consistently use BPF token throughout BPF verifier logic	2024-01-24 16:21:01 -08:00
bloom_filter.c	bpf: Centralize permissions checks for all BPF map types	2023-06-19 14:04:04 +02:00
bpf_cgrp_storage.c	bpf: Enable bpf_cgrp_storage for cgroup1 non-attach case	2023-12-08 17:08:18 -08:00
bpf_inode_storage.c	Networking changes for 6.4.	2023-04-26 16:07:23 -07:00
bpf_iter.c	bpf: Add __bpf_kfunc_{start,end}_defs macros	2023-11-01 22:33:53 -07:00
bpf_local_storage.c	bpf: Allow compiler to inline most of bpf_local_storage_lookup()	2024-02-11 14:06:24 -08:00
bpf_lru_list.c	bpf: Address KCSAN report on bpf_lru_list	2023-05-12 12:01:03 -07:00
bpf_lru_list.h	bpf: lru: Remove unused declaration bpf_lru_promote()	2023-08-08 17:21:42 -07:00
bpf_lsm.c	bpf: Minor clean-up to sleepable_lsm_hooks BTF set	2024-02-01 18:37:45 +01:00
bpf_struct_ops.c	bpf: struct_ops supports more than one page for trampolines.	2024-03-04 14:09:20 -08:00
bpf_task_storage.c	bpf: Teach verifier that certain helpers accept NULL pointer.	2023-04-04 16:57:16 -07:00
btf.c	bpf: Allow all printable characters in BTF DATASEC names	2024-03-06 15:18:16 -08:00
cgroup.c	bpf: remove check in __cgroup_bpf_run_filter_skb	2024-02-13 15:41:17 -08:00
cgroup_iter.c	bpf: Let verifier consider {task,cgroup} is trusted in bpf_iter_reg	2023-11-07 15:24:25 -08:00
core.c	bpf: Tell bpf programs kernel's PAGE_SIZE	2024-03-07 14:58:48 -08:00
cpumap.c	net, bpf: Add a warning if NAPI cb missed xdp_do_flush().	2023-10-17 15:02:03 +02:00
cpumask.c	bpf: treewide: Annotate BPF kfuncs in BTF	2024-01-31 20:40:56 -08:00
devmap.c	bpf: Fix DEVMAP_HASH overflow check on 32-bit arches	2024-03-07 20:02:38 -08:00
disasm.c	bpf: Introduce may_goto instruction	2024-03-06 15:17:31 -08:00
disasm.h
dispatcher.c	bpf: Use arch_bpf_trampoline_size	2023-12-06 17:17:20 -08:00
hashtab.c	bpf: Fix hashtab overflow check on 32-bit arches	2024-03-07 20:05:56 -08:00
helpers.c	bpf-next-for-netdev	2024-03-02 20:50:59 -08:00
inode.c	bpf: Support symbolic BPF FS delegation mount options	2024-01-24 16:21:02 -08:00
Kconfig	bpf: Merge two CONFIG_BPF entries	2024-02-07 16:38:20 -08:00
link_iter.c
local_storage.c	cgroup changes for v6.4-rc1	2023-04-29 10:05:22 -07:00
log.c	bpf: improve duplicate source code line detection	2024-02-15 13:00:48 -08:00
lpm_trie.c	bpf: Replace bpf_lpm_trie_key 0-length array with flexible array	2024-02-29 22:52:43 +01:00
Makefile	bpf: Introduce BPF token object	2024-01-24 16:21:01 -08:00
map_in_map.c	bpf: Optimize the free of inner map	2023-12-04 17:50:26 -08:00
map_in_map.h	bpf: Add map and need_defer parameters to .map_fd_put_ptr()	2023-12-04 17:50:26 -08:00
map_iter.c	bpf: treewide: Annotate BPF kfuncs in BTF	2024-01-31 20:40:56 -08:00
memalloc.c	bpf: Remove unnecessary cpu == 0 check in memalloc	2024-01-04 10:18:14 -08:00
mmap_unlock_work.h
mprog.c	bpf: Handle bpf_mprog_query with NULL entry	2023-10-06 17:11:20 -07:00
net_namespace.c
offload.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2023-09-21 21:49:45 +02:00
percpu_freelist.c	bpf: Initialize same number of free nodes for each pcpu_freelist	2022-11-11 12:05:14 -08:00
percpu_freelist.h
prog_iter.c
queue_stack_maps.c	bpf: Avoid deadlock when using queue and stack maps from NMI	2023-09-11 19:04:49 -07:00
reuseport_array.c	bpf: Centralize permissions checks for all BPF map types	2023-06-19 14:04:04 +02:00
ringbuf.c	bpf: Fold smp_mb__before_atomic() into atomic_set_release()	2023-10-24 14:26:07 +02:00
stackmap.c	bpf: Fix stackmap overflow check on 32-bit arches	2024-03-07 20:06:25 -08:00
syscall.c	bpf: Plumb get_unmapped_area() callback into bpf_map_ops	2024-03-07 14:58:48 -08:00
sysfs_btf.c
task_iter.c	bpf: Fix an issue due to uninitialized bpf_iter_task	2024-02-19 12:28:15 +01:00
tcx.c	bpf, tcx: Get rid of tcx_link_const	2023-10-23 15:01:53 -07:00
tnum.c	bpf: simplify tnum output if a fully known constant	2023-12-02 11:36:51 -08:00
token.c	bpf,token: Use BIT_ULL() to convert the bit mask	2024-01-29 20:04:55 -08:00
trampoline.c	bpf: Use arch_bpf_trampoline_size	2023-12-06 17:17:20 -08:00
verifier.c	bpf: Recognize '__map' suffix in kfunc arguments	2024-03-07 14:58:48 -08:00