mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-27 11:19:37 +00:00
![John Johansen](/assets/img/avatar_default.png)
BugLink: http://bugs.launchpad.net/bugs/1268727 The task field in the lsm_audit struct needs to be initialized if a change_hat fails, otherwise the following oops will occur BUG: unable to handle kernel paging request at 0000002fbead7d08 IP: [<ffffffff8171153e>] _raw_spin_lock+0xe/0x50 PGD 1e3f35067 PUD 0 Oops: 0002 [#1] SMP Modules linked in: pppox crc_ccitt p8023 p8022 psnap llc ax25 btrfs raid6_pq xor xfs libcrc32c dm_multipath scsi_dh kvm_amd dcdbas kvm microcode amd64_edac_mod joydev edac_core psmouse edac_mce_amd serio_raw k10temp sp5100_tco i2c_piix4 ipmi_si ipmi_msghandler acpi_power_meter mac_hid lp parport hid_generic usbhid hid pata_acpi mpt2sas ahci raid_class pata_atiixp bnx2 libahci scsi_transport_sas [last unloaded: tipc] CPU: 2 PID: 699 Comm: changehat_twice Tainted: GF O 3.13.0-7-generic #25-Ubuntu Hardware name: Dell Inc. PowerEdge R415/08WNM9, BIOS 1.8.6 12/06/2011 task: ffff8802135c6000 ti: ffff880212986000 task.ti: ffff880212986000 RIP: 0010:[<ffffffff8171153e>] [<ffffffff8171153e>] _raw_spin_lock+0xe/0x50 RSP: 0018:ffff880212987b68 EFLAGS: 00010006 RAX: 0000000000020000 RBX: 0000002fbead7500 RCX: 0000000000000000 RDX: 0000000000000292 RSI: ffff880212987ba8 RDI: 0000002fbead7d08 RBP: ffff880212987b68 R08: 0000000000000246 R09: ffff880216e572a0 R10: ffffffff815fd677 R11: ffffea0008469580 R12: ffffffff8130966f R13: ffff880212987ba8 R14: 0000002fbead7d08 R15: ffff8800d8c6b830 FS: 00002b5e6c84e7c0(0000) GS:ffff880216e40000(0000) knlGS:0000000055731700 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 0000002fbead7d08 CR3: 000000021270f000 CR4: 00000000000006e0 Stack: ffff880212987b98 ffffffff81075f17 ffffffff8130966f 0000000000000009 0000000000000000 0000000000000000 ffff880212987bd0 ffffffff81075f7c 0000000000000292 ffff880212987c08 ffff8800d8c6b800 0000000000000026 Call Trace: [<ffffffff81075f17>] __lock_task_sighand+0x47/0x80 [<ffffffff8130966f>] ? apparmor_cred_prepare+0x2f/0x50 [<ffffffff81075f7c>] do_send_sig_info+0x2c/0x80 [<ffffffff81075fee>] send_sig_info+0x1e/0x30 [<ffffffff8130242d>] aa_audit+0x13d/0x190 [<ffffffff8130c1dc>] aa_audit_file+0xbc/0x130 [<ffffffff8130966f>] ? apparmor_cred_prepare+0x2f/0x50 [<ffffffff81304cc2>] aa_change_hat+0x202/0x530 [<ffffffff81308fc6>] aa_setprocattr_changehat+0x116/0x1d0 [<ffffffff8130a11d>] apparmor_setprocattr+0x25d/0x300 [<ffffffff812cee56>] security_setprocattr+0x16/0x20 [<ffffffff8121fc87>] proc_pid_attr_write+0x107/0x130 [<ffffffff811b7604>] vfs_write+0xb4/0x1f0 [<ffffffff811b8039>] SyS_write+0x49/0xa0 [<ffffffff8171a1bf>] tracesys+0xe1/0xe6 Signed-off-by: John Johansen <john.johansen@canonical.com> Acked-by: Seth Arnold <seth.arnold@canonical.com>
210 lines
4.4 KiB
C
210 lines
4.4 KiB
C
/*
|
|
* AppArmor security module
|
|
*
|
|
* This file contains AppArmor auditing functions
|
|
*
|
|
* Copyright (C) 1998-2008 Novell/SUSE
|
|
* Copyright 2009-2010 Canonical Ltd.
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public License as
|
|
* published by the Free Software Foundation, version 2 of the
|
|
* License.
|
|
*/
|
|
|
|
#include <linux/audit.h>
|
|
#include <linux/socket.h>
|
|
|
|
#include "include/apparmor.h"
|
|
#include "include/audit.h"
|
|
#include "include/policy.h"
|
|
|
|
const char *const op_table[] = {
|
|
"null",
|
|
|
|
"sysctl",
|
|
"capable",
|
|
|
|
"unlink",
|
|
"mkdir",
|
|
"rmdir",
|
|
"mknod",
|
|
"truncate",
|
|
"link",
|
|
"symlink",
|
|
"rename_src",
|
|
"rename_dest",
|
|
"chmod",
|
|
"chown",
|
|
"getattr",
|
|
"open",
|
|
|
|
"file_perm",
|
|
"file_lock",
|
|
"file_mmap",
|
|
"file_mprotect",
|
|
|
|
"create",
|
|
"post_create",
|
|
"bind",
|
|
"connect",
|
|
"listen",
|
|
"accept",
|
|
"sendmsg",
|
|
"recvmsg",
|
|
"getsockname",
|
|
"getpeername",
|
|
"getsockopt",
|
|
"setsockopt",
|
|
"socket_shutdown",
|
|
|
|
"ptrace",
|
|
|
|
"exec",
|
|
"change_hat",
|
|
"change_profile",
|
|
"change_onexec",
|
|
|
|
"setprocattr",
|
|
"setrlimit",
|
|
|
|
"profile_replace",
|
|
"profile_load",
|
|
"profile_remove"
|
|
};
|
|
|
|
const char *const audit_mode_names[] = {
|
|
"normal",
|
|
"quiet_denied",
|
|
"quiet",
|
|
"noquiet",
|
|
"all"
|
|
};
|
|
|
|
static const char *const aa_audit_type[] = {
|
|
"AUDIT",
|
|
"ALLOWED",
|
|
"DENIED",
|
|
"HINT",
|
|
"STATUS",
|
|
"ERROR",
|
|
"KILLED",
|
|
"AUTO"
|
|
};
|
|
|
|
/*
|
|
* Currently AppArmor auditing is fed straight into the audit framework.
|
|
*
|
|
* TODO:
|
|
* netlink interface for complain mode
|
|
* user auditing, - send user auditing to netlink interface
|
|
* system control of whether user audit messages go to system log
|
|
*/
|
|
|
|
/**
|
|
* audit_base - core AppArmor function.
|
|
* @ab: audit buffer to fill (NOT NULL)
|
|
* @ca: audit structure containing data to audit (NOT NULL)
|
|
*
|
|
* Record common AppArmor audit data from @sa
|
|
*/
|
|
static void audit_pre(struct audit_buffer *ab, void *ca)
|
|
{
|
|
struct common_audit_data *sa = ca;
|
|
|
|
if (aa_g_audit_header) {
|
|
audit_log_format(ab, "apparmor=");
|
|
audit_log_string(ab, aa_audit_type[sa->aad->type]);
|
|
}
|
|
|
|
if (sa->aad->op) {
|
|
audit_log_format(ab, " operation=");
|
|
audit_log_string(ab, op_table[sa->aad->op]);
|
|
}
|
|
|
|
if (sa->aad->info) {
|
|
audit_log_format(ab, " info=");
|
|
audit_log_string(ab, sa->aad->info);
|
|
if (sa->aad->error)
|
|
audit_log_format(ab, " error=%d", sa->aad->error);
|
|
}
|
|
|
|
if (sa->aad->profile) {
|
|
struct aa_profile *profile = sa->aad->profile;
|
|
if (profile->ns != root_ns) {
|
|
audit_log_format(ab, " namespace=");
|
|
audit_log_untrustedstring(ab, profile->ns->base.hname);
|
|
}
|
|
audit_log_format(ab, " profile=");
|
|
audit_log_untrustedstring(ab, profile->base.hname);
|
|
}
|
|
|
|
if (sa->aad->name) {
|
|
audit_log_format(ab, " name=");
|
|
audit_log_untrustedstring(ab, sa->aad->name);
|
|
}
|
|
}
|
|
|
|
/**
|
|
* aa_audit_msg - Log a message to the audit subsystem
|
|
* @sa: audit event structure (NOT NULL)
|
|
* @cb: optional callback fn for type specific fields (MAYBE NULL)
|
|
*/
|
|
void aa_audit_msg(int type, struct common_audit_data *sa,
|
|
void (*cb) (struct audit_buffer *, void *))
|
|
{
|
|
sa->aad->type = type;
|
|
common_lsm_audit(sa, audit_pre, cb);
|
|
}
|
|
|
|
/**
|
|
* aa_audit - Log a profile based audit event to the audit subsystem
|
|
* @type: audit type for the message
|
|
* @profile: profile to check against (NOT NULL)
|
|
* @gfp: allocation flags to use
|
|
* @sa: audit event (NOT NULL)
|
|
* @cb: optional callback fn for type specific fields (MAYBE NULL)
|
|
*
|
|
* Handle default message switching based off of audit mode flags
|
|
*
|
|
* Returns: error on failure
|
|
*/
|
|
int aa_audit(int type, struct aa_profile *profile, gfp_t gfp,
|
|
struct common_audit_data *sa,
|
|
void (*cb) (struct audit_buffer *, void *))
|
|
{
|
|
BUG_ON(!profile);
|
|
|
|
if (type == AUDIT_APPARMOR_AUTO) {
|
|
if (likely(!sa->aad->error)) {
|
|
if (AUDIT_MODE(profile) != AUDIT_ALL)
|
|
return 0;
|
|
type = AUDIT_APPARMOR_AUDIT;
|
|
} else if (COMPLAIN_MODE(profile))
|
|
type = AUDIT_APPARMOR_ALLOWED;
|
|
else
|
|
type = AUDIT_APPARMOR_DENIED;
|
|
}
|
|
if (AUDIT_MODE(profile) == AUDIT_QUIET ||
|
|
(type == AUDIT_APPARMOR_DENIED &&
|
|
AUDIT_MODE(profile) == AUDIT_QUIET))
|
|
return sa->aad->error;
|
|
|
|
if (KILL_MODE(profile) && type == AUDIT_APPARMOR_DENIED)
|
|
type = AUDIT_APPARMOR_KILL;
|
|
|
|
if (!unconfined(profile))
|
|
sa->aad->profile = profile;
|
|
|
|
aa_audit_msg(type, sa, cb);
|
|
|
|
if (sa->aad->type == AUDIT_APPARMOR_KILL)
|
|
(void)send_sig_info(SIGKILL, NULL,
|
|
sa->type == LSM_AUDIT_DATA_TASK && sa->u.tsk ?
|
|
sa->u.tsk : current);
|
|
|
|
if (sa->aad->type == AUDIT_APPARMOR_ALLOWED)
|
|
return complain_error(sa->aad->error);
|
|
|
|
return sa->aad->error;
|
|
}
|