mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-13 14:14:37 +00:00
0f620cefd7
CONFIG_VMLINUX_VALIDATION is just the validation of the "noinstr" rules. That name is a misnomer, because now objtool actually does vmlinux validation for other reasons. Rename CONFIG_VMLINUX_VALIDATION to CONFIG_NOINSTR_VALIDATION. Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> Reviewed-by: Miroslav Benes <mbenes@suse.cz> Link: https://lkml.kernel.org/r/173f07e2d6d1afc0874aed975a61783207c6a531.1650300597.git.jpoimboe@redhat.com
61 lines
2 KiB
C
61 lines
2 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
#ifndef __LINUX_INSTRUMENTATION_H
|
|
#define __LINUX_INSTRUMENTATION_H
|
|
|
|
#ifdef CONFIG_NOINSTR_VALIDATION
|
|
|
|
#include <linux/stringify.h>
|
|
|
|
/* Begin/end of an instrumentation safe region */
|
|
#define __instrumentation_begin(c) ({ \
|
|
asm volatile(__stringify(c) ": nop\n\t" \
|
|
".pushsection .discard.instr_begin\n\t" \
|
|
".long " __stringify(c) "b - .\n\t" \
|
|
".popsection\n\t" : : "i" (c)); \
|
|
})
|
|
#define instrumentation_begin() __instrumentation_begin(__COUNTER__)
|
|
|
|
/*
|
|
* Because instrumentation_{begin,end}() can nest, objtool validation considers
|
|
* _begin() a +1 and _end() a -1 and computes a sum over the instructions.
|
|
* When the value is greater than 0, we consider instrumentation allowed.
|
|
*
|
|
* There is a problem with code like:
|
|
*
|
|
* noinstr void foo()
|
|
* {
|
|
* instrumentation_begin();
|
|
* ...
|
|
* if (cond) {
|
|
* instrumentation_begin();
|
|
* ...
|
|
* instrumentation_end();
|
|
* }
|
|
* bar();
|
|
* instrumentation_end();
|
|
* }
|
|
*
|
|
* If instrumentation_end() would be an empty label, like all the other
|
|
* annotations, the inner _end(), which is at the end of a conditional block,
|
|
* would land on the instruction after the block.
|
|
*
|
|
* If we then consider the sum of the !cond path, we'll see that the call to
|
|
* bar() is with a 0-value, even though, we meant it to happen with a positive
|
|
* value.
|
|
*
|
|
* To avoid this, have _end() be a NOP instruction, this ensures it will be
|
|
* part of the condition block and does not escape.
|
|
*/
|
|
#define __instrumentation_end(c) ({ \
|
|
asm volatile(__stringify(c) ": nop\n\t" \
|
|
".pushsection .discard.instr_end\n\t" \
|
|
".long " __stringify(c) "b - .\n\t" \
|
|
".popsection\n\t" : : "i" (c)); \
|
|
})
|
|
#define instrumentation_end() __instrumentation_end(__COUNTER__)
|
|
#else /* !CONFIG_NOINSTR_VALIDATION */
|
|
# define instrumentation_begin() do { } while(0)
|
|
# define instrumentation_end() do { } while(0)
|
|
#endif /* CONFIG_NOINSTR_VALIDATION */
|
|
|
|
#endif /* __LINUX_INSTRUMENTATION_H */
|