mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-06 02:50:43 +00:00
![Tejun Heo](/assets/img/avatar_default.png)
libata lets low level drivers build ata_port_operations table and register it with libata core layer. This allows low level drivers high level of flexibility but also burdens them with lots of boilerplate entries. This becomes worse for drivers which support related similar controllers which differ slightly. They share most of the operations except for a few. However, the driver still needs to list all operations for each variant. This results in large number of duplicate entries, which is not only inefficient but also error-prone as it becomes very difficult to tell what the actual differences are. This duplicate boilerplates all over the low level drivers also make updating the core layer exteremely difficult and error-prone. When compounded with multi-branched development model, it ends up accumulating inconsistencies over time. Some of those inconsistencies cause immediate problems and fixed. Others just remain there dormant making maintenance increasingly difficult. To rectify the problem, this patch implements ata_port_operations inheritance. To allow LLDs to easily re-use their own ops tables overriding only specific methods, this patch implements poor man's class inheritance. An ops table has ->inherits field which can be set to any ops table as long as it doesn't create a loop. When the host is started, the inheritance chain is followed and any operation which isn't specified is taken from the nearest ancestor which has it specified. This operation is called finalization and done only once per an ops table and the LLD doesn't have to do anything special about it other than making the ops table non-const such that libata can update it. libata provides four base ops tables lower drivers can inherit from - base, sata, pmp, sff and bmdma. To avoid overriding these ops accidentaly, these ops are declared const and LLDs should always inherit these instead of using them directly. After finalization, all the ops table are identical before and after the patch except for setting .irq_handler to ata_interrupt in drivers which didn't use to. The .irq_handler doesn't have any actual effect and the field will soon be removed by later patch. * sata_sx4 is still using old style EH and currently doesn't take advantage of ops inheritance. Signed-off-by: Tejun Heo <htejun@gmail.com>
261 lines
6.8 KiB
C
261 lines
6.8 KiB
C
/*
|
|
* sata_uli.c - ULi Electronics SATA
|
|
*
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2, or (at your option)
|
|
* any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; see the file COPYING. If not, write to
|
|
* the Free Software Foundation, 675 Mass Ave, Cambridge, MA 02139, USA.
|
|
*
|
|
*
|
|
* libata documentation is available via 'make {ps|pdf}docs',
|
|
* as Documentation/DocBook/libata.*
|
|
*
|
|
* Hardware documentation available under NDA.
|
|
*
|
|
*/
|
|
|
|
#include <linux/kernel.h>
|
|
#include <linux/module.h>
|
|
#include <linux/pci.h>
|
|
#include <linux/init.h>
|
|
#include <linux/blkdev.h>
|
|
#include <linux/delay.h>
|
|
#include <linux/interrupt.h>
|
|
#include <linux/device.h>
|
|
#include <scsi/scsi_host.h>
|
|
#include <linux/libata.h>
|
|
|
|
#define DRV_NAME "sata_uli"
|
|
#define DRV_VERSION "1.3"
|
|
|
|
enum {
|
|
uli_5289 = 0,
|
|
uli_5287 = 1,
|
|
uli_5281 = 2,
|
|
|
|
uli_max_ports = 4,
|
|
|
|
/* PCI configuration registers */
|
|
ULI5287_BASE = 0x90, /* sata0 phy SCR registers */
|
|
ULI5287_OFFS = 0x10, /* offset from sata0->sata1 phy regs */
|
|
ULI5281_BASE = 0x60, /* sata0 phy SCR registers */
|
|
ULI5281_OFFS = 0x60, /* offset from sata0->sata1 phy regs */
|
|
};
|
|
|
|
struct uli_priv {
|
|
unsigned int scr_cfg_addr[uli_max_ports];
|
|
};
|
|
|
|
static int uli_init_one(struct pci_dev *pdev, const struct pci_device_id *ent);
|
|
static int uli_scr_read(struct ata_port *ap, unsigned int sc_reg, u32 *val);
|
|
static int uli_scr_write(struct ata_port *ap, unsigned int sc_reg, u32 val);
|
|
|
|
static const struct pci_device_id uli_pci_tbl[] = {
|
|
{ PCI_VDEVICE(AL, 0x5289), uli_5289 },
|
|
{ PCI_VDEVICE(AL, 0x5287), uli_5287 },
|
|
{ PCI_VDEVICE(AL, 0x5281), uli_5281 },
|
|
|
|
{ } /* terminate list */
|
|
};
|
|
|
|
static struct pci_driver uli_pci_driver = {
|
|
.name = DRV_NAME,
|
|
.id_table = uli_pci_tbl,
|
|
.probe = uli_init_one,
|
|
.remove = ata_pci_remove_one,
|
|
};
|
|
|
|
static struct scsi_host_template uli_sht = {
|
|
ATA_BMDMA_SHT(DRV_NAME),
|
|
};
|
|
|
|
static struct ata_port_operations uli_ops = {
|
|
.inherits = &ata_bmdma_port_ops,
|
|
.scr_read = uli_scr_read,
|
|
.scr_write = uli_scr_write,
|
|
};
|
|
|
|
static const struct ata_port_info uli_port_info = {
|
|
.flags = ATA_FLAG_SATA | ATA_FLAG_NO_LEGACY |
|
|
ATA_FLAG_IGN_SIMPLEX,
|
|
.pio_mask = 0x1f, /* pio0-4 */
|
|
.udma_mask = ATA_UDMA6,
|
|
.port_ops = &uli_ops,
|
|
};
|
|
|
|
|
|
MODULE_AUTHOR("Peer Chen");
|
|
MODULE_DESCRIPTION("low-level driver for ULi Electronics SATA controller");
|
|
MODULE_LICENSE("GPL");
|
|
MODULE_DEVICE_TABLE(pci, uli_pci_tbl);
|
|
MODULE_VERSION(DRV_VERSION);
|
|
|
|
static unsigned int get_scr_cfg_addr(struct ata_port *ap, unsigned int sc_reg)
|
|
{
|
|
struct uli_priv *hpriv = ap->host->private_data;
|
|
return hpriv->scr_cfg_addr[ap->port_no] + (4 * sc_reg);
|
|
}
|
|
|
|
static u32 uli_scr_cfg_read(struct ata_port *ap, unsigned int sc_reg)
|
|
{
|
|
struct pci_dev *pdev = to_pci_dev(ap->host->dev);
|
|
unsigned int cfg_addr = get_scr_cfg_addr(ap, sc_reg);
|
|
u32 val;
|
|
|
|
pci_read_config_dword(pdev, cfg_addr, &val);
|
|
return val;
|
|
}
|
|
|
|
static void uli_scr_cfg_write(struct ata_port *ap, unsigned int scr, u32 val)
|
|
{
|
|
struct pci_dev *pdev = to_pci_dev(ap->host->dev);
|
|
unsigned int cfg_addr = get_scr_cfg_addr(ap, scr);
|
|
|
|
pci_write_config_dword(pdev, cfg_addr, val);
|
|
}
|
|
|
|
static int uli_scr_read(struct ata_port *ap, unsigned int sc_reg, u32 *val)
|
|
{
|
|
if (sc_reg > SCR_CONTROL)
|
|
return -EINVAL;
|
|
|
|
*val = uli_scr_cfg_read(ap, sc_reg);
|
|
return 0;
|
|
}
|
|
|
|
static int uli_scr_write(struct ata_port *ap, unsigned int sc_reg, u32 val)
|
|
{
|
|
if (sc_reg > SCR_CONTROL) //SCR_CONTROL=2, SCR_ERROR=1, SCR_STATUS=0
|
|
return -EINVAL;
|
|
|
|
uli_scr_cfg_write(ap, sc_reg, val);
|
|
return 0;
|
|
}
|
|
|
|
static int uli_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
|
|
{
|
|
static int printed_version;
|
|
const struct ata_port_info *ppi[] = { &uli_port_info, NULL };
|
|
unsigned int board_idx = (unsigned int) ent->driver_data;
|
|
struct ata_host *host;
|
|
struct uli_priv *hpriv;
|
|
void __iomem * const *iomap;
|
|
struct ata_ioports *ioaddr;
|
|
int n_ports, rc;
|
|
|
|
if (!printed_version++)
|
|
dev_printk(KERN_INFO, &pdev->dev, "version " DRV_VERSION "\n");
|
|
|
|
rc = pcim_enable_device(pdev);
|
|
if (rc)
|
|
return rc;
|
|
|
|
n_ports = 2;
|
|
if (board_idx == uli_5287)
|
|
n_ports = 4;
|
|
|
|
/* allocate the host */
|
|
host = ata_host_alloc_pinfo(&pdev->dev, ppi, n_ports);
|
|
if (!host)
|
|
return -ENOMEM;
|
|
|
|
hpriv = devm_kzalloc(&pdev->dev, sizeof(*hpriv), GFP_KERNEL);
|
|
if (!hpriv)
|
|
return -ENOMEM;
|
|
host->private_data = hpriv;
|
|
|
|
/* the first two ports are standard SFF */
|
|
rc = ata_pci_init_sff_host(host);
|
|
if (rc)
|
|
return rc;
|
|
|
|
rc = ata_pci_init_bmdma(host);
|
|
if (rc)
|
|
return rc;
|
|
|
|
iomap = host->iomap;
|
|
|
|
switch (board_idx) {
|
|
case uli_5287:
|
|
/* If there are four, the last two live right after
|
|
* the standard SFF ports.
|
|
*/
|
|
hpriv->scr_cfg_addr[0] = ULI5287_BASE;
|
|
hpriv->scr_cfg_addr[1] = ULI5287_BASE + ULI5287_OFFS;
|
|
|
|
ioaddr = &host->ports[2]->ioaddr;
|
|
ioaddr->cmd_addr = iomap[0] + 8;
|
|
ioaddr->altstatus_addr =
|
|
ioaddr->ctl_addr = (void __iomem *)
|
|
((unsigned long)iomap[1] | ATA_PCI_CTL_OFS) + 4;
|
|
ioaddr->bmdma_addr = iomap[4] + 16;
|
|
hpriv->scr_cfg_addr[2] = ULI5287_BASE + ULI5287_OFFS*4;
|
|
ata_std_ports(ioaddr);
|
|
|
|
ata_port_desc(host->ports[2],
|
|
"cmd 0x%llx ctl 0x%llx bmdma 0x%llx",
|
|
(unsigned long long)pci_resource_start(pdev, 0) + 8,
|
|
((unsigned long long)pci_resource_start(pdev, 1) | ATA_PCI_CTL_OFS) + 4,
|
|
(unsigned long long)pci_resource_start(pdev, 4) + 16);
|
|
|
|
ioaddr = &host->ports[3]->ioaddr;
|
|
ioaddr->cmd_addr = iomap[2] + 8;
|
|
ioaddr->altstatus_addr =
|
|
ioaddr->ctl_addr = (void __iomem *)
|
|
((unsigned long)iomap[3] | ATA_PCI_CTL_OFS) + 4;
|
|
ioaddr->bmdma_addr = iomap[4] + 24;
|
|
hpriv->scr_cfg_addr[3] = ULI5287_BASE + ULI5287_OFFS*5;
|
|
ata_std_ports(ioaddr);
|
|
|
|
ata_port_desc(host->ports[2],
|
|
"cmd 0x%llx ctl 0x%llx bmdma 0x%llx",
|
|
(unsigned long long)pci_resource_start(pdev, 2) + 9,
|
|
((unsigned long long)pci_resource_start(pdev, 3) | ATA_PCI_CTL_OFS) + 4,
|
|
(unsigned long long)pci_resource_start(pdev, 4) + 24);
|
|
|
|
break;
|
|
|
|
case uli_5289:
|
|
hpriv->scr_cfg_addr[0] = ULI5287_BASE;
|
|
hpriv->scr_cfg_addr[1] = ULI5287_BASE + ULI5287_OFFS;
|
|
break;
|
|
|
|
case uli_5281:
|
|
hpriv->scr_cfg_addr[0] = ULI5281_BASE;
|
|
hpriv->scr_cfg_addr[1] = ULI5281_BASE + ULI5281_OFFS;
|
|
break;
|
|
|
|
default:
|
|
BUG();
|
|
break;
|
|
}
|
|
|
|
pci_set_master(pdev);
|
|
pci_intx(pdev, 1);
|
|
return ata_host_activate(host, pdev->irq, ata_interrupt, IRQF_SHARED,
|
|
&uli_sht);
|
|
}
|
|
|
|
static int __init uli_init(void)
|
|
{
|
|
return pci_register_driver(&uli_pci_driver);
|
|
}
|
|
|
|
static void __exit uli_exit(void)
|
|
{
|
|
pci_unregister_driver(&uli_pci_driver);
|
|
}
|
|
|
|
|
|
module_init(uli_init);
|
|
module_exit(uli_exit);
|