linux-stable/sound/isa
Takashi Iwai d3f823518b ALSA: sb: Fix potential ABBA deadlock in CSP driver
commit 1c2b951915 upstream.

SB16 CSP driver may hit potentially a typical ABBA deadlock in two
code paths:

 In snd_sb_csp_stop():
     spin_lock_irqsave(&p->chip->mixer_lock, flags);
     spin_lock(&p->chip->reg_lock);

 In snd_sb_csp_load():
     spin_lock_irqsave(&p->chip->reg_lock, flags);
     spin_lock(&p->chip->mixer_lock);

Also the similar pattern is seen in snd_sb_csp_start().

Although the practical impact is very small (those states aren't
triggered in the same running state and this happens only on a real
hardware, decades old ISA sound boards -- which must be very difficult
to find nowadays), it's a real scenario and has to be fixed.

This patch addresses those deadlocks by splitting the locks in
snd_sb_csp_start() and snd_sb_csp_stop() for avoiding the nested
locks.

Reported-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/7b0fcdaf-cd4f-4728-2eae-48c151a92e10@gmail.com
Link: https://lore.kernel.org/r/20210716132723.13216-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-07-28 11:12:18 +02:00
..
ad1816a
ad1848
cs423x ALSA: cs4236: fix error return comparison of an unsigned integer 2020-01-09 10:17:56 +01:00
es1688 ALSA: es1688: Add the missed snd_card_free() 2020-06-20 10:25:00 +02:00
galaxy
gus
msnd
opti9xx ALSA: opti9xx: shut up gcc-10 range warning 2020-05-05 19:15:52 +02:00
sb ALSA: sb: Fix potential ABBA deadlock in CSP driver 2021-07-28 11:12:18 +02:00
wavefront ALSA: isa/wavefront: prevent out of bounds write in ioctl 2020-06-25 15:41:48 +02:00
wss ALSA: wss: Fix invalid snd_free_pages() at error path 2018-12-05 19:41:24 +01:00
adlib.c
als100.c
azt2320.c
cmi8328.c
cmi8330.c ALSA: isa: Fix error return code in snd_cmi8330_probe() 2021-07-20 16:17:54 +02:00
es18xx.c
Kconfig
Makefile
opl3sa2.c
sc6000.c
sscape.c