Amir Goldstein cd57645223 fsnotify: fix wrong lockdep annotations ... [ Upstream commit 623af4f538 ] Commit 6960b0d909 ("fsnotify: change locking order") changed some of the mark_mutex locks in direct reclaim path to use: mutex_lock_nested(&group->mark_mutex, SINGLE_DEPTH_NESTING); This change is explained: "...It uses nested locking to avoid deadlock in case we do the final iput() on an inode which still holds marks and thus would take the mutex again when calling fsnotify_inode_delete() in destroy_inode()." The problem is that the mutex_lock_nested() is not a nested lock at all. In fact, it has the opposite effect of preventing lockdep from warning about a very possible deadlock. Due to these wrong annotations, a deadlock that was introduced with nfsd filecache in kernel v5.4 went unnoticed in v5.4.y for over two years until it was reported recently by Khazhismel Kumykov, only to find out that the deadlock was already fixed in kernel v5.5. Fix the wrong lockdep annotations. Cc: Khazhismel Kumykov <khazhy@google.com> Fixes: 6960b0d909 ("fsnotify: change locking order") Link: https://lore.kernel.org/r/20220321112310.vpr7oxro2xkz5llh@quack3.lan/ Link: https://lore.kernel.org/r/20220422120327.3459282-4-amir73il@gmail.com Signed-off-by: Amir Goldstein <amir73il@gmail.com> Signed-off-by: Jan Kara <jack@suse.cz> Signed-off-by: Sasha Levin <sashal@kernel.org>		2022-06-14 16:53:48 +02:00
..
9p	9P: Cast to loff_t before multiplying	2020-11-05 11:07:03 +01:00
adfs
affs	fs/affs: release old buffer head on error path	2021-03-03 18:22:54 +01:00
afs	afs: Fix some tracing details	2020-04-02 16:34:33 +02:00
autofs4
befs
bfs
btrfs	btrfs: repair super block num_devices automatically	2022-06-14 16:53:43 +02:00
cachefiles	cachefiles: Handle readpage error correctly	2020-11-05 11:07:05 +01:00
ceph	ceph: lockdep annotations for try_nonblocking_invalidate	2021-09-26 13:37:29 +02:00
cifs	cifs: destage any unwritten data to the server before calling copychunk_write	2022-05-12 12:17:07 +02:00
coda
configfs	configfs: fix a race in configfs_{,un}register_subsystem()	2022-03-02 11:33:56 +01:00
cramfs
crypto	fscrypt: don't ignore minor_hash when hash is 0	2021-07-20 16:17:45 +02:00
debugfs
devpts
dlm	fs: dlm: filter user dlm messages for kernel locks	2022-01-27 09:00:53 +01:00
ecryptfs	Revert "ecryptfs: replace BUG_ON with error handling code"	2021-05-26 11:47:00 +02:00
efivarfs	efivarfs: revert "fix memory leak in efivarfs_create()"	2020-12-02 08:34:44 +01:00
efs
exofs
exportfs
ext2	ext2: correct max file size computing	2022-04-20 09:08:17 +02:00
ext4	ext4: force overhead calculation if the s_overhead_cluster makes no sense	2022-04-27 13:15:31 +02:00
f2fs	f2fs: fix to do sanity check on last xattr entry in __f2fs_setxattr()	2021-12-29 12:17:36 +01:00
fat	fat: add ratelimit to fat*_ent_bread()	2022-06-14 16:53:46 +02:00
freevxfs
fscache
fuse	fuse: fix pipe buffer lifetime for direct_io	2022-04-20 09:08:08 +02:00
gfs2	gfs2: assign rgrp glock before compute_bitstructs	2022-04-27 13:15:29 +02:00
hfs	hfs: add lock nesting notation to hfs_find_init	2021-08-04 12:22:15 +02:00
hfsplus	hfsplus: fix crash and filesystem corruption when deleting files	2020-04-24 08:00:45 +02:00
hostfs
hpfs
hugetlbfs	hugetlbfs: hugetlb_fault_mutex_hash() cleanup	2021-06-03 08:36:25 +02:00
isofs	isofs: Fix out of bound access for corrupted isofs image	2021-11-12 14:28:24 +01:00
jbd2	jbd2: abort journal if free a async write error metadata buffer	2020-09-03 11:22:29 +02:00
jffs2	jffs2: fix memory leak in jffs2_scan_medium	2022-04-20 09:08:10 +02:00
jfs	fs: jfs: fix possible NULL pointer dereference in dbFree()	2022-06-14 16:53:46 +02:00
kernfs	kernfs: deal with kernfs_fill_super() failures	2021-06-30 08:48:55 -04:00
lockd	lockd: don't use interval-based rebinding over TCP	2020-12-29 13:46:57 +01:00
minix	fs/minix: reject too-large maximum file size	2020-08-21 09:48:15 +02:00
ncpfs
nfs	NFS: swap-out must always use STABLE writes.	2022-04-20 09:08:28 +02:00
nfs_common	nfs_common: need lock during iterate through the list	2020-12-29 13:47:01 +01:00
nfsd	NFSD: Fix possible sleep during nfsd4_release_lockowner()	2022-06-06 08:20:58 +02:00
nilfs2	nilfs2: fix memory leak in nilfs_sysfs_delete_snapshot_group	2021-09-26 13:37:30 +02:00
nls
notify	fsnotify: fix wrong lockdep annotations	2022-06-14 16:53:48 +02:00
ntfs	ntfs: add sanity check on allocation size	2022-04-20 09:08:22 +02:00
ocfs2	ocfs2: fix data corruption on truncate	2021-11-26 11:40:20 +01:00
omfs
openpromfs
orangefs	orangefs: Fix the size of a memory allocation in orangefs_bufmap_alloc()	2022-01-27 09:00:46 +01:00
overlayfs	ovl: fix missing negative dentry check in ovl_rename()	2021-10-17 10:08:32 +02:00
proc	proc/vmcore: fix clearing user buffer by properly using clear_user()	2021-12-08 08:46:52 +01:00
pstore
qnx4	qnx4: work around gcc false positive warning bug	2021-10-06 15:05:08 +02:00
qnx6
quota	quota: make dquot_quota_sync return errors from ->sync_fs	2022-02-23 11:57:33 +01:00
ramfs	ramfs: fix nommu mmap with gaps in the page cache	2020-10-29 09:07:11 +01:00
reiserfs	reiserfs: check directory items on read from disk	2021-08-15 13:03:33 +02:00
romfs	romfs: fix uninitialized memory leak in romfs_dev_read()	2020-08-26 10:29:54 +02:00
squashfs	squashfs: fix divide error in calculate_skip()	2021-05-22 10:57:39 +02:00
sysfs	fs: sysfs_emit: Remove PAGE_SIZE alignment check	2022-03-23 09:01:35 +01:00
sysv
tracefs	tracefs: Set the group ownership in apply_options() not parse_options()	2022-03-02 11:33:58 +01:00
ubifs	ubifs: Rectify space amount budget for mkdir/tmpfile operations	2022-04-20 09:08:25 +02:00
udf	udf: Fix NULL ptr deref when converting from inline format	2022-02-08 18:16:24 +01:00
ufs	fs/ufs: avoid potential u32 multiplication overflow	2020-08-21 09:48:22 +02:00
xfs	xfs: map unwritten blocks in XFS_IOC_{ALLOC,FREE}SP just like fallocate	2022-01-11 13:57:36 +01:00
aio.c
anon_inodes.c
attr.c
bad_inode.c
binfmt_aout.c
binfmt_elf.c	fs/binfmt_elf.c: allocate initialized memory in fill_thread_core_info()	2020-06-03 08:18:03 +02:00
binfmt_elf_fdpic.c
binfmt_em86.c
binfmt_flat.c	binfmt_flat: do not stop relocating GOT entries prematurely on riscv	2022-06-14 16:53:43 +02:00
binfmt_misc.c	binfmt_misc: fix possible deadlock in bm_register_write	2021-03-17 16:34:35 +01:00
binfmt_script.c
block_dev.c	block: reexpand iov_iter after read/write	2021-05-22 10:57:43 +02:00
buffer.c	fs: Don't invalidate page buffers in block_write_full_page()	2020-11-05 11:06:58 +01:00
char_dev.c
compat.c
compat_binfmt_elf.c
compat_ioctl.c
coredump.c	coredump: fix crash when umh is disabled	2020-05-20 08:16:58 +02:00
dax.c
dcache.c
dcookies.c
direct-io.c	fs: direct-io: fix missing sdio->boundary	2021-04-16 11:57:48 +02:00
drop_caches.c
eventfd.c
eventpoll.c	ep_create_wakeup_source(): dentry name can change under you...	2020-10-14 09:51:09 +02:00
exec.c	exec: Force single empty string when argv is empty	2022-06-06 08:20:57 +02:00
fcntl.c
fhandle.c
file.c	fget: clarify and improve __fget_files() implementation	2022-03-02 11:34:00 +01:00
file_table.c	fs: add fget_many() and fput_many()	2021-12-08 08:46:55 +01:00
filesystems.c	fs/filesystems.c: downgrade user-reachable WARN_ONCE() to pr_warn_once()	2020-04-24 08:00:43 +02:00
fs-writeback.c	writeback: fix obtain a reference to a freeing memcg css	2021-07-20 16:17:37 +02:00
fs_pin.c
fs_struct.c
inode.c	futex: Fix inode life-time issue	2020-04-02 16:34:21 +02:00
internal.h
ioctl.c
iomap.c
Kconfig
Kconfig.binfmt
libfs.c	libfs: fix error cast of negative value in simple_attr_write()	2020-11-24 13:05:50 +01:00
locks.c
Makefile
mbcache.c
mount.h
mpage.c
namei.c
namespace.c	VFS: Fix memory leak caused by concurrently mounting fs with subtype	2022-05-15 19:40:27 +02:00
no-block.c
nsfs.c
open.c
pipe.c	pipe: increase minimum default pipe size to 2 pages	2021-08-15 13:03:31 +02:00
pnode.c	propagate_one(): mnt_set_mountpoint() needs mount_lock	2020-05-02 17:24:47 +02:00
pnode.h
posix_acl.c
proc_namespace.c
read_write.c
readdir.c	readdir: make sure to verify directory entry for legacy interfaces too	2021-04-28 12:08:41 +02:00
select.c	kernel, fs: Introduce and use set_restart_fn() and arch_set_restart_data()	2021-03-24 11:05:05 +01:00
seq_file.c	seq_file: disallow extremely large seq buffer allocations	2021-07-20 16:17:55 +02:00
signalfd.c	signalfd: use wake_up_pollfree()	2021-12-14 10:16:55 +01:00
splice.c
stack.c
stat.c	stat: fix inconsistency between struct stat and struct compat_stat	2022-04-27 13:15:30 +02:00
statfs.c
super.c	vfs: make freeze_super abort when sync_filesystem returns error	2022-02-23 11:57:33 +01:00
sync.c
timerfd.c
userfaultfd.c
utimes.c
xattr.c	xattr: break delegations in {set,remove}xattr	2020-08-21 09:48:00 +02:00