mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-26 10:49:33 +00:00
![Kees Cook](/assets/img/avatar_default.png)
The devm_kzalloc() function has a 2-factor argument form, devm_kcalloc(). This patch replaces cases of: devm_kzalloc(handle, a * b, gfp) with: devm_kcalloc(handle, a * b, gfp) as well as handling cases of: devm_kzalloc(handle, a * b * c, gfp) with: devm_kzalloc(handle, array3_size(a, b, c), gfp) as it's slightly less ugly than: devm_kcalloc(handle, array_size(a, b), c, gfp) This does, however, attempt to ignore constant size factors like: devm_kzalloc(handle, 4 * 1024, gfp) though any constants defined via macros get caught up in the conversion. Any factors with a sizeof() of "unsigned char", "char", and "u8" were dropped, since they're redundant. Some manual whitespace fixes were needed in this patch, as Coccinelle really liked to write "=devm_kcalloc..." instead of "= devm_kcalloc...". The Coccinelle script used for this was: // Fix redundant parens around sizeof(). @@ expression HANDLE; type TYPE; expression THING, E; @@ ( devm_kzalloc(HANDLE, - (sizeof(TYPE)) * E + sizeof(TYPE) * E , ...) | devm_kzalloc(HANDLE, - (sizeof(THING)) * E + sizeof(THING) * E , ...) ) // Drop single-byte sizes and redundant parens. @@ expression HANDLE; expression COUNT; typedef u8; typedef __u8; @@ ( devm_kzalloc(HANDLE, - sizeof(u8) * (COUNT) + COUNT , ...) | devm_kzalloc(HANDLE, - sizeof(__u8) * (COUNT) + COUNT , ...) | devm_kzalloc(HANDLE, - sizeof(char) * (COUNT) + COUNT , ...) | devm_kzalloc(HANDLE, - sizeof(unsigned char) * (COUNT) + COUNT , ...) | devm_kzalloc(HANDLE, - sizeof(u8) * COUNT + COUNT , ...) | devm_kzalloc(HANDLE, - sizeof(__u8) * COUNT + COUNT , ...) | devm_kzalloc(HANDLE, - sizeof(char) * COUNT + COUNT , ...) | devm_kzalloc(HANDLE, - sizeof(unsigned char) * COUNT + COUNT , ...) ) // 2-factor product with sizeof(type/expression) and identifier or constant. @@ expression HANDLE; type TYPE; expression THING; identifier COUNT_ID; constant COUNT_CONST; @@ ( - devm_kzalloc + devm_kcalloc (HANDLE, - sizeof(TYPE) * (COUNT_ID) + COUNT_ID, sizeof(TYPE) , ...) | - devm_kzalloc + devm_kcalloc (HANDLE, - sizeof(TYPE) * COUNT_ID + COUNT_ID, sizeof(TYPE) , ...) | - devm_kzalloc + devm_kcalloc (HANDLE, - sizeof(TYPE) * (COUNT_CONST) + COUNT_CONST, sizeof(TYPE) , ...) | - devm_kzalloc + devm_kcalloc (HANDLE, - sizeof(TYPE) * COUNT_CONST + COUNT_CONST, sizeof(TYPE) , ...) | - devm_kzalloc + devm_kcalloc (HANDLE, - sizeof(THING) * (COUNT_ID) + COUNT_ID, sizeof(THING) , ...) | - devm_kzalloc + devm_kcalloc (HANDLE, - sizeof(THING) * COUNT_ID + COUNT_ID, sizeof(THING) , ...) | - devm_kzalloc + devm_kcalloc (HANDLE, - sizeof(THING) * (COUNT_CONST) + COUNT_CONST, sizeof(THING) , ...) | - devm_kzalloc + devm_kcalloc (HANDLE, - sizeof(THING) * COUNT_CONST + COUNT_CONST, sizeof(THING) , ...) ) // 2-factor product, only identifiers. @@ expression HANDLE; identifier SIZE, COUNT; @@ - devm_kzalloc + devm_kcalloc (HANDLE, - SIZE * COUNT + COUNT, SIZE , ...) // 3-factor product with 1 sizeof(type) or sizeof(expression), with // redundant parens removed. @@ expression HANDLE; expression THING; identifier STRIDE, COUNT; type TYPE; @@ ( devm_kzalloc(HANDLE, - sizeof(TYPE) * (COUNT) * (STRIDE) + array3_size(COUNT, STRIDE, sizeof(TYPE)) , ...) | devm_kzalloc(HANDLE, - sizeof(TYPE) * (COUNT) * STRIDE + array3_size(COUNT, STRIDE, sizeof(TYPE)) , ...) | devm_kzalloc(HANDLE, - sizeof(TYPE) * COUNT * (STRIDE) + array3_size(COUNT, STRIDE, sizeof(TYPE)) , ...) | devm_kzalloc(HANDLE, - sizeof(TYPE) * COUNT * STRIDE + array3_size(COUNT, STRIDE, sizeof(TYPE)) , ...) | devm_kzalloc(HANDLE, - sizeof(THING) * (COUNT) * (STRIDE) + array3_size(COUNT, STRIDE, sizeof(THING)) , ...) | devm_kzalloc(HANDLE, - sizeof(THING) * (COUNT) * STRIDE + array3_size(COUNT, STRIDE, sizeof(THING)) , ...) | devm_kzalloc(HANDLE, - sizeof(THING) * COUNT * (STRIDE) + array3_size(COUNT, STRIDE, sizeof(THING)) , ...) | devm_kzalloc(HANDLE, - sizeof(THING) * COUNT * STRIDE + array3_size(COUNT, STRIDE, sizeof(THING)) , ...) ) // 3-factor product with 2 sizeof(variable), with redundant parens removed. @@ expression HANDLE; expression THING1, THING2; identifier COUNT; type TYPE1, TYPE2; @@ ( devm_kzalloc(HANDLE, - sizeof(TYPE1) * sizeof(TYPE2) * COUNT + array3_size(COUNT, sizeof(TYPE1), sizeof(TYPE2)) , ...) | devm_kzalloc(HANDLE, - sizeof(TYPE1) * sizeof(THING2) * (COUNT) + array3_size(COUNT, sizeof(TYPE1), sizeof(TYPE2)) , ...) | devm_kzalloc(HANDLE, - sizeof(THING1) * sizeof(THING2) * COUNT + array3_size(COUNT, sizeof(THING1), sizeof(THING2)) , ...) | devm_kzalloc(HANDLE, - sizeof(THING1) * sizeof(THING2) * (COUNT) + array3_size(COUNT, sizeof(THING1), sizeof(THING2)) , ...) | devm_kzalloc(HANDLE, - sizeof(TYPE1) * sizeof(THING2) * COUNT + array3_size(COUNT, sizeof(TYPE1), sizeof(THING2)) , ...) | devm_kzalloc(HANDLE, - sizeof(TYPE1) * sizeof(THING2) * (COUNT) + array3_size(COUNT, sizeof(TYPE1), sizeof(THING2)) , ...) ) // 3-factor product, only identifiers, with redundant parens removed. @@ expression HANDLE; identifier STRIDE, SIZE, COUNT; @@ ( devm_kzalloc(HANDLE, - (COUNT) * STRIDE * SIZE + array3_size(COUNT, STRIDE, SIZE) , ...) | devm_kzalloc(HANDLE, - COUNT * (STRIDE) * SIZE + array3_size(COUNT, STRIDE, SIZE) , ...) | devm_kzalloc(HANDLE, - COUNT * STRIDE * (SIZE) + array3_size(COUNT, STRIDE, SIZE) , ...) | devm_kzalloc(HANDLE, - (COUNT) * (STRIDE) * SIZE + array3_size(COUNT, STRIDE, SIZE) , ...) | devm_kzalloc(HANDLE, - COUNT * (STRIDE) * (SIZE) + array3_size(COUNT, STRIDE, SIZE) , ...) | devm_kzalloc(HANDLE, - (COUNT) * STRIDE * (SIZE) + array3_size(COUNT, STRIDE, SIZE) , ...) | devm_kzalloc(HANDLE, - (COUNT) * (STRIDE) * (SIZE) + array3_size(COUNT, STRIDE, SIZE) , ...) | devm_kzalloc(HANDLE, - COUNT * STRIDE * SIZE + array3_size(COUNT, STRIDE, SIZE) , ...) ) // Any remaining multi-factor products, first at least 3-factor products, // when they're not all constants... @@ expression HANDLE; expression E1, E2, E3; constant C1, C2, C3; @@ ( devm_kzalloc(HANDLE, C1 * C2 * C3, ...) | devm_kzalloc(HANDLE, - (E1) * E2 * E3 + array3_size(E1, E2, E3) , ...) | devm_kzalloc(HANDLE, - (E1) * (E2) * E3 + array3_size(E1, E2, E3) , ...) | devm_kzalloc(HANDLE, - (E1) * (E2) * (E3) + array3_size(E1, E2, E3) , ...) | devm_kzalloc(HANDLE, - E1 * E2 * E3 + array3_size(E1, E2, E3) , ...) ) // And then all remaining 2 factors products when they're not all constants, // keeping sizeof() as the second factor argument. @@ expression HANDLE; expression THING, E1, E2; type TYPE; constant C1, C2, C3; @@ ( devm_kzalloc(HANDLE, sizeof(THING) * C2, ...) | devm_kzalloc(HANDLE, sizeof(TYPE) * C2, ...) | devm_kzalloc(HANDLE, C1 * C2 * C3, ...) | devm_kzalloc(HANDLE, C1 * C2, ...) | - devm_kzalloc + devm_kcalloc (HANDLE, - sizeof(TYPE) * (E2) + E2, sizeof(TYPE) , ...) | - devm_kzalloc + devm_kcalloc (HANDLE, - sizeof(TYPE) * E2 + E2, sizeof(TYPE) , ...) | - devm_kzalloc + devm_kcalloc (HANDLE, - sizeof(THING) * (E2) + E2, sizeof(THING) , ...) | - devm_kzalloc + devm_kcalloc (HANDLE, - sizeof(THING) * E2 + E2, sizeof(THING) , ...) | - devm_kzalloc + devm_kcalloc (HANDLE, - (E1) * E2 + E1, E2 , ...) | - devm_kzalloc + devm_kcalloc (HANDLE, - (E1) * (E2) + E1, E2 , ...) | - devm_kzalloc + devm_kcalloc (HANDLE, - E1 * E2 + E1, E2 , ...) ) Signed-off-by: Kees Cook <keescook@chromium.org>
154 lines
4.8 KiB
C
154 lines
4.8 KiB
C
/*
|
|
* OpenFirmware helpers for memory drivers
|
|
*
|
|
* Copyright (C) 2012 Texas Instruments, Inc.
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*/
|
|
|
|
#include <linux/device.h>
|
|
#include <linux/platform_device.h>
|
|
#include <linux/list.h>
|
|
#include <linux/of.h>
|
|
#include <linux/gfp.h>
|
|
#include <memory/jedec_ddr.h>
|
|
#include <linux/export.h>
|
|
#include "of_memory.h"
|
|
|
|
/**
|
|
* of_get_min_tck() - extract min timing values for ddr
|
|
* @np: pointer to ddr device tree node
|
|
* @device: device requesting for min timing values
|
|
*
|
|
* Populates the lpddr2_min_tck structure by extracting data
|
|
* from device tree node. Returns a pointer to the populated
|
|
* structure. If any error in populating the structure, returns
|
|
* default min timings provided by JEDEC.
|
|
*/
|
|
const struct lpddr2_min_tck *of_get_min_tck(struct device_node *np,
|
|
struct device *dev)
|
|
{
|
|
int ret = 0;
|
|
struct lpddr2_min_tck *min;
|
|
|
|
min = devm_kzalloc(dev, sizeof(*min), GFP_KERNEL);
|
|
if (!min)
|
|
goto default_min_tck;
|
|
|
|
ret |= of_property_read_u32(np, "tRPab-min-tck", &min->tRPab);
|
|
ret |= of_property_read_u32(np, "tRCD-min-tck", &min->tRCD);
|
|
ret |= of_property_read_u32(np, "tWR-min-tck", &min->tWR);
|
|
ret |= of_property_read_u32(np, "tRASmin-min-tck", &min->tRASmin);
|
|
ret |= of_property_read_u32(np, "tRRD-min-tck", &min->tRRD);
|
|
ret |= of_property_read_u32(np, "tWTR-min-tck", &min->tWTR);
|
|
ret |= of_property_read_u32(np, "tXP-min-tck", &min->tXP);
|
|
ret |= of_property_read_u32(np, "tRTP-min-tck", &min->tRTP);
|
|
ret |= of_property_read_u32(np, "tCKE-min-tck", &min->tCKE);
|
|
ret |= of_property_read_u32(np, "tCKESR-min-tck", &min->tCKESR);
|
|
ret |= of_property_read_u32(np, "tFAW-min-tck", &min->tFAW);
|
|
|
|
if (ret) {
|
|
devm_kfree(dev, min);
|
|
goto default_min_tck;
|
|
}
|
|
|
|
return min;
|
|
|
|
default_min_tck:
|
|
dev_warn(dev, "%s: using default min-tck values\n", __func__);
|
|
return &lpddr2_jedec_min_tck;
|
|
}
|
|
EXPORT_SYMBOL(of_get_min_tck);
|
|
|
|
static int of_do_get_timings(struct device_node *np,
|
|
struct lpddr2_timings *tim)
|
|
{
|
|
int ret;
|
|
|
|
ret = of_property_read_u32(np, "max-freq", &tim->max_freq);
|
|
ret |= of_property_read_u32(np, "min-freq", &tim->min_freq);
|
|
ret |= of_property_read_u32(np, "tRPab", &tim->tRPab);
|
|
ret |= of_property_read_u32(np, "tRCD", &tim->tRCD);
|
|
ret |= of_property_read_u32(np, "tWR", &tim->tWR);
|
|
ret |= of_property_read_u32(np, "tRAS-min", &tim->tRAS_min);
|
|
ret |= of_property_read_u32(np, "tRRD", &tim->tRRD);
|
|
ret |= of_property_read_u32(np, "tWTR", &tim->tWTR);
|
|
ret |= of_property_read_u32(np, "tXP", &tim->tXP);
|
|
ret |= of_property_read_u32(np, "tRTP", &tim->tRTP);
|
|
ret |= of_property_read_u32(np, "tCKESR", &tim->tCKESR);
|
|
ret |= of_property_read_u32(np, "tDQSCK-max", &tim->tDQSCK_max);
|
|
ret |= of_property_read_u32(np, "tFAW", &tim->tFAW);
|
|
ret |= of_property_read_u32(np, "tZQCS", &tim->tZQCS);
|
|
ret |= of_property_read_u32(np, "tZQCL", &tim->tZQCL);
|
|
ret |= of_property_read_u32(np, "tZQinit", &tim->tZQinit);
|
|
ret |= of_property_read_u32(np, "tRAS-max-ns", &tim->tRAS_max_ns);
|
|
ret |= of_property_read_u32(np, "tDQSCK-max-derated",
|
|
&tim->tDQSCK_max_derated);
|
|
|
|
return ret;
|
|
}
|
|
|
|
/**
|
|
* of_get_ddr_timings() - extracts the ddr timings and updates no of
|
|
* frequencies available.
|
|
* @np_ddr: Pointer to ddr device tree node
|
|
* @dev: Device requesting for ddr timings
|
|
* @device_type: Type of ddr(LPDDR2 S2/S4)
|
|
* @nr_frequencies: No of frequencies available for ddr
|
|
* (updated by this function)
|
|
*
|
|
* Populates lpddr2_timings structure by extracting data from device
|
|
* tree node. Returns pointer to populated structure. If any error
|
|
* while populating, returns default timings provided by JEDEC.
|
|
*/
|
|
const struct lpddr2_timings *of_get_ddr_timings(struct device_node *np_ddr,
|
|
struct device *dev, u32 device_type, u32 *nr_frequencies)
|
|
{
|
|
struct lpddr2_timings *timings = NULL;
|
|
u32 arr_sz = 0, i = 0;
|
|
struct device_node *np_tim;
|
|
char *tim_compat = NULL;
|
|
|
|
switch (device_type) {
|
|
case DDR_TYPE_LPDDR2_S2:
|
|
case DDR_TYPE_LPDDR2_S4:
|
|
tim_compat = "jedec,lpddr2-timings";
|
|
break;
|
|
default:
|
|
dev_warn(dev, "%s: un-supported memory type\n", __func__);
|
|
}
|
|
|
|
for_each_child_of_node(np_ddr, np_tim)
|
|
if (of_device_is_compatible(np_tim, tim_compat))
|
|
arr_sz++;
|
|
|
|
if (arr_sz)
|
|
timings = devm_kcalloc(dev, arr_sz, sizeof(*timings),
|
|
GFP_KERNEL);
|
|
|
|
if (!timings)
|
|
goto default_timings;
|
|
|
|
for_each_child_of_node(np_ddr, np_tim) {
|
|
if (of_device_is_compatible(np_tim, tim_compat)) {
|
|
if (of_do_get_timings(np_tim, &timings[i])) {
|
|
devm_kfree(dev, timings);
|
|
goto default_timings;
|
|
}
|
|
i++;
|
|
}
|
|
}
|
|
|
|
*nr_frequencies = arr_sz;
|
|
|
|
return timings;
|
|
|
|
default_timings:
|
|
dev_warn(dev, "%s: using default timings\n", __func__);
|
|
*nr_frequencies = ARRAY_SIZE(lpddr2_jedec_timings);
|
|
return lpddr2_jedec_timings;
|
|
}
|
|
EXPORT_SYMBOL(of_get_ddr_timings);
|