mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-26 10:49:33 +00:00
![Robert Jarzmik](/assets/img/avatar_default.png)
On lubbock board, the probe of the driver crashes by dereferencing very early a platform_data structure which is not set, in pxa2xx_configure_sockets(). The stack fixed is : [ 0.244353] SA1111 Microprocessor Companion Chip: silicon revision 1, metal revision 1 [ 0.256321] sa1111 sa1111: Providing IRQ336-390 [ 0.340899] clocksource: Switched to clocksource oscr0 [ 0.472263] Unable to handle kernel NULL pointer dereference at virtual address 00000004 [ 0.480469] pgd = c0004000 [ 0.483432] [00000004] *pgd=00000000 [ 0.487105] Internal error: Oops: f5 [#1] ARM [ 0.491497] Modules linked in: [ 0.494650] CPU: 0 PID: 1 Comm: swapper Not tainted 4.8.0-rc3-00080-g1aaa68426f0c-dirty #2068 [ 0.503229] Hardware name: Intel DBPXA250 Development Platform (aka Lubbock) [ 0.510344] task: c3e42000 task.stack: c3e44000 [ 0.514984] PC is at pxa2xx_configure_sockets+0x4/0x24 (drivers/pcmcia/pxa2xx_base.c:227) [ 0.520193] LR is at pcmcia_lubbock_init+0x1c/0x38 [ 0.525079] pc : [<c0247c30>] lr : [<c02479b0>] psr: a0000053 [ 0.525079] sp : c3e45e70 ip : 100019ff fp : 00000000 [ 0.536651] r10: c0828900 r9 : c0434838 r8 : 00000000 [ 0.541953] r7 : c0820700 r6 : c0857b30 r5 : c3ec1400 r4 : c0820758 [ 0.548549] r3 : 00000000 r2 : 0000000c r1 : c3c09c40 r0 : c3ec1400 [ 0.555154] Flags: NzCv IRQs on FIQs off Mode SVC_32 ISA ARM Segment none [ 0.562450] Control: 0000397f Table: a0004000 DAC: 00000053 [ 0.568257] Process swapper (pid: 1, stack limit = 0xc3e44190) [ 0.574154] Stack: (0xc3e45e70 to 0xc3e46000) [ 0.578610] 5e60: c4849800 00000000 c3ec1400 c024769c [ 0.586928] 5e80: 00000000 c3ec140c c3c0ee0c c3ec1400 c3ec1434 c020c410 c3ec1400 c3ec1434 [ 0.595244] 5ea0: c0820700 c080b408 c0828900 c020c5f8 00000000 c0820700 c020c578 c020ac5c [ 0.603560] 5ec0: c3e687cc c3e71e10 c0820700 00000000 c3c02de0 c020bae4 c03c62f7 c03c62f7 [ 0.611872] 5ee0: c3e68780 c0820700 c042e034 00000000 c043c440 c020cdec c080b408 00000005 [ 0.620188] 5f00: c042e034 c00096c0 c0034440 c01c730c 20000053 ffffffff 00000000 00000000 [ 0.628502] 5f20: 00000000 c3ffcb87 c3ffcb90 c00346ac c3e66ba0 c03f7914 00000092 00000005 [ 0.636811] 5f40: 00000005 c03f847c 00000091 c03f847c 00000000 00000005 c0434828 00000005 [ 0.645125] 5f60: c043482c 00000092 c043c440 c0828900 c0434838 c0418d2c 00000005 00000005 [ 0.653430] 5f80: 00000000 c041858c 00000000 c032e9f0 00000000 00000000 00000000 00000000 [ 0.661729] 5fa0: 00000000 c032e9f8 00000000 c000f0f0 00000000 00000000 00000000 00000000 [ 0.670020] 5fc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 [ 0.678311] 5fe0: 00000000 00000000 00000000 00000000 00000013 00000000 00000000 00000000 [ 0.686673] (pxa2xx_configure_sockets) from pcmcia_lubbock_init (/drivers/pcmcia/sa1111_lubbock.c:161) [ 0.696026] (pcmcia_lubbock_init) from pcmcia_probe (/drivers/pcmcia/sa1111_generic.c:213) [ 0.704358] (pcmcia_probe) from driver_probe_device (/drivers/base/dd.c:378 /drivers/base/dd.c:499) [ 0.712848] (driver_probe_device) from __driver_attach (/./include/linux/device.h:983 /drivers/base/dd.c:733) [ 0.721414] (__driver_attach) from bus_for_each_dev (/drivers/base/bus.c:313) [ 0.729723] (bus_for_each_dev) from bus_add_driver (/drivers/base/bus.c:708) [ 0.738036] (bus_add_driver) from driver_register (/drivers/base/driver.c:169) [ 0.746185] (driver_register) from do_one_initcall (/init/main.c:778) [ 0.754561] (do_one_initcall) from kernel_init_freeable (/init/main.c:843 /init/main.c:851 /init/main.c:869 /init/main.c:1016) [ 0.763409] (kernel_init_freeable) from kernel_init (/init/main.c:944) [ 0.771660] (kernel_init) from ret_from_fork (/arch/arm/kernel/entry-common.S:119) [ 0.779347] Code: c03c6305 c03c631e c03c632e e5903048 (e993000c) All code ======== 0: c03c6305 eorsgt r6, ip, r5, lsl #6 4: c03c631e eorsgt r6, ip, lr, lsl r3 8: c03c632e eorsgt r6, ip, lr, lsr #6 c: e5903048 ldr r3, [r0, #72] ; 0x48 10:* e993000c ldmib r3, {r2, r3} <-- trapping instruction Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
385 lines
10 KiB
C
385 lines
10 KiB
C
/*======================================================================
|
|
|
|
Device driver for the PCMCIA control functionality of PXA2xx
|
|
microprocessors.
|
|
|
|
The contents of this file may be used under the
|
|
terms of the GNU Public License version 2 (the "GPL")
|
|
|
|
(c) Ian Molton (spyro@f2s.com) 2003
|
|
(c) Stefan Eletzhofer (stefan.eletzhofer@inquant.de) 2003,4
|
|
|
|
derived from sa11xx_base.c
|
|
|
|
Portions created by John G. Dorsey are
|
|
Copyright (C) 1999 John G. Dorsey.
|
|
|
|
======================================================================*/
|
|
|
|
#include <linux/module.h>
|
|
#include <linux/slab.h>
|
|
#include <linux/init.h>
|
|
#include <linux/cpufreq.h>
|
|
#include <linux/ioport.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/spinlock.h>
|
|
#include <linux/platform_device.h>
|
|
|
|
#include <mach/hardware.h>
|
|
#include <mach/smemc.h>
|
|
#include <asm/io.h>
|
|
#include <asm/irq.h>
|
|
#include <mach/pxa2xx-regs.h>
|
|
#include <asm/mach-types.h>
|
|
|
|
#include <pcmcia/ss.h>
|
|
#include <pcmcia/cistpl.h>
|
|
|
|
#include "soc_common.h"
|
|
#include "pxa2xx_base.h"
|
|
|
|
/*
|
|
* Personal Computer Memory Card International Association (PCMCIA) sockets
|
|
*/
|
|
|
|
#define PCMCIAPrtSp 0x04000000 /* PCMCIA Partition Space [byte] */
|
|
#define PCMCIASp (4*PCMCIAPrtSp) /* PCMCIA Space [byte] */
|
|
#define PCMCIAIOSp PCMCIAPrtSp /* PCMCIA I/O Space [byte] */
|
|
#define PCMCIAAttrSp PCMCIAPrtSp /* PCMCIA Attribute Space [byte] */
|
|
#define PCMCIAMemSp PCMCIAPrtSp /* PCMCIA Memory Space [byte] */
|
|
|
|
#define PCMCIA0Sp PCMCIASp /* PCMCIA 0 Space [byte] */
|
|
#define PCMCIA0IOSp PCMCIAIOSp /* PCMCIA 0 I/O Space [byte] */
|
|
#define PCMCIA0AttrSp PCMCIAAttrSp /* PCMCIA 0 Attribute Space [byte] */
|
|
#define PCMCIA0MemSp PCMCIAMemSp /* PCMCIA 0 Memory Space [byte] */
|
|
|
|
#define PCMCIA1Sp PCMCIASp /* PCMCIA 1 Space [byte] */
|
|
#define PCMCIA1IOSp PCMCIAIOSp /* PCMCIA 1 I/O Space [byte] */
|
|
#define PCMCIA1AttrSp PCMCIAAttrSp /* PCMCIA 1 Attribute Space [byte] */
|
|
#define PCMCIA1MemSp PCMCIAMemSp /* PCMCIA 1 Memory Space [byte] */
|
|
|
|
#define _PCMCIA(Nb) /* PCMCIA [0..1] */ \
|
|
(0x20000000 + (Nb) * PCMCIASp)
|
|
#define _PCMCIAIO(Nb) _PCMCIA(Nb) /* PCMCIA I/O [0..1] */
|
|
#define _PCMCIAAttr(Nb) /* PCMCIA Attribute [0..1] */ \
|
|
(_PCMCIA(Nb) + 2 * PCMCIAPrtSp)
|
|
#define _PCMCIAMem(Nb) /* PCMCIA Memory [0..1] */ \
|
|
(_PCMCIA(Nb) + 3 * PCMCIAPrtSp)
|
|
|
|
#define _PCMCIA0 _PCMCIA(0) /* PCMCIA 0 */
|
|
#define _PCMCIA0IO _PCMCIAIO(0) /* PCMCIA 0 I/O */
|
|
#define _PCMCIA0Attr _PCMCIAAttr(0) /* PCMCIA 0 Attribute */
|
|
#define _PCMCIA0Mem _PCMCIAMem(0) /* PCMCIA 0 Memory */
|
|
|
|
#define _PCMCIA1 _PCMCIA(1) /* PCMCIA 1 */
|
|
#define _PCMCIA1IO _PCMCIAIO(1) /* PCMCIA 1 I/O */
|
|
#define _PCMCIA1Attr _PCMCIAAttr(1) /* PCMCIA 1 Attribute */
|
|
#define _PCMCIA1Mem _PCMCIAMem(1) /* PCMCIA 1 Memory */
|
|
|
|
|
|
#define MCXX_SETUP_MASK (0x7f)
|
|
#define MCXX_ASST_MASK (0x1f)
|
|
#define MCXX_HOLD_MASK (0x3f)
|
|
#define MCXX_SETUP_SHIFT (0)
|
|
#define MCXX_ASST_SHIFT (7)
|
|
#define MCXX_HOLD_SHIFT (14)
|
|
|
|
static inline u_int pxa2xx_mcxx_hold(u_int pcmcia_cycle_ns,
|
|
u_int mem_clk_10khz)
|
|
{
|
|
u_int code = pcmcia_cycle_ns * mem_clk_10khz;
|
|
return (code / 300000) + ((code % 300000) ? 1 : 0) - 1;
|
|
}
|
|
|
|
static inline u_int pxa2xx_mcxx_asst(u_int pcmcia_cycle_ns,
|
|
u_int mem_clk_10khz)
|
|
{
|
|
u_int code = pcmcia_cycle_ns * mem_clk_10khz;
|
|
return (code / 300000) + ((code % 300000) ? 1 : 0) + 1;
|
|
}
|
|
|
|
static inline u_int pxa2xx_mcxx_setup(u_int pcmcia_cycle_ns,
|
|
u_int mem_clk_10khz)
|
|
{
|
|
u_int code = pcmcia_cycle_ns * mem_clk_10khz;
|
|
return (code / 100000) + ((code % 100000) ? 1 : 0) - 1;
|
|
}
|
|
|
|
/* This function returns the (approximate) command assertion period, in
|
|
* nanoseconds, for a given CPU clock frequency and MCXX_ASST value:
|
|
*/
|
|
static inline u_int pxa2xx_pcmcia_cmd_time(u_int mem_clk_10khz,
|
|
u_int pcmcia_mcxx_asst)
|
|
{
|
|
return (300000 * (pcmcia_mcxx_asst + 1) / mem_clk_10khz);
|
|
}
|
|
|
|
static int pxa2xx_pcmcia_set_mcmem( int sock, int speed, int clock )
|
|
{
|
|
uint32_t val;
|
|
|
|
val = ((pxa2xx_mcxx_setup(speed, clock)
|
|
& MCXX_SETUP_MASK) << MCXX_SETUP_SHIFT)
|
|
| ((pxa2xx_mcxx_asst(speed, clock)
|
|
& MCXX_ASST_MASK) << MCXX_ASST_SHIFT)
|
|
| ((pxa2xx_mcxx_hold(speed, clock)
|
|
& MCXX_HOLD_MASK) << MCXX_HOLD_SHIFT);
|
|
|
|
__raw_writel(val, MCMEM(sock));
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int pxa2xx_pcmcia_set_mcio( int sock, int speed, int clock )
|
|
{
|
|
uint32_t val;
|
|
|
|
val = ((pxa2xx_mcxx_setup(speed, clock)
|
|
& MCXX_SETUP_MASK) << MCXX_SETUP_SHIFT)
|
|
| ((pxa2xx_mcxx_asst(speed, clock)
|
|
& MCXX_ASST_MASK) << MCXX_ASST_SHIFT)
|
|
| ((pxa2xx_mcxx_hold(speed, clock)
|
|
& MCXX_HOLD_MASK) << MCXX_HOLD_SHIFT);
|
|
|
|
__raw_writel(val, MCIO(sock));
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int pxa2xx_pcmcia_set_mcatt( int sock, int speed, int clock )
|
|
{
|
|
uint32_t val;
|
|
|
|
val = ((pxa2xx_mcxx_setup(speed, clock)
|
|
& MCXX_SETUP_MASK) << MCXX_SETUP_SHIFT)
|
|
| ((pxa2xx_mcxx_asst(speed, clock)
|
|
& MCXX_ASST_MASK) << MCXX_ASST_SHIFT)
|
|
| ((pxa2xx_mcxx_hold(speed, clock)
|
|
& MCXX_HOLD_MASK) << MCXX_HOLD_SHIFT);
|
|
|
|
__raw_writel(val, MCATT(sock));
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int pxa2xx_pcmcia_set_mcxx(struct soc_pcmcia_socket *skt, unsigned int clk)
|
|
{
|
|
struct soc_pcmcia_timing timing;
|
|
int sock = skt->nr;
|
|
|
|
soc_common_pcmcia_get_timing(skt, &timing);
|
|
|
|
pxa2xx_pcmcia_set_mcmem(sock, timing.mem, clk);
|
|
pxa2xx_pcmcia_set_mcatt(sock, timing.attr, clk);
|
|
pxa2xx_pcmcia_set_mcio(sock, timing.io, clk);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int pxa2xx_pcmcia_set_timing(struct soc_pcmcia_socket *skt)
|
|
{
|
|
unsigned long clk = clk_get_rate(skt->clk);
|
|
return pxa2xx_pcmcia_set_mcxx(skt, clk / 10000);
|
|
}
|
|
|
|
#ifdef CONFIG_CPU_FREQ
|
|
|
|
static int
|
|
pxa2xx_pcmcia_frequency_change(struct soc_pcmcia_socket *skt,
|
|
unsigned long val,
|
|
struct cpufreq_freqs *freqs)
|
|
{
|
|
switch (val) {
|
|
case CPUFREQ_PRECHANGE:
|
|
if (freqs->new > freqs->old) {
|
|
debug(skt, 2, "new frequency %u.%uMHz > %u.%uMHz, "
|
|
"pre-updating\n",
|
|
freqs->new / 1000, (freqs->new / 100) % 10,
|
|
freqs->old / 1000, (freqs->old / 100) % 10);
|
|
pxa2xx_pcmcia_set_timing(skt);
|
|
}
|
|
break;
|
|
|
|
case CPUFREQ_POSTCHANGE:
|
|
if (freqs->new < freqs->old) {
|
|
debug(skt, 2, "new frequency %u.%uMHz < %u.%uMHz, "
|
|
"post-updating\n",
|
|
freqs->new / 1000, (freqs->new / 100) % 10,
|
|
freqs->old / 1000, (freqs->old / 100) % 10);
|
|
pxa2xx_pcmcia_set_timing(skt);
|
|
}
|
|
break;
|
|
}
|
|
return 0;
|
|
}
|
|
#endif
|
|
|
|
void pxa2xx_configure_sockets(struct device *dev, struct pcmcia_low_level *ops)
|
|
{
|
|
/*
|
|
* We have at least one socket, so set MECR:CIT
|
|
* (Card Is There)
|
|
*/
|
|
uint32_t mecr = MECR_CIT;
|
|
|
|
/* Set MECR:NOS (Number Of Sockets) */
|
|
if ((ops->first + ops->nr) > 1 ||
|
|
machine_is_viper() || machine_is_arcom_zeus())
|
|
mecr |= MECR_NOS;
|
|
|
|
__raw_writel(mecr, MECR);
|
|
}
|
|
EXPORT_SYMBOL(pxa2xx_configure_sockets);
|
|
|
|
static const char *skt_names[] = {
|
|
"PCMCIA socket 0",
|
|
"PCMCIA socket 1",
|
|
};
|
|
|
|
#define SKT_DEV_INFO_SIZE(n) \
|
|
(sizeof(struct skt_dev_info) + (n)*sizeof(struct soc_pcmcia_socket))
|
|
|
|
int pxa2xx_drv_pcmcia_add_one(struct soc_pcmcia_socket *skt)
|
|
{
|
|
skt->res_skt.start = _PCMCIA(skt->nr);
|
|
skt->res_skt.end = _PCMCIA(skt->nr) + PCMCIASp - 1;
|
|
skt->res_skt.name = skt_names[skt->nr];
|
|
skt->res_skt.flags = IORESOURCE_MEM;
|
|
|
|
skt->res_io.start = _PCMCIAIO(skt->nr);
|
|
skt->res_io.end = _PCMCIAIO(skt->nr) + PCMCIAIOSp - 1;
|
|
skt->res_io.name = "io";
|
|
skt->res_io.flags = IORESOURCE_MEM | IORESOURCE_BUSY;
|
|
|
|
skt->res_mem.start = _PCMCIAMem(skt->nr);
|
|
skt->res_mem.end = _PCMCIAMem(skt->nr) + PCMCIAMemSp - 1;
|
|
skt->res_mem.name = "memory";
|
|
skt->res_mem.flags = IORESOURCE_MEM;
|
|
|
|
skt->res_attr.start = _PCMCIAAttr(skt->nr);
|
|
skt->res_attr.end = _PCMCIAAttr(skt->nr) + PCMCIAAttrSp - 1;
|
|
skt->res_attr.name = "attribute";
|
|
skt->res_attr.flags = IORESOURCE_MEM;
|
|
|
|
return soc_pcmcia_add_one(skt);
|
|
}
|
|
EXPORT_SYMBOL(pxa2xx_drv_pcmcia_add_one);
|
|
|
|
void pxa2xx_drv_pcmcia_ops(struct pcmcia_low_level *ops)
|
|
{
|
|
/* Provide our PXA2xx specific timing routines. */
|
|
ops->set_timing = pxa2xx_pcmcia_set_timing;
|
|
#ifdef CONFIG_CPU_FREQ
|
|
ops->frequency_change = pxa2xx_pcmcia_frequency_change;
|
|
#endif
|
|
}
|
|
EXPORT_SYMBOL(pxa2xx_drv_pcmcia_ops);
|
|
|
|
static int pxa2xx_drv_pcmcia_probe(struct platform_device *dev)
|
|
{
|
|
int i, ret = 0;
|
|
struct pcmcia_low_level *ops;
|
|
struct skt_dev_info *sinfo;
|
|
struct soc_pcmcia_socket *skt;
|
|
struct clk *clk;
|
|
|
|
ops = (struct pcmcia_low_level *)dev->dev.platform_data;
|
|
if (!ops) {
|
|
ret = -ENODEV;
|
|
goto err0;
|
|
}
|
|
|
|
if (cpu_is_pxa320() && ops->nr > 1) {
|
|
dev_err(&dev->dev, "pxa320 supports only one pcmcia slot");
|
|
ret = -EINVAL;
|
|
goto err0;
|
|
}
|
|
|
|
clk = devm_clk_get(&dev->dev, NULL);
|
|
if (IS_ERR(clk))
|
|
return -ENODEV;
|
|
|
|
pxa2xx_drv_pcmcia_ops(ops);
|
|
|
|
sinfo = devm_kzalloc(&dev->dev, SKT_DEV_INFO_SIZE(ops->nr),
|
|
GFP_KERNEL);
|
|
if (!sinfo)
|
|
return -ENOMEM;
|
|
|
|
sinfo->nskt = ops->nr;
|
|
|
|
/* Initialize processor specific parameters */
|
|
for (i = 0; i < ops->nr; i++) {
|
|
skt = &sinfo->skt[i];
|
|
|
|
skt->nr = ops->first + i;
|
|
skt->clk = clk;
|
|
soc_pcmcia_init_one(skt, ops, &dev->dev);
|
|
|
|
ret = pxa2xx_drv_pcmcia_add_one(skt);
|
|
if (ret)
|
|
goto err1;
|
|
}
|
|
|
|
pxa2xx_configure_sockets(&dev->dev, ops);
|
|
dev_set_drvdata(&dev->dev, sinfo);
|
|
|
|
return 0;
|
|
|
|
err1:
|
|
while (--i >= 0)
|
|
soc_pcmcia_remove_one(&sinfo->skt[i]);
|
|
|
|
err0:
|
|
return ret;
|
|
}
|
|
|
|
static int pxa2xx_drv_pcmcia_remove(struct platform_device *dev)
|
|
{
|
|
struct skt_dev_info *sinfo = platform_get_drvdata(dev);
|
|
int i;
|
|
|
|
for (i = 0; i < sinfo->nskt; i++)
|
|
soc_pcmcia_remove_one(&sinfo->skt[i]);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int pxa2xx_drv_pcmcia_resume(struct device *dev)
|
|
{
|
|
struct pcmcia_low_level *ops = (struct pcmcia_low_level *)dev->platform_data;
|
|
|
|
pxa2xx_configure_sockets(dev, ops);
|
|
return 0;
|
|
}
|
|
|
|
static const struct dev_pm_ops pxa2xx_drv_pcmcia_pm_ops = {
|
|
.resume = pxa2xx_drv_pcmcia_resume,
|
|
};
|
|
|
|
static struct platform_driver pxa2xx_pcmcia_driver = {
|
|
.probe = pxa2xx_drv_pcmcia_probe,
|
|
.remove = pxa2xx_drv_pcmcia_remove,
|
|
.driver = {
|
|
.name = "pxa2xx-pcmcia",
|
|
.pm = &pxa2xx_drv_pcmcia_pm_ops,
|
|
},
|
|
};
|
|
|
|
static int __init pxa2xx_pcmcia_init(void)
|
|
{
|
|
return platform_driver_register(&pxa2xx_pcmcia_driver);
|
|
}
|
|
|
|
static void __exit pxa2xx_pcmcia_exit(void)
|
|
{
|
|
platform_driver_unregister(&pxa2xx_pcmcia_driver);
|
|
}
|
|
|
|
fs_initcall(pxa2xx_pcmcia_init);
|
|
module_exit(pxa2xx_pcmcia_exit);
|
|
|
|
MODULE_AUTHOR("Stefan Eletzhofer <stefan.eletzhofer@inquant.de> and Ian Molton <spyro@f2s.com>");
|
|
MODULE_DESCRIPTION("Linux PCMCIA Card Services: PXA2xx core socket driver");
|
|
MODULE_LICENSE("GPL");
|
|
MODULE_ALIAS("platform:pxa2xx-pcmcia");
|