linux-stable/drivers/scsi/mpt3sas
Dan Carpenter eba97de9f8 scsi: mpt3sas: Fix double free in attach error handling
commit ee560e7bba upstream.

The caller also calls _base_release_memory_pools() on error so it leads to
a number of double frees:

drivers/scsi/mpt3sas/mpt3sas_base.c:7207 mpt3sas_base_attach() warn: 'ioc->chain_dma_pool' double freed
drivers/scsi/mpt3sas/mpt3sas_base.c:7207 mpt3sas_base_attach() warn: 'ioc->hpr_lookup' double freed
drivers/scsi/mpt3sas/mpt3sas_base.c:7207 mpt3sas_base_attach() warn: 'ioc->internal_lookup' double freed
drivers/scsi/mpt3sas/mpt3sas_base.c:7207 mpt3sas_base_attach() warn: 'ioc->pcie_sgl_dma_pool' double freed
drivers/scsi/mpt3sas/mpt3sas_base.c:7207 mpt3sas_base_attach() warn: 'ioc->reply_dma_pool' double freed
drivers/scsi/mpt3sas/mpt3sas_base.c:7207 mpt3sas_base_attach() warn: 'ioc->reply_free_dma_pool' double freed
drivers/scsi/mpt3sas/mpt3sas_base.c:7207 mpt3sas_base_attach() warn: 'ioc->reply_post_free_array_dma_pool' double freed
drivers/scsi/mpt3sas/mpt3sas_base.c:7207 mpt3sas_base_attach() warn: 'ioc->reply_post_free_dma_pool' double freed
drivers/scsi/mpt3sas/mpt3sas_base.c:7207 mpt3sas_base_attach() warn: 'ioc->sense_dma_pool' double freed

Fixes: 74522a92bb ("scsi: mpt3sas: Optimize I/O memory consumption in driver.")
Link: https://lore.kernel.org/r/20191203093652.gyntgvnkw2udatyc@kili.mountain
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Sreekanth Reddy <sreekanth.reddy@broadcom.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2020-01-17 19:48:21 +01:00
..
mpi scsi: mpt3sas: Update MPI headers to 2.6.8 spec 2019-08-07 22:46:19 -04:00
Kconfig scsi: mpt3sas: Irq poll to avoid CPU hard lockups 2019-03-18 17:16:43 -04:00
Makefile
mpt3sas_base.c scsi: mpt3sas: Fix double free in attach error handling 2020-01-17 19:48:21 +01:00
mpt3sas_base.h scsi: mpt3sas: Introduce module parameter to override queue depth 2019-08-29 17:55:53 -04:00
mpt3sas_config.c scsi: mpt3sas: Enable interrupt coalescing on high iops 2019-06-18 19:46:26 -04:00
mpt3sas_ctl.c scsi: mpt3sas: Reject NVMe Encap cmnds to unsupported HBA 2020-01-04 19:16:26 +01:00
mpt3sas_ctl.h scsi: mpt3sas: Increase event log buffer to support 24 port HBA's. 2018-05-08 00:34:20 -04:00
mpt3sas_debug.h
mpt3sas_scsih.c pci-v5.4-changes 2019-09-23 19:16:01 -07:00
mpt3sas_transport.c scsi: mpt3sas: function pointers of request descriptor 2019-06-18 19:46:25 -04:00
mpt3sas_trigger_diag.c scsi: mpt3sas: Convert uses of pr_<level> with MPT3SAS_FMT to ioc_<level> 2018-10-10 22:00:43 -04:00
mpt3sas_trigger_diag.h
mpt3sas_warpdrive.c scsi: mpt3sas: Convert uses of pr_<level> with MPT3SAS_FMT to ioc_<level> 2018-10-10 22:00:43 -04:00