Dan Carpenter af7aa4fe94 proc/vmcore: fix signedness bug in read_from_oldmem() ... commit 641db40f3a upstream. The bug is the error handling: if (tmp < nr_bytes) { "tmp" can hold negative error codes but because "nr_bytes" is type size_t the negative error codes are treated as very high positive values (success). Fix this by changing "nr_bytes" to type ssize_t. The "nr_bytes" variable is used to store values between 1 and PAGE_SIZE and they can fit in ssize_t without any issue. Link: https://lkml.kernel.org/r/b55f7eed-1c65-4adc-95d1-6c7c65a54a6e@moroto.mountain Fixes: 5d8de293c2 ("vmcore: convert copy_oldmem_page() to take an iov_iter") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org> Acked-by: Baoquan He <bhe@redhat.com> Cc: Dave Young <dyoung@redhat.com> Cc: Vivek Goyal <vgoyal@redhat.com> Cc: Alexey Dobriyan <adobriyan@gmail.com> Cc: <stable@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2023-08-03 10:24:14 +02:00
..
9p	use less confusing names for iov_iter direction initializers	2023-02-09 11:28:04 +01:00
adfs
affs	affs: initialize fsdata in affs_truncate()	2023-02-01 08:34:08 +01:00
afs	afs: Fix accidental truncation when storing data	2023-07-19 16:22:06 +02:00
autofs
befs
bfs
btrfs	btrfs: check for commit error at btrfs_attach_transaction_barrier()	2023-08-03 10:24:13 +02:00
cachefiles
ceph	ceph: don't let check_caps skip sending responses for revoke msgs	2023-07-23 13:49:42 +02:00
coda	coda: Avoid partial allocation of sig_inputArgs	2023-03-10 09:33:52 +01:00
configfs
cramfs	fs/cramfs/inode.c: initialize file_ra_state	2023-03-10 09:34:09 +01:00
crypto	blk-crypto: add a blk_crypto_config_supported_natively helper	2023-05-11 23:03:00 +09:00
debugfs
devpts
dlm	fs: dlm: fix mismatch of plock results from userspace	2023-07-23 13:49:38 +02:00
ecryptfs
efivarfs
efs
erofs	erofs: fix fsdax unavailability for chunk-based regular files	2023-07-23 13:49:26 +02:00
exfat	exfat: fix inode->i_blocks for non-512 byte sector size device	2023-03-10 09:34:08 +01:00
exportfs
ext2	ext2/dax: Fix ext2_setsize when len is page aligned	2023-07-23 13:49:34 +02:00
ext4	ext4: correct inline offset when handling xattrs in inode body	2023-07-27 08:50:31 +02:00
f2fs	f2fs: fix deadlock in i_xattr_sem and inode page lock	2023-07-23 13:49:29 +02:00
fat
freevxfs
fscache	fscache: Use clear_and_wake_up_bit() in fscache_create_volume_work()	2023-02-22 12:59:43 +01:00
fuse	fuse: ioctl: translate ENOSYS in outarg	2023-07-27 08:50:25 +02:00
gfs2	gfs2: Fix duplicate should_fault_in_pages() call	2023-07-19 16:21:54 +02:00
hfs	hfs: fix missing hfs_bnode_get() in __hfs_bnode_create	2023-03-10 09:34:07 +01:00
hfsplus	fs: hfsplus: remove WARN_ON() from hfsplus_cat_{read,write}_inode()	2023-05-24 17:32:34 +01:00
hostfs
hpfs
hugetlbfs	hugetlbfs: fix null-ptr-deref in hugetlbfs_parse_param()	2022-12-31 13:33:05 +01:00
iomap
isofs
jbd2	jbd2: Fix wrongly judgement for buffer head removing while doing checkpoint	2023-08-03 10:23:47 +02:00
jffs2	jffs2: reduce stack usage in jffs2_build_xattr_subsystem()	2023-07-19 16:22:11 +02:00
jfs	FS: JFS: Check for read-only mounted filesystem in txBegin	2023-07-27 08:50:33 +02:00
kernfs	kernfs: fix missing kernfs_idr_lock to remove an ID from the IDR	2023-07-19 16:21:53 +02:00
lockd	lockd: drop inappropriate svc_get() from locked_get()	2023-07-19 16:20:56 +02:00
minix
netfs	use less confusing names for iov_iter direction initializers	2023-02-09 11:28:04 +01:00
nfs	NFSv4.1: freeze the session table upon receiving NFS4ERR_BADSESSION	2023-07-19 16:21:43 +02:00
nfs_common
nfsd	nfsd: Remove incorrect check in nfsd4_validate_stateid	2023-08-03 10:24:13 +02:00
nilfs2	nilfs2: prevent general protection fault in nilfs_clear_dirty_page()	2023-06-28 11:12:27 +02:00
nls
notify	fanotify: disallow mount/sb marks on kernel internal pseudo fs	2023-07-19 16:22:05 +02:00
ntfs
ntfs3	fs/ntfs3: Check fields while reading	2023-07-23 13:49:27 +02:00
ocfs2	ocfs2: Fix use of slab data with sendpage	2023-07-19 16:21:13 +02:00
omfs
openpromfs
orangefs	use less confusing names for iov_iter direction initializers	2023-02-09 11:28:04 +01:00
overlayfs	ovl: fix null pointer dereference in ovl_permission()	2023-08-03 10:23:47 +02:00
proc	proc/vmcore: fix signedness bug in read_from_oldmem()	2023-08-03 10:24:14 +02:00
pstore	pstore/ram: Add check for kstrdup	2023-07-19 16:21:03 +02:00
qnx4
qnx6
quota	quota: fix warning in dqgrab()	2023-07-27 08:50:32 +02:00
ramfs	shmem: use ramfs_kill_sb() for kill_sb method of ramfs-based tmpfs	2023-07-19 16:22:11 +02:00
reiserfs	reiserfs: Add security prefix to xattr name in reiserfs_security_write()	2023-05-11 23:03:02 +09:00
romfs
smb	smb3: do not set NTLMSSP_VERSION flag for negotiate not auth request	2023-08-03 10:24:04 +02:00
squashfs	revert "squashfs: harden sanity check in squashfs_read_xattr_id_table"	2023-02-22 12:59:50 +01:00
sysfs
sysv
tracefs
ubifs	ubifs: Fix memory leak in do_rename	2023-05-11 23:03:05 +09:00
udf	udf: Fix uninitialized array access for some pathnames	2023-07-27 08:50:32 +02:00
ufs
unicode
vboxsf
verity	fsverity: don't drop pagecache at end of FS_IOC_ENABLE_VERITY	2023-04-06 12:10:34 +02:00
xfs	xfs: fix xfs_inodegc_stop racing with mod_delayed_work	2023-07-19 16:22:15 +02:00
zonefs	zonefs: Always invalidate last cached page on append write	2023-04-06 12:10:52 +02:00
aio.c	aio: fix mremap after fork null-deref	2023-02-22 12:59:46 +01:00
anon_inodes.c
attr.c	attr: use consistent sgid stripping checks	2023-03-03 11:52:25 +01:00
bad_inode.c
binfmt_elf.c	mm: always expand the stack with the mmap write lock held	2023-07-01 13:16:25 +02:00
binfmt_elf_fdpic.c	elfcore: Add a cprm parameter to elf_core_extra_{phdrs,data_size}	2023-01-18 11:58:12 +01:00
binfmt_elf_test.c
binfmt_flat.c
binfmt_misc.c	binfmt_misc: fix shift-out-of-bounds in check_special_flags	2022-12-31 13:32:57 +01:00
binfmt_script.c
buffer.c
char_dev.c	chardev: fix error handling in cdev_device_add()	2022-12-31 13:32:41 +01:00
compat_binfmt_elf.c
coredump.c	coredump: Move dump_emit_page() to kill unused warning	2023-02-22 12:59:50 +01:00
d_path.c
dax.c
dcache.c
direct-io.c
drop_caches.c
eventfd.c	eventfd: provide a eventfd_signal_mask() helper	2023-01-04 11:28:48 +01:00
eventpoll.c	epoll: ep_autoremove_wake_function should use list_del_init_careful	2023-06-21 16:00:54 +02:00
exec.c	mm: always expand the stack with the mmap write lock held	2023-07-01 13:16:25 +02:00
fcntl.c
fhandle.c
file.c	file: always lock position for FMODE_ATOMIC_POS	2023-08-03 10:24:13 +02:00
file_table.c
filesystems.c
fs-writeback.c	writeback: fix call of incorrect macro	2023-05-17 11:53:33 +02:00
fs_context.c	fs: avoid empty option when generating legacy mount string	2023-07-19 16:22:11 +02:00
fs_parser.c	ext4: journal_path mount options should follow links	2023-01-07 11:11:59 +01:00
fs_pin.c
fs_struct.c
fs_types.c
fsopen.c
init.c
inode.c	fs: Establish locking order for unrelated directories	2023-07-19 16:22:12 +02:00
internal.h	fs: Establish locking order for unrelated directories	2023-07-19 16:22:12 +02:00
ioctl.c
Kconfig	smb: move client and server files to common directory fs/smb	2023-06-28 11:12:40 +02:00
Kconfig.binfmt
kernel_read_file.c
libfs.c
locks.c	filelocks: use mount idmapping for setlease permission check	2023-03-17 08:50:32 +01:00
Makefile	smb: move client and server files to common directory fs/smb	2023-06-28 11:12:40 +02:00
mbcache.c	ext4: fix deadlock due to mbcache entry corruption	2023-01-07 11:12:02 +01:00
mount.h
mpage.c
namei.c	fs: no need to check source	2023-07-19 16:22:15 +02:00
namespace.c	fs: drop peer group ids under namespace lock	2023-04-13 16:55:33 +02:00
no-block.c
nsfs.c
open.c	open: return EINVAL for O_DIRECTORY | O_CREAT	2023-05-24 17:32:34 +01:00
pipe.c
pnode.c	pnode: terminate at peers of source	2023-01-04 11:29:01 +01:00
pnode.h
posix_acl.c
proc_namespace.c
read_write.c	use less confusing names for iov_iter direction initializers	2023-02-09 11:28:04 +01:00
readdir.c
remap_range.c
select.c
seq_file.c	use less confusing names for iov_iter direction initializers	2023-02-09 11:28:04 +01:00
signalfd.c
splice.c	use less confusing names for iov_iter direction initializers	2023-02-09 11:28:04 +01:00
stack.c
stat.c
statfs.c	statfs: enforce statfs[64] structure initialization	2023-05-24 17:32:51 +01:00
super.c	fscrypt: destroy keyring after security_sb_delete()	2023-03-30 12:49:23 +02:00
sync.c
sysctls.c
timerfd.c
userfaultfd.c	Revert "userfaultfd: don't fail on unrecognized features"	2023-04-26 14:28:37 +02:00
utimes.c
xattr.c